From: Nikita Shubin <nikita.shubin@maquefel.me>
To: Stephen Boyd <sboyd@kernel.org>,
Alexander Sverdlin <alexander.sverdlin@gmail.com>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Nikita Shubin via B4 Relay
<devnull+nikita.shubin.maquefel.me@kernel.org>,
Rob Herring <robh@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 2/4] clk: ep93xx: add DT support for Cirrus EP93xx
Date: Sun, 14 Apr 2024 12:35:00 +0300 [thread overview]
Message-ID: <1133974853f647ce1e575ac064e90fa852ce535b.camel@maquefel.me> (raw)
In-Reply-To: <eea032865f00a0d54b99bbe66d4b6135.sboyd@kernel.org>
Hello Stephen!
All notes taken in account, except:
On Thu, 2024-04-11 at 02:32 -0700, Stephen Boyd wrote:
> Quoting Nikita Shubin via B4 Relay (2024-04-08 01:09:54)
> >
> > + ret = clk_hw_register_div(clk, "ep93xx-adc", &xtali,
>
> Use devm?
This clk-ep93xx internal function and it uses devm:
```
static int clk_hw_register_div(...)
...
return devm_clk_hw_register(priv->dev, &clk->hw);
```
next prev parent reply other threads:[~2024-04-14 9:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 8:09 [PATCH 0/4] DONOTMERGE: ep93xx-clk from ep93xx device tree conversion Nikita Shubin via B4 Relay
2024-04-08 8:09 ` [PATCH 1/4] ARM: ep93xx: add regmap aux_dev Nikita Shubin via B4 Relay
2024-04-11 9:32 ` Stephen Boyd
2024-04-08 8:09 ` [PATCH 2/4] clk: ep93xx: add DT support for Cirrus EP93xx Nikita Shubin via B4 Relay
2024-04-11 9:32 ` Stephen Boyd
2024-04-14 9:35 ` Nikita Shubin [this message]
2024-04-08 8:09 ` [PATCH 3/4] dt-bindings: soc: Add " Nikita Shubin via B4 Relay
2024-04-11 9:21 ` Stephen Boyd
2024-04-08 8:09 ` [PATCH 4/4] soc: Add SoC driver for Cirrus ep93xx Nikita Shubin via B4 Relay
2024-04-11 9:26 ` Stephen Boyd
2024-04-08 17:03 ` [PATCH 0/4] DONOTMERGE: ep93xx-clk from ep93xx device tree conversion Conor Dooley
2024-04-09 11:48 ` Nikita Shubin
2024-04-09 15:09 ` Alexander Sverdlin
2024-04-09 17:32 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1133974853f647ce1e575ac064e90fa852ce535b.camel@maquefel.me \
--to=nikita.shubin@maquefel.me \
--cc=alexander.sverdlin@gmail.com \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=devnull+nikita.shubin.maquefel.me@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).