From: Pavel Shilovsky <pshilovsky@samba.org>
To: Sam James <sam@gentoo.org>
Cc: linux-cifs@vger.kernel.org, Steve French <smfrench@gmail.com>
Subject: Re: [PATCH 1/2] getcifsacl, setcifsacl: add missing <linux/limits.h> include for XATTR_SIZE_MAX
Date: Mon, 25 Mar 2024 18:26:42 -0700 [thread overview]
Message-ID: <CAKywueTjdJRwRwwFYjiy9xppZ_xggUWjBDBirrQhw_gM-0qoXA@mail.gmail.com> (raw)
In-Reply-To: <20220816004335.2634169-1-sam@gentoo.org>
Merged #1 and #2 into next. Thanks. Sorry, I missed these patches previously.
Best regards,
Pavel Shilovsky
пн, 15 авг. 2022 г. в 17:43, Sam James <sam@gentoo.org>:
>
> Needed to build on musl. It only works on glibc because of transitive includes
> (which could break in future).
>
> Example failure:
> ```
> getcifsacl.c: In function 'getcifsacl':
> getcifsacl.c:429:24: error: 'XATTR_SIZE_MAX' undeclared (first use in this function)
> 429 | if (bufsize >= XATTR_SIZE_MAX) {
> | ^~~~~~~~~~~~~~
> ```
>
> Bug: https://bugs.gentoo.org/842195
> Signed-off-by: Sam James <sam@gentoo.org>
> ---
> getcifsacl.c | 1 +
> setcifsacl.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/getcifsacl.c b/getcifsacl.c
> index 1c01062..d69d40a 100644
> --- a/getcifsacl.c
> +++ b/getcifsacl.c
> @@ -34,6 +34,7 @@
> #include <errno.h>
> #include <limits.h>
> #include <ctype.h>
> +#include <linux/limits.h>
> #include <sys/xattr.h>
> #include "cifsacl.h"
> #include "idmap_plugin.h"
> diff --git a/setcifsacl.c b/setcifsacl.c
> index d832cec..b7079ab 100644
> --- a/setcifsacl.c
> +++ b/setcifsacl.c
> @@ -48,6 +48,7 @@
> #include <errno.h>
> #include <limits.h>
> #include <ctype.h>
> +#include <linux/limits.h>
> #include <sys/xattr.h>
>
> #include "cifsacl.h"
> --
> 2.37.2
>
next prev parent reply other threads:[~2024-03-26 1:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 0:43 [PATCH 1/2] getcifsacl, setcifsacl: add missing <linux/limits.h> include for XATTR_SIZE_MAX Sam James
2022-08-16 0:43 ` [PATCH 2/2] getcifsacl, setcifsacl: add missing <endian.h> include for le32toh Sam James
2024-03-26 1:26 ` Pavel Shilovsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-02-11 22:39 [PATCH 1/2] getcifsacl, setcifsacl: add missing <linux/limits.h> include for XATTR_SIZE_MAX Sam James
2022-06-24 4:54 Sam James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKywueTjdJRwRwwFYjiy9xppZ_xggUWjBDBirrQhw_gM-0qoXA@mail.gmail.com \
--to=pshilovsky@samba.org \
--cc=linux-cifs@vger.kernel.org \
--cc=sam@gentoo.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).