From: Namjae Jeon <linkinjeon@kernel.org>
To: Marios Makassikis <mmakassikis@freebox.fr>
Cc: linux-cifs@vger.kernel.org
Subject: Re: [PATCH v2] ksmbd: clear RENAME_NOREPLACE before calling vfs_rename
Date: Tue, 16 Apr 2024 21:40:44 +0900 [thread overview]
Message-ID: <CAKYAXd_be_Jwm0VejViiC9Zcc8CR7ULRVsczrhaxusJNV4tZSA@mail.gmail.com> (raw)
In-Reply-To: <20240415131247.2162106-1-mmakassikis@freebox.fr>
2024년 4월 15일 (월) 오후 10:13, Marios Makassikis <mmakassikis@freebox.fr>님이 작성:
>
> File overwrite case is explicitly handled, so it is not necessary to
> pass RENAME_NOREPLACE to vfs_rename.
>
> Clearing the flag fixes rename operations when the share is a ntfs-3g
> mount. The latter uses an older version of fuse with no support for
> flags in the ->rename op.
>
> Signed-off-by: Marios Makassikis <mmakassikis@freebox.fr>
Applied it to #ksmbd-for-next-next.
Thanks for your patch!
prev parent reply other threads:[~2024-04-16 12:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 13:07 [PATCH] ksmbd: clear RENAME_NOREPLACE before calling vfs_rename Marios Makassikis
2024-04-15 9:00 ` Marios Makassikis
2024-04-15 10:51 ` Namjae Jeon
2024-04-15 12:36 ` Marios Makassikis
2024-04-15 12:55 ` Namjae Jeon
2024-04-15 13:12 ` [PATCH v2] " Marios Makassikis
2024-04-16 12:40 ` Namjae Jeon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKYAXd_be_Jwm0VejViiC9Zcc8CR7ULRVsczrhaxusJNV4tZSA@mail.gmail.com \
--to=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=mmakassikis@freebox.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).