From: Francesco Valla <valla.francesco@gmail.com>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: Vincent Mailhol <vincent.mailhol@gmail.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Simon Horman <horms@kernel.org>,
Bagas Sanjaya <bagasdotme@gmail.com>,
fabio@redaril.me
Subject: Re: [PATCH v2 1/1] Documentation: networking: document ISO 15765-2:2016
Date: Sun, 21 Apr 2024 22:41:59 +0200 [thread overview]
Message-ID: <ZiV6FwQWECidli7D@fedora> (raw)
In-Reply-To: <94638dbd-4768-4110-b85f-f158ced21ba0@hartkopp.net>
On Sat, Apr 20, 2024 at 09:51:41PM +0200, Oliver Hartkopp wrote:
> On 17.04.24 17:21, Vincent Mailhol wrote:
>
> > If we bump the version to :2024, then I suggest to:
> >
> > - add a first patch in this series to update Kconfig.
> > - add your documentation as a second patch directly with the :2024 version.
> >
>
> Ok.
>
> > I can also use ISO 11898-1 as an example. Our documentation says that
> > we support ISO 11898-1:2015. The previous version: ISO 11898-1:2003 is
> > not mentioned a single time in the full kernel tree. Yet, I do not
> > think that any one was ever confused that the kernel may not be
> > compatible with ISO 11898-1:2003.
> >
> > If you really think that there is a risk of confusion, then maybe just
> > adding a sentence to say that we support ISO 15765-2:2024 and all
> > previous versions would be enough?
> >
> > But overall, I do not see the benefit to keep the older version.
>
> We currently have different occurrences of the 15765-2 term:
>
> $ git grep "15765-2"
> include/uapi/linux/can.h:#define CAN_ISOTP 6 /* ISO 15765-2 Transport
> Protocol */
> include/uapi/linux/can/isotp.h: * Definitions for isotp CAN sockets (ISO
> 15765-2:2016)
> net/can/Kconfig: tristate "ISO 15765-2:2016 CAN transport protocol"
> net/can/Kconfig: ISO 15765-2:2016 for 'classic' CAN and CAN FD
> frame types.
> net/can/isotp.c:/* isotp.c - ISO 15765-2 CAN transport protocol for protocol
> family CAN
> net/can/isotp.c:MODULE_DESCRIPTION("PF_CAN isotp 15765-2:2016 protocol");
> net/can/isotp.c:/* ISO 15765-2:2016 supports more than 4095 byte per ISO PDU
> as the FF_DL can
> net/can/isotp.c:/* maximum PDU size before ISO 15765-2:2016 extension was
> 4095 */
>
> I've sent a patch to remove the ISO 15675-2 specification version/date where
> possible:
> https://lore.kernel.org/linux-can/20240420194746.4885-1-socketcan@hartkopp.net/T/#u
>
> This also makes clear where the ISO 15765-2:2016 remains helpful IMHO.
>
> I would be fine to remove the version/date in the documentation from
> Francesco where possible too.
>
Ok, I'll follow this path (first RFC for this patch was without dates).
I'll try to send a revised v3, also with the details on the mixed
addressing, as soon as possible.
Thank you
Regards,
Francesco
next prev parent reply other threads:[~2024-04-21 20:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 13:34 [PATCH v2 0/1] Documentation: networking: document ISO 15765-2:2016 Francesco Valla
2024-03-29 13:34 ` [PATCH v2 1/1] " Francesco Valla
2024-04-13 13:11 ` Vincent Mailhol
2024-04-13 17:28 ` Oliver Hartkopp
2024-04-14 4:03 ` Vincent Mailhol
2024-04-14 20:21 ` Oliver Hartkopp
2024-04-15 5:29 ` Vincent Mailhol
2024-04-16 16:42 ` Francesco Valla
2024-04-16 17:19 ` Oliver Hartkopp
2024-04-17 15:21 ` Vincent Mailhol
2024-04-20 19:51 ` Oliver Hartkopp
2024-04-21 20:41 ` Francesco Valla [this message]
2024-04-16 16:27 ` Francesco Valla
2024-04-17 15:26 ` Vincent Mailhol
2024-04-15 3:09 ` Bagas Sanjaya
2024-04-16 16:46 ` Francesco Valla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZiV6FwQWECidli7D@fedora \
--to=valla.francesco@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=fabio@redaril.me \
--cc=horms@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=vincent.mailhol@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).