From: <Thomas.Kopp@microchip.com>
To: <mkl@pengutronix.de>, <linux-can@vger.kernel.org>
Cc: <mani@kernel.org>, <Stefan.Althoefer@janztec.com>,
<kernel@pengutronix.de>
Subject: RE: [PATCH v1 0/2] can: mcp251xfd: better workaround broken TX FIFO STA register read
Date: Mon, 4 Dec 2023 09:15:42 +0000 [thread overview]
Message-ID: <BL3PR11MB6484F25C35C5E0A9937FE20BFB86A@BL3PR11MB6484.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230124152729.814840-1-mkl@pengutronix.de>
Hi Marc,
> Hello,
>
> this is an attempt to better workaround broken TX FIFO STA register
> reads. This series implements a workaround similar to the "workaround
> broken RX FIFO STA register read" [1] and should be applied to a
> kernel tree containing that series.
>
> This gets rid of the "Transmit Event FIFO buffer not empty/full", for
> debugging purposes you can enable an error message by adding a
> "#define DEBUG" in "drivers/net/can/spi/mcp251xfd/mcp251xfd-tef.c".
>
> For every detected error the tx_fifo_error is increased.
>
> [1] https://lore.kernel.org/all/20230119112842.500709-1-
> mkl@pengutronix.de
>
> regards,
> Marc
The new erratasheet is finally live: https://ww1.microchip.com/downloads/aemDocuments/documents/APID/ProductDocuments/Errata/MCP2518FD-Errata-DS80000789.pdf
The analysis showed that this specific bug only affects that one register which is covered by the workaround. I believe the workaround worked back then on my boards. Was there any feedback that showed issues with it? Could it be merged now that we have the documentation in place?
Thomas
prev parent reply other threads:[~2023-12-04 9:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 15:27 [PATCH v1 0/2] can: mcp251xfd: better workaround broken TX FIFO STA register read Marc Kleine-Budde
2023-01-24 15:27 ` [PATCH v1 1/2] can: mcp251xfd: tef: prepare to workaround broken RX FIFO tail index erratum Marc Kleine-Budde
2023-01-24 15:27 ` [PATCH v1 2/2] can: mcp251xfd: tef: use new workaround Marc Kleine-Budde
2023-12-04 9:15 ` Thomas.Kopp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL3PR11MB6484F25C35C5E0A9937FE20BFB86A@BL3PR11MB6484.namprd11.prod.outlook.com \
--to=thomas.kopp@microchip.com \
--cc=Stefan.Althoefer@janztec.com \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).