From: Simon Horman <horms@kernel.org>
To: Francesco Valla <valla.francesco@gmail.com>
Cc: Oliver Hartkopp <socketcan@hartkopp.net>,
Marc Kleine-Budde <mkl@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
fabio@redaril.me, linux-can@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Documentation: networking: document CAN ISO-TP
Date: Thu, 21 Mar 2024 12:34:31 +0000 [thread overview]
Message-ID: <20240321123431.GB356367@kernel.org> (raw)
In-Reply-To: <ZftkmQfna3HIyYal@fedora>
On Wed, Mar 20, 2024 at 11:35:05PM +0100, Francesco Valla wrote:
>
> Hi Simon,
>
> On Tue, Mar 19, 2024 at 12:06:25PM +0000, Simon Horman wrote:
> > On Wed, Mar 13, 2024 at 11:34:31PM +0100, Francesco Valla wrote:
> > > Document basic concepts, APIs and behaviour of the CAN ISO-TP (ISO
> > > 15765-2) stack.
> > >
> > > Signed-off-by: Francesco Valla <valla.francesco@gmail.com>
> >
> > Hi Francesco,
> >
> > As it looks like there will be a v2 of this patchset
> > please consider running checkpatch.pl --codespell
> > and addressing the warnings it reports.
> >
>
> Will do before v2, thanks for the suggestion.
>
> > ...
> >
> > > +Transport protocol and associated frame types
> > > +---------------------------------------------
> > > +
> > > +When transmitting data using the ISO-TP protocol, the payload can either fit
> > > +inside one single CAN message or not, also considering the overhead the protocol
> > > +is generating and the optional extended addressing. In the first case, the data
> > > +is transmitted at once using a so-called Single Frame (SF). In the second case,
> > > +ISO-TP defines a multi-frame protocol, in which the sender asks (through a First
> > > +Frame - FF) to the receiver the maximum supported size of a macro data block
> > > +(``blocksize``) and the minimum time time between the single CAN messages
> > > +composing such block (``stmin``). Once these informations have been received,
> >
> > nit: Once this information has
>
> I never grasped the usage of "information" in English, which is not my
> first language. I'll make this correction here.
I can't explain it properly, but my basic understanding
is that in English information is non-countable and thus has no plural.
Water is another example of a non-countable noun.
> > > +the sender starts to send frames containing fragments of the data payload
> > > +(called Consecutive Frames - CF), stopping after every ``blocksize``-sized block
> > > +to wait confirmation from the receiver (which should then send a Flow Control
> > > +frame - FC - to inform the sender about its availability to receive more data).
> > > +
> >
> > ...
>
> Thanks for the review!
>
> Regards,
> Francesco
>
prev parent reply other threads:[~2024-03-21 12:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 22:34 [RFC PATCH 0/1] Documentation: networking: document CAN ISO-TP Francesco Valla
2024-03-13 22:34 ` [PATCH 1/1] " Francesco Valla
2024-03-14 11:20 ` Marc Kleine-Budde
2024-03-14 21:12 ` Francesco Valla
2024-03-14 12:59 ` Oliver Hartkopp
2024-03-14 22:38 ` Francesco Valla
2024-03-15 4:55 ` Bagas Sanjaya
2024-03-15 16:36 ` Francesco Valla
2024-03-19 12:06 ` Simon Horman
2024-03-20 22:35 ` Francesco Valla
2024-03-21 12:34 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240321123431.GB356367@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fabio@redaril.me \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=socketcan@hartkopp.net \
--cc=valla.francesco@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).