From: Simon Horman <horms@kernel.org>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: Daniil Dulov <d.dulov@aladdin.ru>,
Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH] can: softing: remove redundant NULL check
Date: Tue, 20 Feb 2024 13:40:34 +0000 [thread overview]
Message-ID: <20240220134034.GM40273@kernel.org> (raw)
In-Reply-To: <e9f2c716-51d3-4c03-a447-9fed357669c5@hartkopp.net>
On Mon, Feb 19, 2024 at 09:37:46PM +0100, Oliver Hartkopp wrote:
> Hi Simon,
>
> On 2024-02-19 18:00, Simon Horman wrote:
> > On Fri, Feb 16, 2024 at 08:47:43PM +0100, Oliver Hartkopp wrote:
> > > Hi Simon,
> > >
> > > I have a general question on the "Fixes:" tag in this patch:
> > >
> > > On 16.02.24 18:27, Simon Horman wrote:
> > > > On Sun, Feb 11, 2024 at 07:05:35AM -0800, Daniil Dulov wrote:
> > > > > In this case dev cannot be NULL, so remove redundant check.
> > > > >
> > > > > Found by Linux Verification Center (linuxtesting.org) with SVACE.
> > > > >
> > > > > Fixes: 03fd3cf5a179 ("can: add driver for Softing card")
> > >
> > > IMHO this is simply an improvement which is done by all patches applied to
> > > the kernel but it does not really "fix" anything from a functional
> > > standpoint.
> > >
> > > Shouldn't we either invent a new tag or better leave it out to not confuse
> > > the stable maintainers?
> >
> > Hi Oliver,
> >
> > sorry for missing that in my review.
> >
> > Yes, I agree that this is probably not a fix, for which my
> > rule of thumb is something that addresses a user-visible problem.
> > So I agree it should not have a fixes tag.
> >
> > I would suggest that we can just change the text to something that
> > has no tag. Something like:
> >
> > ...
> >
> > Introduced by 03fd3cf5a179 ("can: add driver for Softing card")
> >
>
> Yes, but the "Introduced-by:" tag would be an optional tag for people that
> like blaming others, right?
Yes, That does seem useful to me.
> IMHO we should think about completely removing the "Fixes:" tag, when it has
> no user-visible effect that might be a candidate for stable kernels. It is
> common improvement work. And it has been so for years.
Likewise, that does sound like a good idea to me.
prev parent reply other threads:[~2024-02-20 13:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-11 15:05 [PATCH] can: softing: remove redundant NULL check Daniil Dulov
2024-02-16 17:27 ` Simon Horman
2024-02-16 19:47 ` Oliver Hartkopp
2024-02-19 17:00 ` Simon Horman
2024-02-19 20:37 ` Oliver Hartkopp
2024-02-20 13:40 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240220134034.GM40273@kernel.org \
--to=horms@kernel.org \
--cc=d.dulov@aladdin.ru \
--cc=davem@davemloft.net \
--cc=dev.kurt@vandijck-laurijssen.be \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).