From: Conor Dooley <conor@kernel.org>
To: Srinivas Goud <srinivas.goud@amd.com>
Cc: wg@grandegger.com, mkl@pengutronix.de, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, p.zabel@pengutronix.de, git@amd.com,
michal.simek@xilinx.com, linux-can@vger.kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, appana.durga.rao@xilinx.com,
naga.sureshkumar.relli@xilinx.com
Subject: Re: [PATCH v5 1/3] dt-bindings: can: xilinx_can: Add 'xlnx,has-ecc' optional property
Date: Sun, 19 Nov 2023 13:37:28 +0000 [thread overview]
Message-ID: <20231119-dotted-feast-eb01cbebde42@spud> (raw)
In-Reply-To: <1700213336-652-2-git-send-email-srinivas.goud@amd.com>
[-- Attachment #1: Type: text/plain, Size: 1927 bytes --]
On Fri, Nov 17, 2023 at 02:58:54PM +0530, Srinivas Goud wrote:
> ECC feature added to CAN TX_OL, TX_TL and RX FIFOs of
> Xilinx AXI CAN Controller.
> Part of this feature configuration and counter registers added in
"ECC is an IP configuration option where counter registers are added..."
The sentence is hard to parse for the important bit of information - the
justification for this being a property rather than based on compatible
or autodetectable based on some IP version etc.
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
> IP for 1bit/2bit ECC errors.
>
> 'xlnx,has-ecc' is optional property and added to Xilinx AXI CAN Controller
> node if ECC block enabled in the HW
>
> Signed-off-by: Srinivas Goud <srinivas.goud@amd.com>
> ---
> Changes in v5:
> Update property description
>
> Changes in v4:
> Fix binding check warning
> Update property description
>
> Changes in v3:
> Update commit description
>
> Changes in v2:
> None
>
> Documentation/devicetree/bindings/net/can/xilinx,can.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/can/xilinx,can.yaml b/Documentation/devicetree/bindings/net/can/xilinx,can.yaml
> index 64d57c3..8d4e5af 100644
> --- a/Documentation/devicetree/bindings/net/can/xilinx,can.yaml
> +++ b/Documentation/devicetree/bindings/net/can/xilinx,can.yaml
> @@ -49,6 +49,10 @@ properties:
> resets:
> maxItems: 1
>
> + xlnx,has-ecc:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description: CAN TX_OL, TX_TL and RX FIFOs have ECC support(AXI CAN)
> +
> required:
> - compatible
> - reg
> @@ -137,6 +141,7 @@ examples:
> interrupts = <GIC_SPI 59 IRQ_TYPE_EDGE_RISING>;
> tx-fifo-depth = <0x40>;
> rx-fifo-depth = <0x40>;
> + xlnx,has-ecc;
> };
>
> - |
> --
> 2.1.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-11-19 13:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 9:28 [PATCH v5 0/3] can: xilinx_can: Add ECC feature support Srinivas Goud
2023-11-17 9:28 ` [PATCH v5 1/3] dt-bindings: can: xilinx_can: Add 'xlnx,has-ecc' optional property Srinivas Goud
2023-11-19 13:37 ` Conor Dooley [this message]
2023-11-17 9:28 ` [PATCH v5 2/3] can: xilinx_can: Add ECC support Srinivas Goud
2023-11-17 9:28 ` [PATCH v5 3/3] can: xilinx_can: Add ethtool stats interface for ECC errors Srinivas Goud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231119-dotted-feast-eb01cbebde42@spud \
--to=conor@kernel.org \
--cc=appana.durga.rao@xilinx.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=git@amd.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=mkl@pengutronix.de \
--cc=naga.sureshkumar.relli@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.goud@amd.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).