From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Eric Dumazet" <edumazet@google.com>,
netdev@vger.kernel.org, linux-can@vger.kernel.org,
"Jérémie Dautheribes" <jeremie.dautheribes@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
sylvain.girard@se.com, pascal.eberhard@se.com,
"Miquel Raynal" <miquel.raynal@bootlin.com>
Subject: [PATCH net-next] can: sja1000: Fix comment
Date: Fri, 22 Sep 2023 17:51:30 +0200 [thread overview]
Message-ID: <20230922155130.592187-1-miquel.raynal@bootlin.com> (raw)
There is likely a copy-paste error here, as the exact same comment
appears below in this function, one time calling set_reset_mode(), the
other set_normal_mode().
Fixes: 429da1cc841b ("can: Driver for the SJA1000 CAN controller")
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
drivers/net/can/sja1000/sja1000.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/sja1000/sja1000.c b/drivers/net/can/sja1000/sja1000.c
index 158a17c9d46b..ae47fc72aa96 100644
--- a/drivers/net/can/sja1000/sja1000.c
+++ b/drivers/net/can/sja1000/sja1000.c
@@ -207,7 +207,7 @@ static void sja1000_start(struct net_device *dev)
{
struct sja1000_priv *priv = netdev_priv(dev);
- /* leave reset mode */
+ /* enter reset mode */
if (priv->can.state != CAN_STATE_STOPPED)
set_reset_mode(dev);
--
2.34.1
next reply other threads:[~2023-09-22 15:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 15:51 Miquel Raynal [this message]
2023-09-28 12:35 ` [PATCH net-next] can: sja1000: Fix comment Simon Horman
2023-10-01 17:13 ` Miquel Raynal
2023-10-04 10:14 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230922155130.592187-1-miquel.raynal@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jeremie.dautheribes@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pascal.eberhard@se.com \
--cc=sylvain.girard@se.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).