From: Markus Schneider-Pargmann <msp@baylibre.com>
To: Sean Anderson <sean.anderson@seco.com>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Conor Dooley <conor+dt@kernel.org>,
Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
Michal Kubiak <michal.kubiak@intel.com>,
Vivek Yadav <vivek.2311@samsung.com>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Simon Horman <simon.horman@corigine.com>
Subject: Re: [PATCH v3 5/6] can: tcan4x5x: Add support for tcan4552/4553
Date: Tue, 19 Sep 2023 09:51:35 +0200 [thread overview]
Message-ID: <20230919075135.7xim2yjwt5jna4sy@blmsp> (raw)
In-Reply-To: <a94e6fc8-4f08-7877-2ba0-29b9c2780136@seco.com>
Hi Sean,
On Fri, Sep 15, 2023 at 11:36:49AM -0400, Sean Anderson wrote:
> On 7/21/23 09:50, Markus Schneider-Pargmann wrote:
> > +static const struct tcan4x5x_version_info tcan4x5x_versions[] = {
> > + [TCAN4552] = {
> > + .name = "4552",
> > + .id2_register = 0x32353534,
> > + },
> > + [TCAN4553] = {
> > + .name = "4553",
> > + .id2_register = 0x32353534,
>
> Should this be 0x33353534?
Thank you for noticing! Yes. Probably slipped through in the last
refactoring. I will send a fix.
Best,
Markus
next prev parent reply other threads:[~2023-09-19 7:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 13:50 [PATCH v3 0/6] can: tcan4x5x: Introduce tcan4552/4553 Markus Schneider-Pargmann
2023-07-21 13:50 ` [PATCH v3 1/6] dt-bindings: can: tcan4x5x: Add tcan4552 and tcan4553 variants Markus Schneider-Pargmann
2023-07-21 13:50 ` [PATCH v3 2/6] can: tcan4x5x: Remove reserved register 0x814 from writable table Markus Schneider-Pargmann
2023-07-21 13:50 ` [PATCH v3 3/6] can: tcan4x5x: Check size of mram configuration Markus Schneider-Pargmann
2023-07-21 13:50 ` [PATCH v3 4/6] can: tcan4x5x: Rename ID registers to match datasheet Markus Schneider-Pargmann
2023-07-21 13:50 ` [PATCH v3 5/6] can: tcan4x5x: Add support for tcan4552/4553 Markus Schneider-Pargmann
2023-09-15 15:36 ` Sean Anderson
2023-09-19 7:51 ` Markus Schneider-Pargmann [this message]
2023-07-21 13:50 ` [PATCH v3 6/6] can: tcan4x5x: Add error messages in probe Markus Schneider-Pargmann
2023-07-24 8:37 ` Marc Kleine-Budde
2023-07-24 9:06 ` Markus Schneider-Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230919075135.7xim2yjwt5jna4sy@blmsp \
--to=msp@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.kubiak@intel.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rcsekar@samsung.com \
--cc=robh+dt@kernel.org \
--cc=sean.anderson@seco.com \
--cc=simon.horman@corigine.com \
--cc=vivek.2311@samsung.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).