From: Markus Schneider-Pargmann <msp@baylibre.com>
To: "Martin Hundebøll" <martin@geanix.com>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
Wolfgang Grandegger <wg@grandegger.com>,
Vincent MAILHOL <mailhol.vincent@wanadoo.fr>,
Simon Horman <simon.horman@corigine.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Julien Panis <jpanis@baylibre.com>
Subject: Re: [PATCH v5 00/12] can: m_can: Optimizations for m_can/tcan part 2
Date: Mon, 4 Sep 2023 11:34:42 +0200 [thread overview]
Message-ID: <20230904093442.cu6d5b6gm5ngfli6@blmsp> (raw)
In-Reply-To: <108a41e492dcfa4a7c59e44aac7dfb502e595962.camel@geanix.com>
On Wed, Aug 23, 2023 at 08:51:48AM +0200, Martin Hundebøll wrote:
> On Tue, 2023-07-18 at 09:56 +0200, Markus Schneider-Pargmann wrote:
> > Hi Marc, Simon and everyone,
> >
> > v5 got a rebase on v6.5 with some small style fixes as pointed out in
> > v4.
> >
> > It is tested on tcan455x but I don't have hardware with mcan on the
> > SoC
> > myself so any testing is appreciated.
> >
> > The series implements many small and bigger throughput improvements
> > and
> > adds rx/tx coalescing at the end.
> >
> > Based on v6.5-rc1. Also available at
> > https://gitlab.baylibre.com/msp8/linux/-/tree/topic/mcan-optimization/v6.5?ref_type=heads
>
> For the whole series:
> Tested-by: Martin Hundebøll <martin@geanix.com>
Thank you Martin!
Best,
Markus
>
> Thanks,
> Martin
>
> > Changes in v5:
> > - Add back parenthesis in m_can_set_coalesce(). This will make
> > checkpatch unhappy but gcc happy.
> > - Remove unused fifo_header variable in m_can_tx_handler().
> > - Rebased to v6.5-rc1
> >
> > Changes in v4:
> > - Create and use struct m_can_fifo_element in m_can_tx_handler
> > - Fix memcpy_and_pad to copy the full buffer
> > - Fixed a few checkpatch warnings
> > - Change putidx to be unsigned
> > - Print hard_xmit error only once when TX FIFO is full
> >
> > Changes in v3:
> > - Remove parenthesis in error messages
> > - Use memcpy_and_pad for buffer copy in 'can: m_can: Write transmit
> > header and data in one transaction'.
> > - Replace spin_lock with spin_lock_irqsave. I got a report of a
> > interrupt that was calling start_xmit just after the netqueue was
> > woken up before the locked region was exited. spin_lock_irqsave
> > should
> > fix this. I attached the full stack at the end of the mail if
> > someone
> > wants to know.
> > - Rebased to v6.3-rc1.
> > - Removed tcan4x5x patches from this series.
> >
> > Changes in v2:
> > - Rebased on v6.2-rc5
> > - Fixed missing/broken accounting for non peripheral m_can devices.
> >
> > previous versions:
> > v1 -
> > https://lore.kernel.org/lkml/20221221152537.751564-1-msp@baylibre.com
> > v2 -
> > https://lore.kernel.org/lkml/20230125195059.630377-1-msp@baylibre.com
> > v3 -
> > https://lore.kernel.org/lkml/20230315110546.2518305-1-msp@baylibre.com/
> > v4 -
> > https://lore.kernel.org/lkml/20230621092350.3130866-1-msp@baylibre.com/
> >
> > Markus Schneider-Pargmann (12):
> > can: m_can: Write transmit header and data in one transaction
> > can: m_can: Implement receive coalescing
> > can: m_can: Implement transmit coalescing
> > can: m_can: Add rx coalescing ethtool support
> > can: m_can: Add tx coalescing ethtool support
> > can: m_can: Use u32 for putidx
> > can: m_can: Cache tx putidx
> > can: m_can: Use the workqueue as queue
> > can: m_can: Introduce a tx_fifo_in_flight counter
> > can: m_can: Use tx_fifo_in_flight for netif_queue control
> > can: m_can: Implement BQL
> > can: m_can: Implement transmit submission coalescing
> >
> > drivers/net/can/m_can/m_can.c | 517 +++++++++++++++++++++++++-------
> > --
> > drivers/net/can/m_can/m_can.h | 35 ++-
> > 2 files changed, 418 insertions(+), 134 deletions(-)
> >
> >
> > base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5
>
prev parent reply other threads:[~2023-09-04 9:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 7:56 [PATCH v5 00/12] can: m_can: Optimizations for m_can/tcan part 2 Markus Schneider-Pargmann
2023-07-18 7:56 ` [PATCH v5 01/12] can: m_can: Write transmit header and data in one transaction Markus Schneider-Pargmann
2023-07-20 15:44 ` Simon Horman
2023-07-18 7:56 ` [PATCH v5 02/12] can: m_can: Implement receive coalescing Markus Schneider-Pargmann
2023-07-18 7:56 ` [PATCH v5 03/12] can: m_can: Implement transmit coalescing Markus Schneider-Pargmann
2023-07-18 7:57 ` [PATCH v5 04/12] can: m_can: Add rx coalescing ethtool support Markus Schneider-Pargmann
2023-07-18 7:57 ` [PATCH v5 05/12] can: m_can: Add tx " Markus Schneider-Pargmann
2023-07-18 7:57 ` [PATCH v5 06/12] can: m_can: Use u32 for putidx Markus Schneider-Pargmann
2023-07-20 15:47 ` Simon Horman
2023-07-18 7:57 ` [PATCH v5 07/12] can: m_can: Cache tx putidx Markus Schneider-Pargmann
2023-07-18 7:57 ` [PATCH v5 08/12] can: m_can: Use the workqueue as queue Markus Schneider-Pargmann
2023-07-18 7:57 ` [PATCH v5 09/12] can: m_can: Introduce a tx_fifo_in_flight counter Markus Schneider-Pargmann
2023-07-18 7:57 ` [PATCH v5 10/12] can: m_can: Use tx_fifo_in_flight for netif_queue control Markus Schneider-Pargmann
2023-07-20 15:53 ` Simon Horman
2023-07-18 7:57 ` [PATCH v5 11/12] can: m_can: Implement BQL Markus Schneider-Pargmann
2023-07-18 7:57 ` [PATCH v5 12/12] can: m_can: Implement transmit submission coalescing Markus Schneider-Pargmann
2023-07-20 15:58 ` Simon Horman
2023-07-21 13:37 ` Markus Schneider-Pargmann
2023-08-10 9:32 ` [PATCH v5 00/12] can: m_can: Optimizations for m_can/tcan part 2 Markus Schneider-Pargmann
2023-08-23 6:51 ` Martin Hundebøll
2023-09-04 9:34 ` Markus Schneider-Pargmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230904093442.cu6d5b6gm5ngfli6@blmsp \
--to=msp@baylibre.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jpanis@baylibre.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=martin@geanix.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rcsekar@samsung.com \
--cc=simon.horman@corigine.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).