From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Guy Harris <gharris@sonic.net>
Cc: Developer support list for Wireshark
<wireshark-dev@wireshark.org>,
linux-can@vger.kernel.org
Subject: Re: [Wireshark-dev] SocketCAN Support is broken in latest Wireshark-v4.3.0rc0-1430-g600de02805d0
Date: Tue, 13 Feb 2024 10:37:42 +0100 [thread overview]
Message-ID: <05ae1eca-4bb6-40e4-88fc-791cc2051da8@hartkopp.net> (raw)
In-Reply-To: <23C4EECD-622A-412A-B965-8E586D9360B2@sonic.net>
Hello Guy,
On 2024-02-13 01:28, Guy Harris wrote:
> On Feb 12, 2024, at 1:15 PM, Oliver Hartkopp <socketcan@hartkopp.net> wrote:
>
>> Excellent! That seems to be the right approach.
>
> OK, so:
>
> fix libpcap to put the priority/VCID field in big-endian order in CAN XL frames:
>
> https://github.com/the-tcpdump-group/libpcap/commit/eb6cfd8feae85b67529bb3c82f6a97bfd98c73f3 in the main branch
>
> https://github.com/the-tcpdump-group/libpcap/commit/23904ebe85c4556b77578fd8d61ef82d9bab62b4 in the 1.10 branch
>
> change Wireshark to treat that field as big-endian:
>
> https://gitlab.com/wireshark/wireshark/-/commit/38a29e82cc96f727aeab7f10e751fa6e8d5e45b6 in the main branch
>
> https://gitlab.com/wireshark/wireshark/-/commit/b763663904b6101764c414056b9248803569d6d2 in the 4.2 branch
>
> update the LINKTYPE_CAN_SOCKETCAN spec to reflect all that:
>
> https://github.com/the-tcpdump-group/tcpdump-htdocs/commit/9c357d9ed6d214bd2fc44850138c2f8861782d88
>
> and it'll show up on the site within 24 hours.
>
I can confirm that all type of CAN frames (CAN CC/FD/XL) are now
displayed correctly with the latest Wireshark
v4.3.0rc0-1528-g37937ef51444. As expected I just don't see the CAN FD
flags due to my current (outdated) Debian libpcap 1.10.4.
Great job!!
Many thanks and best regards,
Oliver
next parent reply other threads:[~2024-02-13 9:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2dfbf765-5a0e-4b72-bbbb-2649bba7afd8@hartkopp.net>
[not found] ` <B237C266-B7A1-4F5A-85FA-F41FBC71D839@sonic.net>
[not found] ` <DDFFD43D-2CC3-482A-AFC0-B0EEDE5B7081@sonic.net>
[not found] ` <9C5FF793-DD38-4738-9421-C8C411E405D2@sonic.net>
[not found] ` <525f7e66-1b8a-4401-b6a5-c55462f12f4a@hartkopp.net>
[not found] ` <2CB7E192-7F5B-4651-B0B1-9C3788489B8C@sonic.net>
[not found] ` <550c630a-4fba-430e-a0b6-bacce3776f2f@hartkopp.net>
[not found] ` <B9FE825B-F804-4D09-BE01-1D5592D1077D@sonic.net>
[not found] ` <48514D53-9257-4613-9F10-09086D93C2A3@sonic.net>
[not found] ` <68889df4-1ac5-45c0-8820-737cbcc30c56@hartkopp.net>
[not found] ` <40ADC6AD-C4C3-4954-B58C-FCD227474C16@sonic.net>
[not found] ` <48b90be5-7dc8-46f5-a2fb-bc9b310da410@hartkopp.net>
[not found] ` <5D9B69B1-A6D2-429B-8862-5CB60415D7C0@sonic.net>
[not found] ` <aa3671e7-83ed-45ed-a843-d9ed238519c6@hartkopp.net>
[not found] ` <23C4EECD-622A-412A-B965-8E586D9360B2@sonic.net>
2024-02-13 9:37 ` Oliver Hartkopp [this message]
2024-02-15 0:03 ` [Wireshark-dev] SocketCAN Support is broken in latest Wireshark-v4.3.0rc0-1430-g600de02805d0 Guy Harris
2024-02-15 8:01 ` Oliver Hartkopp
2024-02-15 10:43 ` Guy Harris
2024-02-15 12:20 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05ae1eca-4bb6-40e4-88fc-791cc2051da8@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=gharris@sonic.net \
--cc=linux-can@vger.kernel.org \
--cc=wireshark-dev@wireshark.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).