Linux-BTRFS Archive mirror
 help / color / mirror / Atom feed
From: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To: Naohiro Aota <Naohiro.Aota@wdc.com>, Johannes Thumshirn <jth@kernel.org>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
	David Sterba <dsterba@suse.com>,
	Hans Holmberg <Hans.Holmberg@wdc.com>,
	"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] btrfs: reserve new relocation zone after successful relocation
Date: Wed, 15 May 2024 18:21:58 +0000	[thread overview]
Message-ID: <fcd82dba-4a6d-40c6-b960-096a4f7690c2@wdc.com> (raw)
In-Reply-To: <ntbfehck4zi2vns3773bo7f5mlxclka36fwfphkzdnbz3k37nc@ojamkclv2w4n>

On 15.05.24 12:01, Naohiro Aota wrote:
>> +
>> +	/* We know we have just freed space, set it as hint for the next relocation */
>> +	btrfs_reserve_relocation_zone(fs_info);
> 
> With "if (!err)"? We definitely bail out fast in an error case.
> 

Right, I'll fix it in the next version.


      reply	other threads:[~2024-05-15 18:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-14 21:13 [PATCH 0/2] btrfs: zoned: always set aside a zone for relocation Johannes Thumshirn
2024-05-14 21:13 ` [PATCH 1/2] btrfs: zoned: reserve relocation zone on mount Johannes Thumshirn
2024-05-15 17:58   ` Naohiro Aota
2024-05-14 21:13 ` [PATCH 2/2] btrfs: reserve new relocation zone after successful relocation Johannes Thumshirn
2024-05-15 18:01   ` Naohiro Aota
2024-05-15 18:21     ` Johannes Thumshirn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fcd82dba-4a6d-40c6-b960-096a4f7690c2@wdc.com \
    --to=johannes.thumshirn@wdc.com \
    --cc=Hans.Holmberg@wdc.com \
    --cc=Naohiro.Aota@wdc.com \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=josef@toxicpanda.com \
    --cc=jth@kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).