From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Cc: Anand Jain <anand.jain@oracle.com>
Subject: [PATCH 00/29] trivial adjustments for return variable coding style
Date: Tue, 19 Mar 2024 20:25:08 +0530 [thread overview]
Message-ID: <cover.1710857863.git.anand.jain@oracle.com> (raw)
Rename variable 'err'; instead, use 'ret', and the 'ret' helper variable
is renamed to 'ret2'.
https://btrfs.readthedocs.io/en/latest/dev/Development-notes.html#code
In functions where 'ret' is already used as a return helper (but not the
actual return), to avoid oversight, first rename the original 'ret'
variable to 'ret2', compile it, and then rename 'err' to 'ret'.
Anand Jain (29):
btrfs: btrfs_cleanup_fs_roots rename ret to ret2 and err to ret
btrfs: btrfs_initxattrs rename err to ret
btrfs: send_extent_data rename err to ret
btrfs: btrfs_rmdir rename err to ret
btrfs: btrfs_cont_expand rename err to ret
btrfs: btrfs_setsize rename err to ret2
btrfs: btrfs_find_orphan_roots rename ret to ret2 and err to ret
btrfs: btrfs_ioctl_snap_destroy rename err to ret
btrfs: __set_extent_bit rename err to ret
btrfs: convert_extent_bit rename err to ret
btrfs: __btrfs_end_transaction rename err to ret
btrfs: btrfs_write_marked_extents rename werr to ret err to ret2
btrfs: __btrfs_wait_marked_extents rename werr to ret err to ret2
btrfs: build_backref_tree rename err to ret and ret to ret2
btrfs: relocate_tree_blocks rename ret to ret2 and err to ret
btrfs: relocate_block_group rename ret to ret2 and err to ret
btrfs: create_reloc_inode rename err to ret
btrfs: btrfs_relocate_block_group rename ret to ret2 and err ro ret
btrfs: mark_garbage_root rename err to ret2
btrfs: btrfs_recover_relocation rename ret to ret2 and err to ret
btrfs: quick_update_accounting rename err to ret2
btrfs: btrfs_qgroup_rescan_worker rename ret to ret2 and err to ret
btrfs: lookup_extent_data_ref rename ret to ret2 and err to ret
btrfs: btrfs_drop_snapshot rename ret to ret2 and err to ret
btrfs: btrfs_drop_subtree rename retw to ret2
btrfs: btrfs_dirty_pages rename variable err to ret
btrfs: prepare_pages rename err to ret
btrfs: btrfs_direct_write rename err to ret
btrfs: fixup_tree_root_location rename ret to ret2 and err to ret
fs/btrfs/disk-io.c | 22 +--
fs/btrfs/extent-io-tree.c | 58 ++++----
fs/btrfs/extent-tree.c | 122 ++++++++---------
fs/btrfs/file.c | 80 +++++------
fs/btrfs/inode.c | 88 ++++++------
fs/btrfs/ioctl.c | 66 ++++-----
fs/btrfs/qgroup.c | 44 +++---
fs/btrfs/relocation.c | 280 +++++++++++++++++++-------------------
fs/btrfs/root-tree.c | 36 ++---
fs/btrfs/send.c | 4 +-
fs/btrfs/transaction.c | 56 ++++----
fs/btrfs/xattr.c | 10 +-
12 files changed, 434 insertions(+), 432 deletions(-)
--
2.38.1
next reply other threads:[~2024-03-19 14:56 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 14:55 Anand Jain [this message]
2024-03-19 14:55 ` [PATCH 01/29] btrfs: btrfs_cleanup_fs_roots rename ret to ret2 and err to ret Anand Jain
2024-03-19 17:38 ` Josef Bacik
2024-03-19 20:43 ` Qu Wenruo
2024-04-17 3:24 ` Anand Jain
2024-04-17 3:59 ` Qu Wenruo
2024-03-20 21:17 ` Goffredo Baroncelli
2024-03-19 14:55 ` [PATCH 02/29] btrfs: btrfs_initxattrs rename " Anand Jain
2024-03-19 14:55 ` [PATCH 03/29] btrfs: send_extent_data " Anand Jain
2024-03-20 12:59 ` Filipe Manana
2024-03-19 14:55 ` [PATCH 04/29] btrfs: btrfs_rmdir " Anand Jain
2024-03-19 14:55 ` [PATCH 05/29] btrfs: btrfs_cont_expand " Anand Jain
2024-03-19 14:55 ` [PATCH 06/29] btrfs: btrfs_setsize rename err to ret2 Anand Jain
2024-03-19 14:55 ` [PATCH 07/29] btrfs: btrfs_find_orphan_roots rename ret to ret2 and err to ret Anand Jain
2024-03-19 17:44 ` Josef Bacik
2024-03-19 21:09 ` Qu Wenruo
2024-03-19 14:55 ` [PATCH 08/29] btrfs: btrfs_ioctl_snap_destroy rename " Anand Jain
2024-03-19 14:55 ` [PATCH 09/29] btrfs: __set_extent_bit " Anand Jain
2024-03-19 14:55 ` [PATCH 10/29] btrfs: convert_extent_bit " Anand Jain
2024-03-19 14:55 ` [PATCH 11/29] btrfs: __btrfs_end_transaction " Anand Jain
2024-03-19 14:55 ` [PATCH 12/29] btrfs: btrfs_write_marked_extents rename werr to ret err to ret2 Anand Jain
2024-03-19 17:53 ` Josef Bacik
2024-04-16 2:39 ` Anand Jain
2024-03-19 21:25 ` Qu Wenruo
2024-04-16 3:18 ` Anand Jain
2024-03-19 14:55 ` [PATCH 13/29] btrfs: __btrfs_wait_marked_extents " Anand Jain
2024-03-19 17:54 ` Josef Bacik
2024-03-19 23:47 ` Qu Wenruo
2024-03-19 14:55 ` [PATCH 14/29] btrfs: build_backref_tree rename err to ret and ret " Anand Jain
2024-03-19 17:57 ` Josef Bacik
2024-03-19 14:55 ` [PATCH 15/29] btrfs: relocate_tree_blocks rename ret to ret2 and err to ret Anand Jain
2024-03-19 17:58 ` Josef Bacik
2024-03-19 14:55 ` [PATCH 16/29] btrfs: relocate_block_group " Anand Jain
2024-03-19 14:55 ` [PATCH 17/29] btrfs: create_reloc_inode rename " Anand Jain
2024-03-19 14:55 ` [PATCH 18/29] btrfs: btrfs_relocate_block_group rename ret to ret2 and err ro ret Anand Jain
2024-03-19 18:04 ` Josef Bacik
2024-03-19 14:55 ` [PATCH 19/29] btrfs: mark_garbage_root rename err to ret2 Anand Jain
2024-03-19 18:07 ` Josef Bacik
2024-03-22 2:29 ` David Sterba
2024-03-19 14:55 ` [PATCH 20/29] btrfs: btrfs_recover_relocation rename ret to ret2 and err to ret Anand Jain
2024-03-19 14:55 ` [PATCH 21/29] btrfs: quick_update_accounting rename err to ret2 Anand Jain
2024-03-19 18:10 ` Josef Bacik
2024-03-19 14:55 ` [PATCH 22/29] btrfs: btrfs_qgroup_rescan_worker rename ret to ret2 and err to ret Anand Jain
2024-03-19 14:55 ` [PATCH 23/29] btrfs: lookup_extent_data_ref " Anand Jain
2024-03-19 18:17 ` Josef Bacik
2024-04-18 6:55 ` Anand Jain
2024-03-19 14:55 ` [PATCH 24/29] btrfs: btrfs_drop_snapshot " Anand Jain
2024-03-19 18:20 ` Josef Bacik
2024-03-19 14:55 ` [PATCH 25/29] btrfs: btrfs_drop_subtree rename retw to ret2 Anand Jain
2024-03-19 18:22 ` Josef Bacik
2024-03-19 14:55 ` [PATCH 26/29] btrfs: btrfs_dirty_pages rename variable err to ret Anand Jain
2024-03-19 14:55 ` [PATCH 27/29] btrfs: prepare_pages rename " Anand Jain
2024-03-19 14:55 ` [PATCH 28/29] btrfs: btrfs_direct_write " Anand Jain
2024-03-19 14:55 ` [PATCH 29/29] btrfs: fixup_tree_root_location rename ret to ret2 and " Anand Jain
2024-03-19 18:24 ` Josef Bacik
2024-04-16 10:42 ` Anand Jain
2024-04-16 10:44 ` Anand Jain
2024-03-22 2:32 ` [PATCH 00/29] trivial adjustments for return variable coding style David Sterba
2024-03-25 9:37 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1710857863.git.anand.jain@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).