From: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
To: linux-btrfs@vger.kernel.org
Cc: Qu Wenruo <wqu@suse.com>, David Sterba <dsterba@suse.cz>,
"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
Subject: [RFC] btrfs: Remove the experimental warning for sectorsize < pagesize
Date: Mon, 1 Apr 2024 14:53:46 +0530 [thread overview]
Message-ID: <cc79c6ab354931b61a2dbd3900e253877b78913f.1711959592.git.ritesh.list@gmail.com> (raw)
Support for sector size < pagesize in btrfs was added a while back
and btrfsprogs has been defaulted to 4k sector size by default.
This also means that btrfs has stabilized sectorsize < pagesize path,
so let's remove the experimental warning and make it a info message.
Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
---
So, I see portability was one of the main reason for the switching default
sectorsize to 4k [1] and also sectorsize < pagesize is considered to be stable
enough for the switch.
Given, that btrfsprogs v6.7 has already defaulted to 4k sectorsize, can we get
rid of this "experimental" warning msg causing confusion among people of
whether their data is at risk?
Or do we still consider this experimental and in what way?
Also do we have any unsupported btrfs features remaining with,
sectorsize < pagesize ?
[1]: https://lore.kernel.org/linux-btrfs/20231116160235.2708131-1-neal@gompa.dev/
fs/btrfs/disk-io.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index bececdd63b4d..e4eff84e1d83 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -3350,8 +3350,8 @@ int __cold open_ctree(struct super_block *sb, struct btrfs_fs_devices *fs_device
if (sectorsize < PAGE_SIZE) {
struct btrfs_subpage_info *subpage_info;
- btrfs_warn(fs_info,
- "read-write for sector size %u with page size %lu is experimental",
+ btrfs_info(fs_info,
+ "read-write for sector size %u with page size %lu is being utilized",
sectorsize, PAGE_SIZE);
subpage_info = kzalloc(sizeof(*subpage_info), GFP_KERNEL);
if (!subpage_info) {
--
2.39.2
next reply other threads:[~2024-04-01 9:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 9:23 Ritesh Harjani (IBM) [this message]
2024-04-01 9:33 ` [RFC] btrfs: Remove the experimental warning for sectorsize < pagesize Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc79c6ab354931b61a2dbd3900e253877b78913f.1711959592.git.ritesh.list@gmail.com \
--to=ritesh.list@gmail.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).