From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Yordan <y16267966@gmail.com>, linux-btrfs@vger.kernel.org
Subject: Re: btrfs-convert on 24Gb image corrupts files.
Date: Mon, 6 May 2024 08:01:01 +0930 [thread overview]
Message-ID: <ac0c71a9-683c-4d0b-a60f-d6cdf975838d@gmx.com> (raw)
In-Reply-To: <CAE0VrXL99p1ra6aRyqZgEbHKJ2LBKU0Yn+sPd4WoHxq0pONjGg@mail.gmail.com>
在 2024/5/6 00:35, Yordan 写道:
> Hi, it's Jordan - the reporter, I'm switching the email server as the
> first one presumably did dirty things and was rejected by the "mlmmj
> program managing the mailing list".
>
>> Mind to provide the "filefrag -v" output after conversion using Anand's
> fixes?
>
>> Mind to provide the "filefrag -v" output after conversion using Anand's
>
> fixes?
>
> After applying the 4 patches and compiling:
>
[...]
> (chroot) livecd /k # filefrag -v
> ./root/.mozilla/firefox/s554srh9.default-release/storage/permanent/chrome/idb/3561288849sdhlie.sqlite
> Filesystem type is: 9123683e
> File size of ./root/.mozilla/firefox/s554srh9.default-release/storage/permanent/chrome/idb/3561288849sdhlie.sqlite
> is 49152 (12 blocks of 4096 bytes)
> ext: logical_offset: physical_offset: length: expected: flags:
> 0: 0.. 1: 2217003.. 2217004: 2: shared
> 1: 2.. 11: 2217019.. 2217028: 10: 2217005: last,shared,eof
OK, that's the problem, compared to the older values from ext4:
> 0: 0.. 1: 2217003.. 2217004: 2:
> 1: 2.. 10: 2217019.. 2217027: 9: 2217005:
> 2: 11.. 11: 2217028.. 2217028: 1: last,unwritten,eof
The last extent of btrfs still doesn't properly have the preallocated
flag, thus we read the garbage instead of filling it with 0.
I'll give more comprehensive review on Anand's fix.
And for the worst case I can change btrfs-convert to create a hole to
properly fix it.
Thanks for the detailed report!
Qu
next prev parent reply other threads:[~2024-05-05 22:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-05 15:05 btrfs-convert on 24Gb image corrupts files Yordan
2024-05-05 22:31 ` Qu Wenruo [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-05-05 22:30 You can reproduce it yourself now Yordan
2024-05-06 10:53 ` btrfs-convert on 24Gb image corrupts files Yordan
2024-05-06 13:17 ` Anand Jain
2024-05-06 13:35 ` Yordan
2024-05-06 13:43 ` Anand Jain
2024-05-06 14:57 ` Yordan
2024-05-05 0:34 jordan.j
2024-05-05 0:50 ` Qu Wenruo
2024-05-05 0:56 ` Anand Jain
2024-05-05 5:54 ` Qu Wenruo
2024-05-06 0:33 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac0c71a9-683c-4d0b-a60f-d6cdf975838d@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=y16267966@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).