From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: fdmanana@kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 2/2] btrfs: make btrfs_finish_ordered_extent() return void
Date: Thu, 16 May 2024 07:33:17 +0930 [thread overview]
Message-ID: <3ee930a1-6aa3-481e-ae4c-80bcbf88d197@gmx.com> (raw)
In-Reply-To: <0fc7eb82d2d89b607d663de4fadc031c54aab002.1715798440.git.fdmanana@suse.com>
在 2024/5/16 04:21, fdmanana@kernel.org 写道:
> From: Filipe Manana <fdmanana@suse.com>
>
> Currently btrfs_finish_ordered_extent() returns a boolean indicating if
> the ordered extent was added to the work queue for completion, but none
> of its callers cares about it, so make it return void.
>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Thanks,
Qu
> ---
> fs/btrfs/ordered-data.c | 3 +--
> fs/btrfs/ordered-data.h | 2 +-
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/fs/btrfs/ordered-data.c b/fs/btrfs/ordered-data.c
> index 3a3f21da6eb7..3766804decb8 100644
> --- a/fs/btrfs/ordered-data.c
> +++ b/fs/btrfs/ordered-data.c
> @@ -374,7 +374,7 @@ static void btrfs_queue_ordered_fn(struct btrfs_ordered_extent *ordered)
> btrfs_queue_work(wq, &ordered->work);
> }
>
> -bool btrfs_finish_ordered_extent(struct btrfs_ordered_extent *ordered,
> +void btrfs_finish_ordered_extent(struct btrfs_ordered_extent *ordered,
> struct page *page, u64 file_offset, u64 len,
> bool uptodate)
> {
> @@ -417,7 +417,6 @@ bool btrfs_finish_ordered_extent(struct btrfs_ordered_extent *ordered,
>
> if (ret)
> btrfs_queue_ordered_fn(ordered);
> - return ret;
> }
>
> /*
> diff --git a/fs/btrfs/ordered-data.h b/fs/btrfs/ordered-data.h
> index b6f6c6b91732..bef22179e7c5 100644
> --- a/fs/btrfs/ordered-data.h
> +++ b/fs/btrfs/ordered-data.h
> @@ -162,7 +162,7 @@ int btrfs_finish_ordered_io(struct btrfs_ordered_extent *ordered_extent);
> void btrfs_put_ordered_extent(struct btrfs_ordered_extent *entry);
> void btrfs_remove_ordered_extent(struct btrfs_inode *btrfs_inode,
> struct btrfs_ordered_extent *entry);
> -bool btrfs_finish_ordered_extent(struct btrfs_ordered_extent *ordered,
> +void btrfs_finish_ordered_extent(struct btrfs_ordered_extent *ordered,
> struct page *page, u64 file_offset, u64 len,
> bool uptodate);
> void btrfs_mark_ordered_io_finished(struct btrfs_inode *inode,
next prev parent reply other threads:[~2024-05-15 22:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 14:23 [PATCH 0/2] btrfs: fix a bug in the direct IO write path for COW writes fdmanana
2024-05-14 14:23 ` [PATCH 1/2] btrfs: drop extent maps after failed COW dio write fdmanana
2024-05-14 22:15 ` Qu Wenruo
2024-05-15 9:47 ` Filipe Manana
2024-05-14 14:23 ` [PATCH 2/2] btrfs: refactor btrfs_dio_submit_io() for less nesting and indentation fdmanana
2024-05-14 22:23 ` Qu Wenruo
2024-05-15 18:51 ` [PATCH v2 0/2] btrfs: fix a bug in the direct IO write path for COW writes fdmanana
2024-05-15 18:51 ` [PATCH v2 1/2] btrfs: immediately drop extent maps after failed COW write fdmanana
2024-05-15 22:02 ` Qu Wenruo
2024-05-15 18:51 ` [PATCH v2 2/2] btrfs: make btrfs_finish_ordered_extent() return void fdmanana
2024-05-15 22:03 ` Qu Wenruo [this message]
2024-05-17 16:28 ` [PATCH v2 0/2] btrfs: fix a bug in the direct IO write path for COW writes David Sterba
2024-05-17 16:54 ` Filipe Manana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ee930a1-6aa3-481e-ae4c-80bcbf88d197@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).