From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] btrfs-progs: dump-tree: support simple quota mode status flags
Date: Fri, 10 May 2024 15:21:17 +0200 [thread overview]
Message-ID: <20240510132116.GS13977@twin.jikos.cz> (raw)
In-Reply-To: <4c86accc806fc1a53bdb198168458ca90c288ce4.1715217526.git.wqu@suse.com>
On Thu, May 09, 2024 at 10:49:03AM +0930, Qu Wenruo wrote:
> [BUG]
> For simple quota mode btrfs, dump tree does not show the extra flags
> correctly:
>
> # mkfs.btrfs -f -O squota $dev
> # btrfs ins dump-tree -t quota $dev | grep QGROUP_STATUS -A1
> item 0 key (0 QGROUP_STATUS 0) itemoff 16243 itemsize 40
> version 1 generation 10 flags ON scan 0 enable_gen 7
>
> Note just ON is shown, but squota has one extra bit set for it.
>
> [CAUSE]
> Just no support for the new flag.
>
> [FIX]
> Add the new flag support, also to be consistent with other flags string
> output, add output for extra unknown flags.
>
> With a hand crafted image, the output with unknown flags looks like
> this:
> item 0 key (0 QGROUP_STATUS 0) itemoff 16243 itemsize 40
> version 1 generation 10 flags ON|SIMPLE_MODE|UNKNOWN(0xf00) scan 0 enable_gen 7
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
Added to devel, thanks.
prev parent reply other threads:[~2024-05-10 13:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 1:19 [PATCH v2] btrfs-progs: dump-tree: support simple quota mode status flags Qu Wenruo
2024-05-10 13:21 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240510132116.GS13977@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).