From: David Sterba <dsterba@suse.cz>
To: fdmanana@kernel.org
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: move btrfs_page_mkwrite() from inode.c into file.c
Date: Wed, 10 Apr 2024 14:52:20 +0200 [thread overview]
Message-ID: <20240410125220.GM3492@twin.jikos.cz> (raw)
In-Reply-To: <b7d1ee7e696e2ed290e3de640102073dcb0334bb.1712749432.git.fdmanana@suse.com>
On Wed, Apr 10, 2024 at 12:45:29PM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> btrfs_page_mkwrite() is a struct vm_operations_struct callback and we
> define that structure in file.c. Currently the function is in inode.c and
> has to be exported to be used in file.c, which makes no sense because it's
> not used anywhere else. So move btrfs_page_mkwrite() from inode.c and into
> file.c.
>
> While at it do a few minor style changes:
>
> 1) Capitalize the first word of every comment and end each sentence with
> punctuation;
>
> 2) Avoid splitting some statements into two lines when everything fits in
> 85 characters or less.
>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
prev parent reply other threads:[~2024-04-10 12:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 11:45 [PATCH] btrfs: move btrfs_page_mkwrite() from inode.c into file.c fdmanana
2024-04-10 12:52 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240410125220.GM3492@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).