From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: fdmanana@kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: fix function name in comment for btrfs_remove_ordered_extent()
Date: Wed, 15 May 2024 07:41:48 +0930 [thread overview]
Message-ID: <02516600-8a12-4fca-be4d-80b445646c08@gmx.com> (raw)
In-Reply-To: <4a9fa14f2211dfc080061f65c2b95b718aa608fa.1715689538.git.fdmanana@suse.com>
在 2024/5/14 23:56, fdmanana@kernel.org 写道:
> From: Filipe Manana <fdmanana@suse.com>
>
> Due to a refactoring introduced by commit 53d9981ca20e ("btrfs: split
> btrfs_alloc_ordered_extent to allocation and insertion helpers"), the
> function btrfs_alloc_ordered_extent() was renamed to
> alloc_ordered_extent(), so the comment at btrfs_remove_ordered_extent()
> is no longer very accurate. Update the comment to refer to the new
> name "alloc_ordered_extent()".
>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Thanks,
Qu
> ---
> fs/btrfs/ordered-data.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/ordered-data.c b/fs/btrfs/ordered-data.c
> index a6c2b4e5edf1..d7c59bf924fd 100644
> --- a/fs/btrfs/ordered-data.c
> +++ b/fs/btrfs/ordered-data.c
> @@ -595,7 +595,7 @@ void btrfs_remove_ordered_extent(struct btrfs_inode *btrfs_inode,
> freespace_inode = btrfs_is_free_space_inode(btrfs_inode);
>
> btrfs_lockdep_acquire(fs_info, btrfs_trans_pending_ordered);
> - /* This is paired with btrfs_alloc_ordered_extent. */
> + /* This is paired with alloc_ordered_extent(). */
> spin_lock(&btrfs_inode->lock);
> btrfs_mod_outstanding_extents(btrfs_inode, -1);
> spin_unlock(&btrfs_inode->lock);
prev parent reply other threads:[~2024-05-14 22:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 14:26 [PATCH] btrfs: fix function name in comment for btrfs_remove_ordered_extent() fdmanana
2024-05-14 16:18 ` David Sterba
2024-05-14 22:11 ` Qu Wenruo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02516600-8a12-4fca-be4d-80b445646c08@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).