From: Andreas Gruenbacher <agruenba@redhat.com>
To: linux-btrace@vger.kernel.org
Subject: Re: [PATCH 3/3] blkparse: Fix up the sector and length of split completions
Date: Tue, 07 Apr 2020 18:39:45 +0000 [thread overview]
Message-ID: <CAHc6FU5SNrfyV_WCz3Hr1MwwbhN6KL8XzjGYibXtyynTcmJ4yA@mail.gmail.com> (raw)
In-Reply-To: <20200406140915.109022-4-agruenba@redhat.com>
On Mon, Apr 6, 2020 at 4:09 PM Andreas Gruenbacher <agruenba@redhat.com> wrote:
> When a split io completes, the sector and length of the completion refer to the
> last split of the original request. This makes reading the blkparse output
> difficult, so fix up the sector and length to match the original request when
> we can (that is, when --track-ios is enabled).
I've noticed that split requests also cause the queued vs. completed
statistics at the end of a trace to be completely off, so the same
fix-up logic is needed there as well.
Also, the code currently assumes that after request splitting, the
only event that will follow is the completion of the request. I hope
that assumption holds.
Any thoughts?
Thanks,
Andreas
prev parent reply other threads:[~2020-04-07 18:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 14:09 [PATCH 3/3] blkparse: Fix up the sector and length of split completions Andreas Gruenbacher
2020-04-07 18:39 ` Andreas Gruenbacher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHc6FU5SNrfyV_WCz3Hr1MwwbhN6KL8XzjGYibXtyynTcmJ4yA@mail.gmail.com \
--to=agruenba@redhat.com \
--cc=linux-btrace@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).