From: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
To: linux-btrace@vger.kernel.org
Subject: [RFC PATCH 29/39] blktrace: add blk_log_xxx helpers()
Date: Thu, 05 Nov 2020 02:40:28 +0000 [thread overview]
Message-ID: <20201105024038.5831-30-chaitanya.kulkarni@wdc.com> (raw)
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
kernel/trace/blktrace.c | 175 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 175 insertions(+)
diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index 5cf2f60f898d..055e0ed602fb 100644
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -1996,6 +1996,23 @@ static void blk_log_action_classic(struct trace_iterator *iter, const char *act,
secs, nsec_rem, iter->ent->pid, act, rwbs);
}
+static void blk_log_action_classic_ext(struct trace_iterator *iter, const char *act,
+ bool has_cg)
+{
+ char rwbs[RWBS_LEN];
+ unsigned long long ts = iter->ts;
+ unsigned long nsec_rem = do_div(ts, NSEC_PER_SEC);
+ unsigned secs = (unsigned long)ts;
+ const struct blk_io_trace_ext *t = te_blk_io_trace_ext(iter->ent);
+
+ fill_rwbs_ext(rwbs, t);
+
+ trace_seq_printf(&iter->seq,
+ "%3d,%-3d %2d %5d.%09lu %5u %2s %3s ",
+ MAJOR(t->device), MINOR(t->device), iter->cpu,
+ secs, nsec_rem, iter->ent->pid, act, rwbs);
+}
+
static void blk_log_action(struct trace_iterator *iter, const char *act,
bool has_cg)
{
@@ -2038,6 +2055,35 @@ static void blk_log_action(struct trace_iterator *iter, const char *act,
MAJOR(t->device), MINOR(t->device), act, rwbs);
}
+static void blk_log_action_ext(struct trace_iterator *iter, const char *act,
+ bool has_cg)
+{
+ char rwbs[RWBS_LEN];
+ const struct blk_io_trace_ext *t = te_blk_io_trace_ext(iter->ent);
+
+ fill_rwbs_ext(rwbs, t);
+ if (has_cg) {
+ u64 id = t_cgid(iter->ent);
+
+ if (blk_tracer_flags.val & TRACE_BLK_OPT_CGNAME) {
+ char blkcg_name_buf[NAME_MAX + 1] = "<...>";
+
+ cgroup_path_from_kernfs_id(id, blkcg_name_buf,
+ sizeof(blkcg_name_buf));
+ trace_seq_printf(&iter->seq, "%3d,%-3d %s %2s %3s ",
+ MAJOR(t->device), MINOR(t->device),
+ blkcg_name_buf, act, rwbs);
+ } else
+ trace_seq_printf(&iter->seq,
+ "%3d,%-3d %llx,%-llx %2s %3s ",
+ MAJOR(t->device), MINOR(t->device),
+ id & U32_MAX, id >> 32, act, rwbs);
+ } else
+ trace_seq_printf(&iter->seq, "%3d,%-3d %2s %3s ",
+ MAJOR(t->device), MINOR(t->device), act, rwbs);
+}
+
+
static void blk_log_dump_pdu(struct trace_seq *s,
const struct trace_entry *ent, bool has_cg)
{
@@ -2077,6 +2123,45 @@ static void blk_log_dump_pdu(struct trace_seq *s,
trace_seq_puts(s, ") ");
}
+static void blk_log_dump_pdu_ext(struct trace_seq *s,
+ const struct trace_entry *ent, bool has_cg)
+{
+ const unsigned char *pdu_buf;
+ int pdu_len;
+ int i, end;
+
+ pdu_buf = pdu_start_ext(ent, has_cg);
+ pdu_len = pdu_real_len_ext(ent, has_cg);
+
+ if (!pdu_len)
+ return;
+
+ /* find the last zero that needs to be printed */
+ for (end = pdu_len - 1; end >= 0; end--)
+ if (pdu_buf[end])
+ break;
+ end++;
+
+ trace_seq_putc(s, '(');
+
+ for (i = 0; i < pdu_len; i++) {
+
+ trace_seq_printf(s, "%s%02x",
+ i = 0 ? "" : " ", pdu_buf[i]);
+
+ /*
+ * stop when the rest is just zeroes and indicate so
+ * with a ".." appended
+ */
+ if (i = end && end != pdu_len - 1) {
+ trace_seq_puts(s, " ..) ");
+ return;
+ }
+ }
+
+ trace_seq_puts(s, ") ");
+}
+
static void blk_log_generic(struct trace_seq *s, const struct trace_entry *ent, bool has_cg)
{
char cmd[TASK_COMM_LEN];
@@ -2096,6 +2181,28 @@ static void blk_log_generic(struct trace_seq *s, const struct trace_entry *ent,
}
}
+static void blk_log_generic_ext(struct trace_seq *s,
+ const struct trace_entry *ent,
+ bool has_cg)
+{
+ char cmd[TASK_COMM_LEN];
+
+ trace_find_cmdline(ent->pid, cmd);
+
+ if (t_action(ent) & BLK_TC_ACT_EXT(BLK_TC_PC)) {
+ trace_seq_printf(s, "%u ", t_bytes_ext(ent));
+ blk_log_dump_pdu_ext(s, ent, has_cg);
+ trace_seq_printf(s, "[%s]\n", cmd);
+ } else {
+ if (t_sec_ext(ent))
+ trace_seq_printf(s, "%llu + %u [%s]\n",
+ t_sector_ext(ent),
+ t_sec_ext(ent), cmd);
+ else
+ trace_seq_printf(s, "[%s]\n", cmd);
+ }
+}
+
static void blk_log_with_error(struct trace_seq *s,
const struct trace_entry *ent, bool has_cg)
{
@@ -2113,6 +2220,23 @@ static void blk_log_with_error(struct trace_seq *s,
}
}
+static void blk_log_with_error_ext(struct trace_seq *s,
+ const struct trace_entry *ent, bool has_cg)
+{
+ if (t_action_ext(ent) & BLK_TC_ACT_EXT(BLK_TC_PC)) {
+ blk_log_dump_pdu_ext(s, ent, has_cg);
+ trace_seq_printf(s, "[%d]\n", t_error_ext(ent));
+ } else {
+ if (t_sec_ext(ent))
+ trace_seq_printf(s, "%llu + %u [%d]\n",
+ t_sector_ext(ent),
+ t_sec_ext(ent), t_error_ext(ent));
+ else
+ trace_seq_printf(s, "%llu [%d]\n",
+ t_sector_ext(ent), t_error_ext(ent));
+ }
+}
+
static void blk_log_remap(struct trace_seq *s, const struct trace_entry *ent, bool has_cg)
{
const struct blk_io_trace_remap *__r = pdu_start(ent, has_cg);
@@ -2124,6 +2248,18 @@ static void blk_log_remap(struct trace_seq *s, const struct trace_entry *ent, bo
be64_to_cpu(__r->sector_from));
}
+static void blk_log_remap_ext(struct trace_seq *s, const struct trace_entry *ent,
+ bool has_cg)
+{
+ const struct blk_io_trace_remap *__r = pdu_start_ext(ent, has_cg);
+
+ trace_seq_printf(s, "%llu + %u <- (%d,%d) %llu\n",
+ t_sector_ext(ent), t_sec_ext(ent),
+ MAJOR(be32_to_cpu(__r->device_from)),
+ MINOR(be32_to_cpu(__r->device_from)),
+ be64_to_cpu(__r->sector_from));
+}
+
static void blk_log_plug(struct trace_seq *s, const struct trace_entry *ent, bool has_cg)
{
char cmd[TASK_COMM_LEN];
@@ -2133,6 +2269,16 @@ static void blk_log_plug(struct trace_seq *s, const struct trace_entry *ent, boo
trace_seq_printf(s, "[%s]\n", cmd);
}
+static void blk_log_plug_ext(struct trace_seq *s, const struct trace_entry *ent,
+ bool has_cg)
+{
+ char cmd[TASK_COMM_LEN];
+
+ trace_find_cmdline(ent->pid, cmd);
+
+ trace_seq_printf(s, "[%s] %llu\n", cmd, get_pdu_int_ext(ent, has_cg));
+}
+
static void blk_log_unplug(struct trace_seq *s, const struct trace_entry *ent, bool has_cg)
{
char cmd[TASK_COMM_LEN];
@@ -2142,6 +2288,16 @@ static void blk_log_unplug(struct trace_seq *s, const struct trace_entry *ent, b
trace_seq_printf(s, "[%s] %llu\n", cmd, get_pdu_int(ent, has_cg));
}
+static void blk_log_unplug_ext(struct trace_seq *s, const struct trace_entry *ent,
+ bool has_cg)
+{
+ char cmd[TASK_COMM_LEN];
+
+ trace_find_cmdline(ent->pid, cmd);
+
+ trace_seq_printf(s, "[%s] %llu\n", cmd, get_pdu_int_ext(ent, has_cg));
+}
+
static void blk_log_split(struct trace_seq *s, const struct trace_entry *ent, bool has_cg)
{
char cmd[TASK_COMM_LEN];
@@ -2152,6 +2308,16 @@ static void blk_log_split(struct trace_seq *s, const struct trace_entry *ent, bo
get_pdu_int(ent, has_cg), cmd);
}
+static void blk_log_split_ext(struct trace_seq *s, const struct trace_entry *ent, bool has_cg)
+{
+ char cmd[TASK_COMM_LEN];
+
+ trace_find_cmdline(ent->pid, cmd);
+
+ trace_seq_printf(s, "%llu / %llu [%s]\n", t_sector_ext(ent),
+ get_pdu_int_ext(ent, has_cg), cmd);
+}
+
static void blk_log_msg(struct trace_seq *s, const struct trace_entry *ent,
bool has_cg)
{
@@ -2161,6 +2327,15 @@ static void blk_log_msg(struct trace_seq *s, const struct trace_entry *ent,
trace_seq_putc(s, '\n');
}
+static void blk_log_msg_ext(struct trace_seq *s, const struct trace_entry *ent,
+ bool has_cg)
+{
+
+ trace_seq_putmem(s, pdu_start_ext(ent, has_cg),
+ pdu_real_len_ext(ent, has_cg));
+ trace_seq_putc(s, '\n');
+}
+
/*
* struct tracer operations
*/
--
2.22.1
next reply other threads:[~2020-11-05 2:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 2:40 Chaitanya Kulkarni [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-08-25 22:09 [RFC PATCH 29/39] blktrace: add blk_log_xxx helpers() Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201105024038.5831-30-chaitanya.kulkarni@wdc.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=linux-btrace@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).