From: Andreas Gruenbacher <agruenba@redhat.com>
To: linux-btrace@vger.kernel.org
Subject: [PATCH v2 0/4] Split io tracing
Date: Mon, 13 Apr 2020 19:01:48 +0000 [thread overview]
Message-ID: <20200413190153.86357-1-agruenba@redhat.com> (raw)
Hi,
here's an update of the patches posted on April 6. We recently ran into
bio splitting problems in the kernel. A typical request would show up
in the blktrace output as follows or worse:
253,2 8 23 0.041305439 4907 Q R 645838360 + 896 [dd]
253,2 8 24 0.041307791 4907 X R 645838360 / 645838872 [dd]
253,2 8 25 0.041308789 4907 X R 645838360 / 645838592 [dd]
253,2 8 26 0.041313578 4907 X R 645838872 / 645839104 [dd]
253,2 8 27 0.041319035 4907 X R 645838592 / 645838848 [dd]
[...]
253,2 8 68 0.051036527 0 C R 645839104 + 152 [0]
The kernel bug leading to this kind of result (a split into
232-256-24-232-152 instead of 232-256-256-152) has meanwhile been fixed,
but those kinds of traces remain difficult to read, for two reasons:
First, the sector and length of the completion don't match the
request. This isn't what it says in the blkparse manual page, it's hard
to match a request to the corresponding completion, and it causes the
statistics to be off as well.
Second, it's difficult to figure out which pieces a request is getting
split into.
I don't have a good answer to the second problem, but this patch queue
addresses the first problem by fixing up sector and length of split
completions at least. The last line above would turn into:
253,2 8 68 0.051036527 0 C R 645838360 + 896 [0]
Thanks,
Andreas
Andreas Gruenbacher (4):
blkparse: Fix device in event tracking error messages
blkparse: Allow request tracking on non md/dm devices
blkparse: Initialize and test for undefined request tracking
timestamps
blkparse: Fix up the sector and length of split completions
blkparse.c | 169 ++++++++++++++++++++++++++++++++++++++++-------------
1 file changed, 130 insertions(+), 39 deletions(-)
base-commit: db4f6340e04716285ea56fe26d76381c3adabe58
--
2.25.2
next reply other threads:[~2020-04-13 19:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 19:01 Andreas Gruenbacher [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-07 18:22 [PATCH v2 0/4] Split io tracing Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200413190153.86357-1-agruenba@redhat.com \
--to=agruenba@redhat.com \
--cc=linux-btrace@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).