From: "K, Kiran" <kiran.k@intel.com>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: "linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
"Srivatsa, Ravishankar" <ravishankar.srivatsa@intel.com>,
"Tumkur Narayan, Chethan" <chethan.tumkur.narayan@intel.com>,
"Devegowda, Chandrashekar" <chandrashekar.devegowda@intel.com>
Subject: RE: [PATCH v1 1/2] Bluetooth: btintel: Add support for BlazarI
Date: Fri, 3 May 2024 05:13:51 +0000 [thread overview]
Message-ID: <PH0PR11MB758556D5107ABA3811FE7E00F51F2@PH0PR11MB7585.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1d11ab52-2369-485d-a1cf-cca6ca836cb0@molgen.mpg.de>
Hi Paul,
Appreciate your comments.
> -----Original Message-----
> From: Paul Menzel <pmenzel@molgen.mpg.de>
> Sent: Thursday, May 2, 2024 11:24 AM
> To: K, Kiran <kiran.k@intel.com>
> Cc: linux-bluetooth@vger.kernel.org; Srivatsa, Ravishankar
> <ravishankar.srivatsa@intel.com>; Tumkur Narayan, Chethan
> <chethan.tumkur.narayan@intel.com>; Devegowda, Chandrashekar
> <chandrashekar.devegowda@intel.com>
> Subject: Re: [PATCH v1 1/2] Bluetooth: btintel: Add support for BlazarI
>
> Dear Kiran,
>
>
> Thank you for your patch.
>
> Am 02.05.24 um 07:23 schrieb Kiran K:
> > Add support for BlazarI (cnvi) bluetooth core.
>
> It’d be great if you documented the datasheet name and revision.
I am afraid to provide these details as these data is internal.
>
> Also, it’d help people reading the diff, if you added what the support entails.
> In this case a note, that it’s a “standard device” and only the new id needs to
> be added, would be nice.
Ack.
>
> > Signed-off-by: Kiran K <kiran.k@intel.com>
> > ---
> > drivers/bluetooth/btintel.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> > index dc48352166a5..4f4bd5538b6e 100644
> > --- a/drivers/bluetooth/btintel.c
> > +++ b/drivers/bluetooth/btintel.c
> > @@ -481,6 +481,7 @@ static int btintel_version_info_tlv(struct hci_dev
> *hdev,
> > case 0x19: /* Slr-F */
> > case 0x1b: /* Mgr */
> > case 0x1c: /* Gale Peak (GaP) */
> > + case 0x1e: /* BlazarI (Bzr) */
> > break;
> > default:
> > bt_dev_err(hdev, "Unsupported Intel hardware variant
> (0x%x)", @@
> > -2698,6 +2699,7 @@ static void btintel_set_msft_opcode(struct hci_dev
> *hdev, u8 hw_variant)
> > case 0x19:
> > case 0x1b:
> > case 0x1c:
> > + case 0x1e:
> > hci_set_msft_opcode(hdev, 0xFC1E);
> > break;
> > default:
> > @@ -3037,6 +3039,7 @@ static int btintel_setup_combined(struct hci_dev
> *hdev)
> > case 0x19:
> > case 0x1b:
> > case 0x1c:
> > + case 0x1e:
> > /* Display version information of TLV type */
> > btintel_version_info_tlv(hdev, &ver_tlv);
>
>
> Kind regards,
>
> Paul
Thanks,
Kiran
next prev parent reply other threads:[~2024-05-03 5:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 5:23 [PATCH v1 1/2] Bluetooth: btintel: Add support for BlazarI Kiran K
2024-05-02 5:23 ` [PATCH v1 2/2] Bluetooth: btintel: Add support for Filmore Peak2 (BE201) Kiran K
2024-05-02 5:33 ` [v1,1/2] Bluetooth: btintel: Add support for BlazarI bluez.test.bot
2024-05-02 5:53 ` [PATCH v1 1/2] " Paul Menzel
2024-05-03 5:13 ` K, Kiran [this message]
2024-05-02 21:00 ` patchwork-bot+bluetooth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB758556D5107ABA3811FE7E00F51F2@PH0PR11MB7585.namprd11.prod.outlook.com \
--to=kiran.k@intel.com \
--cc=chandrashekar.devegowda@intel.com \
--cc=chethan.tumkur.narayan@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
--cc=ravishankar.srivatsa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).