From: Sean Wang <sean.wang@kernel.org>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: kernel test robot <lkp@intel.com>,
marcel@holtmann.org, johan.hedberg@gmail.com,
oe-kbuild-all@lists.linux.dev, linux-bluetooth@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-kernel@vger.kernel.org, Sean Wang <sean.wang@mediatek.com>
Subject: Re: [PATCH v4 1/5] Bluetooth: btmtk: add the function to get the fw name
Date: Wed, 8 May 2024 13:38:13 -0700 [thread overview]
Message-ID: <CAGp9LzrNE9Hi-a9y8oQMXmug44k7VUsmcDiAiXgbFu8bLbtFTg@mail.gmail.com> (raw)
In-Reply-To: <CABBYNZLH7mGdP7AcdHnY8q=3i=Lupk-D2Af4G5X4o1_XdbTfVw@mail.gmail.com>
Hi,
On Wed, May 8, 2024 at 7:37 AM Luiz Augusto von Dentz
<luiz.dentz@gmail.com> wrote:
>
> Hi Sean,
>
> On Wed, May 8, 2024 at 3:13 AM kernel test robot <lkp@intel.com> wrote:
> >
> > Hi,
> >
> > kernel test robot noticed the following build warnings:
> >
> > [auto build test WARNING on bluetooth/master]
> > [also build test WARNING on bluetooth-next/master linus/master v6.9-rc7 next-20240507]
> > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > And when submitting patch, we suggest to use '--base' as documented in
> > https://git-scm.com/docs/git-format-patch#_base_tree_information]
> >
> > url: https://github.com/intel-lab-lkp/linux/commits/sean-wang-kernel-org/Bluetooth-btmtk-apply-the-common-btmtk_fw_get_filename/20240508-032333
> > base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master
> > patch link: https://lore.kernel.org/r/965cd14922aea67e2750ff2c2ecad773f8ba485a.1715109394.git.sean.wang%40kernel.org
> > patch subject: [PATCH v4 1/5] Bluetooth: btmtk: add the function to get the fw name
> > config: arm64-defconfig (https://download.01.org/0day-ci/archive/20240508/202405081456.v2MvcQ0P-lkp@intel.com/config)
> > compiler: aarch64-linux-gcc (GCC) 13.2.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240508/202405081456.v2MvcQ0P-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202405081456.v2MvcQ0P-lkp@intel.com/
> >
> > All warnings (new ones prefixed by >>):
> >
> > drivers/bluetooth/btmtk.c: In function 'btmtk_fw_get_filename':
> > >> drivers/bluetooth/btmtk.c:115:35: warning: 'mediatek/BT_RAM_CODE_MT' directive output truncated writing 23 bytes into a region of size 8 [-Wformat-truncation=]
> > 115 | "mediatek/BT_RAM_CODE_MT%04x_1a_%x_hdr.bin",
> > | ~~~~~~~~^~~~~~~~~~~~~~~
> > drivers/bluetooth/btmtk.c:115:26: note: directive argument in the range [1, 256]
> > 115 | "mediatek/BT_RAM_CODE_MT%04x_1a_%x_hdr.bin",
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > drivers/bluetooth/btmtk.c:114:17: note: 'snprintf' output between 41 and 43 bytes into a destination of size 8
> > 114 | snprintf(buf, sizeof(size),
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> > 115 | "mediatek/BT_RAM_CODE_MT%04x_1a_%x_hdr.bin",
> > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > 116 | dev_id & 0xffff, (fw_ver & 0xff) + 1);
> > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> >
> > vim +115 drivers/bluetooth/btmtk.c
> >
> > 105
> > 106 void btmtk_fw_get_filename(char *buf, size_t size, u32 dev_id, u32 fw_ver,
> > 107 u32 fw_flavor)
> > 108 {
> > 109 if (dev_id == 0x7925)
> > 110 snprintf(buf, size,
> > 111 "mediatek/mt%04x/BT_RAM_CODE_MT%04x_1_%x_hdr.bin",
> > 112 dev_id & 0xffff, dev_id & 0xffff, (fw_ver & 0xff) + 1);
> > 113 else if (dev_id == 0x7961 && fw_flavor)
> > 114 snprintf(buf, sizeof(size),
> > > 115 "mediatek/BT_RAM_CODE_MT%04x_1a_%x_hdr.bin",
> > 116 dev_id & 0xffff, (fw_ver & 0xff) + 1);
> > 117 else
> > 118 snprintf(buf, size,
> > 119 "mediatek/BT_RAM_CODE_MT%04x_1_%x_hdr.bin",
> > 120 dev_id & 0xffff, (fw_ver & 0xff) + 1);
> > 121 }
> > 122 EXPORT_SYMBOL_GPL(btmtk_fw_get_filename);
> > 123
>
> Could you please fix the above?
No problem, I'll take care of it and send it over later.
Sean
>
> --
> Luiz Augusto von Dentz
next prev parent reply other threads:[~2024-05-08 20:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 19:21 [PATCH v4 1/5] Bluetooth: btmtk: add the function to get the fw name sean.wang
2024-05-07 19:21 ` [PATCH v4 2/5] Bluetooth: btmtk: apply the common btmtk_fw_get_filename sean.wang
2024-05-07 19:21 ` [PATCH v4 3/5] Bluetooth: btusb: mediatek: refactor the function btusb_mtk_reset sean.wang
2024-05-07 19:22 ` [PATCH v4 4/5] Bluetooth: btusb: mediatek: reset the controller before downloading the fw sean.wang
2024-05-07 19:22 ` [PATCH v4 5/5] Bluetooth: btusb: mediatek: add MT7922 subsystem reset sean.wang
2024-05-07 19:56 ` [v4,1/5] Bluetooth: btmtk: add the function to get the fw name bluez.test.bot
2024-05-08 7:12 ` [PATCH v4 1/5] " kernel test robot
2024-05-08 14:37 ` Luiz Augusto von Dentz
2024-05-08 20:38 ` Sean Wang [this message]
2024-05-08 11:22 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGp9LzrNE9Hi-a9y8oQMXmug44k7VUsmcDiAiXgbFu8bLbtFTg@mail.gmail.com \
--to=sean.wang@kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lkp@intel.com \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).