From: Sean Wang <sean.wang@kernel.org>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: Hao Qin <hao.qin@mediatek.com>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Sean Wang <sean.wang@mediatek.com>,
Deren Wu <deren.Wu@mediatek.com>,
Aaron Hou <aaron.hou@mediatek.com>,
Chris Lu <chris.lu@mediatek.com>,
Steve Lee <steve.lee@mediatek.com>,
linux-bluetooth <linux-bluetooth@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-mediatek <linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH] Bluetooth: btusb: mediatek: Support auto revert for MT7922
Date: Tue, 7 May 2024 12:29:11 -0700 [thread overview]
Message-ID: <CAGp9Lzquy_NzVwF24va87QViucpF6y-zxv1gECy2sJ5J5pFy_g@mail.gmail.com> (raw)
In-Reply-To: <CABBYNZJ-rvMuqHjFmQuxhmWv_K5fGFktAk-CeZfx8rw36L-Etg@mail.gmail.com>
Hi Luiz,
Please disregard the patch. We will proceed with the journey using the
latest patchset I provided in the following link
https://lists.infradead.org/pipermail/linux-mediatek/2024-May/079017.html
Sean
On Wed, Apr 17, 2024 at 2:18 PM Luiz Augusto von Dentz
<luiz.dentz@gmail.com> wrote:
>
> Hi,
>
> On Fri, Apr 12, 2024 at 5:57 AM Hao Qin <hao.qin@mediatek.com> wrote:
> >
> > Add support for auto reverting MT7922 during reset process.
>
> Need some more information of what auto reverting means in this
> context and what problem does it solves?
>
> >
> > Signed-off-by: Hao Qin <hao.qin@mediatek.com>
> > ---
> > drivers/bluetooth/btusb.c | 14 +++++++++++++-
> > 1 file changed, 13 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> > index 4c0cc13adb47..0ad96ec8d31d 100644
> > --- a/drivers/bluetooth/btusb.c
> > +++ b/drivers/bluetooth/btusb.c
> > @@ -3032,7 +3032,16 @@ static int btusb_mtk_reset(struct hci_dev *hdev, void *rst_data)
> > usb_kill_anchored_urbs(&data->tx_anchor);
> > mediatek = hci_get_priv(hdev);
> >
> > - if (mediatek->dev_id == 0x7925) {
> > + if (mediatek->dev_id == 0x7922) {
> > + btusb_mtk_uhw_reg_read(data, MTK_BT_SUBSYS_RST, &val);
> > + val |= 0x00002020;
> > + btusb_mtk_uhw_reg_write(data, MTK_BT_SUBSYS_RST, val);
> > + btusb_mtk_uhw_reg_write(data, MTK_EP_RST_OPT, 0x00010001);
> > + btusb_mtk_uhw_reg_read(data, MTK_BT_SUBSYS_RST, &val);
> > + val |= BIT(0);
> > + btusb_mtk_uhw_reg_write(data, MTK_BT_SUBSYS_RST, val);
> > + msleep(100);
> > + } else if (mediatek->dev_id == 0x7925) {
> > btusb_mtk_uhw_reg_read(data, MTK_BT_RESET_REG_CONNV3, &val);
> > val |= (1 << 5);
> > btusb_mtk_uhw_reg_write(data, MTK_BT_RESET_REG_CONNV3, val);
> > @@ -3072,6 +3081,9 @@ static int btusb_mtk_reset(struct hci_dev *hdev, void *rst_data)
> > if (err < 0)
> > bt_dev_err(hdev, "Reset timeout");
> >
> > + if (mediatek->dev_id == 0x7922)
> > + btusb_mtk_uhw_reg_write(data, MTK_UDMA_INT_STA_BT, 0x000000FF);
> > +
> > btusb_mtk_id_get(data, 0x70010200, &val);
> > if (!val)
> > bt_dev_err(hdev, "Can't get device id, subsys reset fail.");
> > --
> > 2.18.0
> >
>
>
> --
> Luiz Augusto von Dentz
>
prev parent reply other threads:[~2024-05-07 19:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 9:57 [PATCH] Bluetooth: btusb: mediatek: Support auto revert for MT7922 Hao Qin
2024-04-12 10:32 ` bluez.test.bot
2024-04-17 21:17 ` [PATCH] " Luiz Augusto von Dentz
2024-05-07 19:29 ` Sean Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGp9Lzquy_NzVwF24va87QViucpF6y-zxv1gECy2sJ5J5pFy_g@mail.gmail.com \
--to=sean.wang@kernel.org \
--cc=aaron.hou@mediatek.com \
--cc=chris.lu@mediatek.com \
--cc=deren.Wu@mediatek.com \
--cc=hao.qin@mediatek.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=sean.wang@mediatek.com \
--cc=steve.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).