From: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: "marcel@holtmann.org" <marcel@holtmann.org>,
"luiz.dentz@gmail.com" <luiz.dentz@gmail.com>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Amitkumar Karwar <amitkumar.karwar@nxp.com>,
Rohit Fule <rohit.fule@nxp.com>, Sherry Sun <sherry.sun@nxp.com>,
Luke Wang <ziniu.wang_1@nxp.com>, Bough Chen <haibo.chen@nxp.com>,
LnxRevLi <LnxRevLi@nxp.com>,
Guillaume Legoupil <guillaume.legoupil@nxp.com>,
Salim Chebbo <salim.chebbo@nxp.com>
Subject: Re: [PATCH v3] Bluetooth: btnxpuart: Enable status prints for firmware download
Date: Wed, 15 May 2024 07:18:10 +0000 [thread overview]
Message-ID: <AS4PR04MB969212EDE791409746028506E7EC2@AS4PR04MB9692.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <5d7f5918-d821-4757-bce9-2fede79d7fe4@molgen.mpg.de>
Hi Paul,
Thank you for reviewing this patch.
> Am 14.05.24 um 11:14 schrieb Neeraj Sanjay Kale:
> > This enables prints for firmware download which can help automation
> > tests to verify firmware download functionality.
>
> Please paste the old and new log messages to the commit message.
>
> > A new flag BTNXPUART_FW_DOWNLOAD_ABORT is added which handles
> the
> > situation where driver is removed while firmware download is in
> > progress.
>
> Could this be a separate patch?
>
> > This also adds a check before freeing the rx->skb in flush and close
> > functions to handle the kernel crash seen in case of firmware download
> > timeout.
>
> Please make this a separate commit with a Fixes: tag.
>
I have split this patch into a 3-commit patch series and sent for review today. Please let me know your feedback on it.
We can ignore/discard this patch now.
Thanks,
Neeraj
next prev parent reply other threads:[~2024-05-15 7:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 9:14 [PATCH v3] Bluetooth: btnxpuart: Enable status prints for firmware download Neeraj Sanjay Kale
2024-05-14 9:20 ` Paul Menzel
2024-05-15 7:18 ` Neeraj Sanjay Kale [this message]
2024-05-14 9:56 ` [v3] " bluez.test.bot
-- strict thread matches above, loose matches on Subject: below --
2024-04-17 8:15 [PATCH v3] " Neeraj Sanjay Kale
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS4PR04MB969212EDE791409746028506E7EC2@AS4PR04MB9692.eurprd04.prod.outlook.com \
--to=neeraj.sanjaykale@nxp.com \
--cc=LnxRevLi@nxp.com \
--cc=amitkumar.karwar@nxp.com \
--cc=guillaume.legoupil@nxp.com \
--cc=haibo.chen@nxp.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=pmenzel@molgen.mpg.de \
--cc=rohit.fule@nxp.com \
--cc=salim.chebbo@nxp.com \
--cc=sherry.sun@nxp.com \
--cc=ziniu.wang_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).