From: bluez.test.bot@gmail.com
To: linux-bluetooth@vger.kernel.org, arun@asymptotic.io
Subject: RE: ASHA plugin
Date: Wed, 08 May 2024 19:57:45 -0700 (PDT) [thread overview]
Message-ID: <663c3ba9.050a0220.d6e7d.0693@mx.google.com> (raw)
In-Reply-To: <20240509022640.451351-2-arun@asymptotic.io>
[-- Attachment #1: Type: text/plain, Size: 17801 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=851754
---Test result---
Test Summary:
CheckPatch FAIL 2.75 seconds
GitLint PASS 2.00 seconds
BuildEll PASS 24.67 seconds
BluezMake FAIL 19.36 seconds
MakeCheck FAIL 37.41 seconds
MakeDistcheck FAIL 38.50 seconds
CheckValgrind FAIL 16.39 seconds
CheckSmatch FAIL 24.64 seconds
bluezmakeextell FAIL 14.84 seconds
IncrementalBuild FAIL 19.79 seconds
ScanBuild FAIL 542.04 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[BlueZ,v2,1/4] profiles: Add initial code for an ASHA plugin
WARNING:LONG_LINE_COMMENT: line length of 81 exceeds 80 columns
#259: FILE: profiles/audio/asha.c:78:
+ /* Use a string in case we want to support anything else in the future */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#581: FILE: profiles/audio/media.c:3415:
+ * work, so let's create one */
ERROR:FUNCTION_WITHOUT_ARGS: Bad function definition - const struct media_endpoint *media_endpoint_get_asha() should probably be const struct media_endpoint *media_endpoint_get_asha(void)
#598: FILE: profiles/audio/media.h:28:
+const struct media_endpoint *media_endpoint_get_asha();
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#977: FILE: src/shared/asha.c:133:
+ * type on older(?) kernels */
WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#1008: FILE: src/shared/asha.c:164:
+ error("Could not connect L2CAP CoC socket: %s", strerror(errno));
/github/workspace/src/src/13659387.patch total: 1 errors, 4 warnings, 1237 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13659387.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
[BlueZ,v2,2/4] test: Add a script to test ASHA
ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files
#103: FILE: test/simple-asha
/github/workspace/src/src/13659384.patch total: 1 errors, 0 warnings, 158 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13659384.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: BluezMake - FAIL
Desc: Build BlueZ
Output:
In file included from src/shared/asha.c:33:
src/shared/asha.c: In function ‘asha_connect_socket’:
src/shared/asha.c:125:57: error: ‘errno’ undeclared (first use in this function)
125 | error("Could not open L2CAP CoC socket: %s", strerror(errno));
| ^~~~~
./src/log.h:62:59: note: in definition of macro ‘error’
62 | btd_error(0xffff, "%s:%s() " fmt, __FILE__, __func__, ## arg)
| ^~~
src/shared/asha.c:37:1: note: ‘errno’ is defined in header ‘<errno.h>’; did you forget to ‘#include <errno.h>’?
36 | #include "l2cap.h"
+++ |+#include <errno.h>
37 |
In file included from src/shared/asha.c:33:
src/shared/asha.c:125:57: note: each undeclared identifier is reported only once for each function it appears in
125 | error("Could not open L2CAP CoC socket: %s", strerror(errno));
| ^~~~~
./src/log.h:62:59: note: in definition of macro ‘error’
62 | btd_error(0xffff, "%s:%s() " fmt, __FILE__, __func__, ## arg)
| ^~~
make[1]: *** [Makefile:8670: src/shared/libshared_mainloop_la-asha.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4663: all] Error 2
##############################
Test: MakeCheck - FAIL
Desc: Run Bluez Make Check
Output:
In file included from src/shared/asha.c:33:
src/shared/asha.c: In function ‘asha_connect_socket’:
src/shared/asha.c:125:57: error: ‘errno’ undeclared (first use in this function)
125 | error("Could not open L2CAP CoC socket: %s", strerror(errno));
| ^~~~~
./src/log.h:62:59: note: in definition of macro ‘error’
62 | btd_error(0xffff, "%s:%s() " fmt, __FILE__, __func__, ## arg)
| ^~~
src/shared/asha.c:37:1: note: ‘errno’ is defined in header ‘<errno.h>’; did you forget to ‘#include <errno.h>’?
36 | #include "l2cap.h"
+++ |+#include <errno.h>
37 |
In file included from src/shared/asha.c:33:
src/shared/asha.c:125:57: note: each undeclared identifier is reported only once for each function it appears in
125 | error("Could not open L2CAP CoC socket: %s", strerror(errno));
| ^~~~~
./src/log.h:62:59: note: in definition of macro ‘error’
62 | btd_error(0xffff, "%s:%s() " fmt, __FILE__, __func__, ## arg)
| ^~~
make[1]: *** [Makefile:8425: src/shared/libshared_glib_la-asha.lo] Error 1
make: *** [Makefile:12246: check] Error 2
##############################
Test: MakeDistcheck - FAIL
Desc: Run Bluez Make Distcheck
Output:
Package cups was not found in the pkg-config search path.
Perhaps you should add the directory containing `cups.pc'
to the PKG_CONFIG_PATH environment variable
No package 'cups' found
../../src/shared/asha.c:36:10: fatal error: l2cap.h: No such file or directory
36 | #include "l2cap.h"
| ^~~~~~~~~
compilation terminated.
make[2]: *** [Makefile:8670: src/shared/libshared_mainloop_la-asha.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Makefile:4663: all] Error 2
make: *** [Makefile:12167: distcheck] Error 1
##############################
Test: CheckValgrind - FAIL
Desc: Run Bluez Make Check with Valgrind
Output:
In file included from src/shared/asha.c:33:
src/shared/asha.c: In function ‘asha_connect_socket’:
src/shared/asha.c:125:57: error: ‘errno’ undeclared (first use in this function)
125 | error("Could not open L2CAP CoC socket: %s", strerror(errno));
| ^~~~~
./src/log.h:62:59: note: in definition of macro ‘error’
62 | btd_error(0xffff, "%s:%s() " fmt, __FILE__, __func__, ## arg)
| ^~~
src/shared/asha.c:37:1: note: ‘errno’ is defined in header ‘<errno.h>’; did you forget to ‘#include <errno.h>’?
36 | #include "l2cap.h"
+++ |+#include <errno.h>
37 |
In file included from src/shared/asha.c:33:
src/shared/asha.c:125:57: note: each undeclared identifier is reported only once for each function it appears in
125 | error("Could not open L2CAP CoC socket: %s", strerror(errno));
| ^~~~~
./src/log.h:62:59: note: in definition of macro ‘error’
62 | btd_error(0xffff, "%s:%s() " fmt, __FILE__, __func__, ## arg)
| ^~~
make[1]: *** [Makefile:8670: src/shared/libshared_mainloop_la-asha.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:12246: check] Error 2
##############################
Test: CheckSmatch - FAIL
Desc: Run smatch tool with source
Output:
src/shared/crypto.c:271:21: warning: Variable length array is used.
src/shared/crypto.c:272:23: warning: Variable length array is used.
src/shared/gatt-helpers.c:768:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:830:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:1323:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:1354:23: warning: Variable length array is used.
src/shared/gatt-server.c:278:25: warning: Variable length array is used.
src/shared/gatt-server.c:621:25: warning: Variable length array is used.
src/shared/gatt-server.c:720:25: warning: Variable length array is used.
src/shared/bap.c:282:25: warning: array of flexible structures
src/shared/bap.c: note: in included file:
./src/shared/ascs.h:88:25: warning: array of flexible structures
src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):
/usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function declaration of function 'Function'
/usr/include/readline/rltypedefs.h:36:25: warning: non-ANSI function declaration of function 'VFunction'
/usr/include/readline/rltypedefs.h:37:27: warning: non-ANSI function declaration of function 'CPFunction'
/usr/include/readline/rltypedefs.h:38:29: warning: non-ANSI function declaration of function 'CPPFunction'
In file included from src/shared/asha.c:33:
src/shared/asha.c: In function ‘asha_connect_socket’:
src/shared/asha.c:125:57: error: ‘errno’ undeclared (first use in this function)
125 | error("Could not open L2CAP CoC socket: %s", strerror(errno));
| ^~~~~
./src/log.h:62:59: note: in definition of macro ‘error’
62 | btd_error(0xffff, "%s:%s() " fmt, __FILE__, __func__, ## arg)
| ^~~
src/shared/asha.c:37:1: note: ‘errno’ is defined in header ‘<errno.h>’; did you forget to ‘#include <errno.h>’?
36 | #include "l2cap.h"
+++ |+#include <errno.h>
37 |
In file included from src/shared/asha.c:33:
src/shared/asha.c:125:57: note: each undeclared identifier is reported only once for each function it appears in
125 | error("Could not open L2CAP CoC socket: %s", strerror(errno));
| ^~~~~
./src/log.h:62:59: note: in definition of macro ‘error’
62 | btd_error(0xffff, "%s:%s() " fmt, __FILE__, __func__, ## arg)
| ^~~
make[1]: *** [Makefile:8670: src/shared/libshared_mainloop_la-asha.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4663: all] Error 2
##############################
Test: bluezmakeextell - FAIL
Desc: Build Bluez with External ELL
Output:
In file included from src/shared/asha.c:33:
src/shared/asha.c: In function ‘asha_connect_socket’:
src/shared/asha.c:125:57: error: ‘errno’ undeclared (first use in this function)
125 | error("Could not open L2CAP CoC socket: %s", strerror(errno));
| ^~~~~
./src/log.h:62:59: note: in definition of macro ‘error’
62 | btd_error(0xffff, "%s:%s() " fmt, __FILE__, __func__, ## arg)
| ^~~
src/shared/asha.c:37:1: note: ‘errno’ is defined in header ‘<errno.h>’; did you forget to ‘#include <errno.h>’?
36 | #include "l2cap.h"
+++ |+#include <errno.h>
37 |
In file included from src/shared/asha.c:33:
src/shared/asha.c:125:57: note: each undeclared identifier is reported only once for each function it appears in
125 | error("Could not open L2CAP CoC socket: %s", strerror(errno));
| ^~~~~
./src/log.h:62:59: note: in definition of macro ‘error’
62 | btd_error(0xffff, "%s:%s() " fmt, __FILE__, __func__, ## arg)
| ^~~
make[1]: *** [Makefile:8670: src/shared/libshared_mainloop_la-asha.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4663: all] Error 2
##############################
Test: IncrementalBuild - FAIL
Desc: Incremental build with the patches in the series
Output:
[BlueZ,v2,1/4] profiles: Add initial code for an ASHA plugin
In file included from src/shared/asha.c:33:
src/shared/asha.c: In function ‘asha_connect_socket’:
src/shared/asha.c:125:57: error: ‘errno’ undeclared (first use in this function)
125 | error("Could not open L2CAP CoC socket: %s", strerror(errno));
| ^~~~~
./src/log.h:62:59: note: in definition of macro ‘error’
62 | btd_error(0xffff, "%s:%s() " fmt, __FILE__, __func__, ## arg)
| ^~~
src/shared/asha.c:37:1: note: ‘errno’ is defined in header ‘<errno.h>’; did you forget to ‘#include <errno.h>’?
36 | #include "l2cap.h"
+++ |+#include <errno.h>
37 |
In file included from src/shared/asha.c:33:
src/shared/asha.c:125:57: note: each undeclared identifier is reported only once for each function it appears in
125 | error("Could not open L2CAP CoC socket: %s", strerror(errno));
| ^~~~~
./src/log.h:62:59: note: in definition of macro ‘error’
62 | btd_error(0xffff, "%s:%s() " fmt, __FILE__, __func__, ## arg)
| ^~~
make[1]: *** [Makefile:8670: src/shared/libshared_mainloop_la-asha.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4663: all] Error 2
##############################
Test: ScanBuild - FAIL
Desc: Run Scan Build
Output:
src/shared/gatt-client.c:451:21: warning: Use of memory after it is freed
gatt_db_unregister(op->client->db, op->db_id);
^~~~~~~~~~
src/shared/gatt-client.c:696:2: warning: Use of memory after it is freed
discovery_op_complete(op, false, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:996:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1102:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1294:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1359:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1634:6: warning: Use of memory after it is freed
if (read_db_hash(op)) {
^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1639:2: warning: Use of memory after it is freed
discover_all(op);
^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:2143:6: warning: Use of memory after it is freed
if (read_db_hash(op)) {
^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:2151:8: warning: Use of memory after it is freed
discovery_op_ref(op),
^~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:3240:2: warning: Use of memory after it is freed
complete_write_long_op(req, success, 0, false);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:3262:2: warning: Use of memory after it is freed
request_unref(req);
^~~~~~~~~~~~~~~~~~
12 warnings generated.
In file included from src/shared/asha.c:33:
src/shared/asha.c: In function ‘asha_connect_socket’:
src/shared/asha.c:125:57: error: ‘errno’ undeclared (first use in this function)
125 | error("Could not open L2CAP CoC socket: %s", strerror(errno));
| ^~~~~
./src/log.h:62:59: note: in definition of macro ‘error’
62 | btd_error(0xffff, "%s:%s() " fmt, __FILE__, __func__, ## arg)
| ^~~
src/shared/asha.c:37:1: note: ‘errno’ is defined in header ‘<errno.h>’; did you forget to ‘#include <errno.h>’?
36 | #include "l2cap.h"
+++ |+#include <errno.h>
37 |
In file included from src/shared/asha.c:33:
src/shared/asha.c:125:57: note: each undeclared identifier is reported only once for each function it appears in
125 | error("Could not open L2CAP CoC socket: %s", strerror(errno));
| ^~~~~
./src/log.h:62:59: note: in definition of macro ‘error’
62 | btd_error(0xffff, "%s:%s() " fmt, __FILE__, __func__, ## arg)
| ^~~
make[1]: *** [Makefile:8670: src/shared/libshared_mainloop_la-asha.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4663: all] Error 2
---
Regards,
Linux Bluetooth
next prev parent reply other threads:[~2024-05-09 2:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 2:26 [PATCH BlueZ,v2 0/4] ASHA plugin Arun Raghavan
2024-05-09 2:26 ` [PATCH BlueZ,v2 1/4] profiles: Add initial code for an " Arun Raghavan
2024-05-09 2:57 ` bluez.test.bot [this message]
2024-05-09 2:26 ` [PATCH BlueZ,v2 2/4] test: Add a script to test ASHA Arun Raghavan
2024-05-09 2:26 ` [PATCH BlueZ,v2 3/4] gitignore: Add compile_commands.json Arun Raghavan
2024-05-09 2:26 ` [PATCH BlueZ,v2 4/4] gitignore: Add __pycache__ Arun Raghavan
-- strict thread matches above, loose matches on Subject: below --
2024-06-10 22:35 [PATCH BlueZ,v9 1/3] src/shared: Add initial implementation for an ASHA profile Arun Raghavan
2024-06-10 22:53 ` ASHA plugin bluez.test.bot
2024-05-23 15:52 [PATCH BlueZ,v8 1/5] src/shared: Add initial implementation for an ASHA profile Arun Raghavan
2024-05-23 18:05 ` ASHA plugin bluez.test.bot
2024-05-23 10:29 [PATCH BlueZ,v7 1/6] src/shared: Add initial implementation for an ASHA profile Arun Raghavan
2024-05-23 12:27 ` ASHA plugin bluez.test.bot
2024-05-16 19:38 [PATCH BlueZ,v6 1/5] src/shared: Add initial implementation for an ASHA profile Arun Raghavan
2024-05-16 23:26 ` ASHA plugin bluez.test.bot
2024-05-16 14:54 [PATCH BlueZ,v4 1/5] src/shared: Add initial implementation for an ASHA profile Arun Raghavan
2024-05-16 18:28 ` ASHA plugin bluez.test.bot
2024-05-15 20:15 [PATCH BlueZ,v3 1/5] src/shared: Add initial implementation for an ASHA profile Arun Raghavan
2024-05-15 23:48 ` ASHA plugin bluez.test.bot
2024-05-08 15:46 [PATCH BlueZ 1/5] profiles: Add initial code for an " Arun Raghavan
2024-05-08 17:36 ` bluez.test.bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=663c3ba9.050a0220.d6e7d.0693@mx.google.com \
--to=bluez.test.bot@gmail.com \
--cc=arun@asymptotic.io \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).