* [PATCH BlueZ] Don't install conf and state dir on systemd
@ 2024-03-04 14:21 Max Gautier
2024-03-04 15:32 ` [BlueZ] " bluez.test.bot
2024-03-04 21:00 ` [PATCH BlueZ] " patchwork-bot+bluetooth
0 siblings, 2 replies; 3+ messages in thread
From: Max Gautier @ 2024-03-04 14:21 UTC (permalink / raw
To: linux-bluetooth; +Cc: Max Gautier
The bluetooth.service file already specify the State and Configuration
directories with the correct modes, which guarantee they will be
available (with proper permissions) when bluetoohd starts.
Not installing those helps implementing the "Hermetic /usr" pattern
(TL;DR: '/usr' contains everything necessary to boostrap a working
system)
Handling this in upstream bluez (rather than in distribution packaging
scripts) avoid duplication of efforts between distros.
Links: https://0pointer.net/blog/fitting-everything-together.html
---
Makefile.am | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Makefile.am b/Makefile.am
index d94839856..ed4f9dc51 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -422,7 +422,12 @@ include Makefile.obexd
include android/Makefile.am
include Makefile.mesh
+if SYSTEMD
+install-data-hook: obexd-add-service-symlink
+else
install-data-hook: bluetoothd-fix-permissions obexd-add-service-symlink
+endif
+
uninstall-hook: obexd-remove-service-symlink
if HID2HCI
--
2.44.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [BlueZ] Don't install conf and state dir on systemd
2024-03-04 14:21 [PATCH BlueZ] Don't install conf and state dir on systemd Max Gautier
@ 2024-03-04 15:32 ` bluez.test.bot
2024-03-04 21:00 ` [PATCH BlueZ] " patchwork-bot+bluetooth
1 sibling, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2024-03-04 15:32 UTC (permalink / raw
To: linux-bluetooth, mg
[-- Attachment #1: Type: text/plain, Size: 946 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=832119
---Test result---
Test Summary:
CheckPatch PASS 0.41 seconds
GitLint PASS 0.31 seconds
BuildEll PASS 25.01 seconds
BluezMake PASS 725.21 seconds
MakeCheck PASS 11.83 seconds
MakeDistcheck PASS 166.95 seconds
CheckValgrind PASS 229.44 seconds
CheckSmatch PASS 340.07 seconds
bluezmakeextell PASS 109.26 seconds
IncrementalBuild PASS 670.91 seconds
ScanBuild PASS 965.73 seconds
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH BlueZ] Don't install conf and state dir on systemd
2024-03-04 14:21 [PATCH BlueZ] Don't install conf and state dir on systemd Max Gautier
2024-03-04 15:32 ` [BlueZ] " bluez.test.bot
@ 2024-03-04 21:00 ` patchwork-bot+bluetooth
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+bluetooth @ 2024-03-04 21:00 UTC (permalink / raw
To: Max Gautier; +Cc: linux-bluetooth
Hello:
This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
On Mon, 4 Mar 2024 15:21:57 +0100 you wrote:
> The bluetooth.service file already specify the State and Configuration
> directories with the correct modes, which guarantee they will be
> available (with proper permissions) when bluetoohd starts.
>
> Not installing those helps implementing the "Hermetic /usr" pattern
> (TL;DR: '/usr' contains everything necessary to boostrap a working
> system)
>
> [...]
Here is the summary with links:
- [BlueZ] Don't install conf and state dir on systemd
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=7665fb5d943c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-04 21:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-04 14:21 [PATCH BlueZ] Don't install conf and state dir on systemd Max Gautier
2024-03-04 15:32 ` [BlueZ] " bluez.test.bot
2024-03-04 21:00 ` [PATCH BlueZ] " patchwork-bot+bluetooth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).