* Re: [PATCH 2/12] ubifs: Do not include crypto/algapi.h
[not found] <E1qYl9s-006vDm-IW@formenos.hmeau.com>
@ 2023-08-26 6:58 ` kernel test robot
2023-08-26 8:36 ` [PATCH] KEYS: Include linux/errno.h in linux/verification.h Herbert Xu
2023-08-27 1:40 ` [PATCH 2/12] ubifs: Do not include crypto/algapi.h kernel test robot
1 sibling, 1 reply; 5+ messages in thread
From: kernel test robot @ 2023-08-26 6:58 UTC (permalink / raw
To: Herbert Xu, Linux Crypto Mailing List, Eric Biggers,
Theodore Y.Ts'o, Jaegeuk Kim, linux-fscrypt,
Richard Weinberger, linux-mtd, Marcel Holtmann, Johan Hedberg,
Luiz Augusto von Dentz, linux-bluetooth, Ilya Dryomov, Xiubo Li,
Jeff Layton, ceph-devel, Steffen Klassert, David S. Miller,
Johannes Berg, linux-wireless, Matthieu Baerts, Mat Martineau,
Chuck Lever, Neil Brown, linux-nfs, Mimi Zohar, linux-inte, grity,
Jason A.Donenfeld, Ayush Sawal
Cc: llvm, oe-kbuild-all, netdev
Hi Herbert,
kernel test robot noticed the following build errors:
[auto build test ERROR on wireless-next/main]
[also build test ERROR on wireless/main linus/master rw-ubifs/next rw-ubifs/fixes v6.5-rc7 next-20230825]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Herbert-Xu/fscrypt-Do-not-include-crypto-algapi-h/20230823-183716
base: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
patch link: https://lore.kernel.org/r/E1qYl9s-006vDm-IW%40formenos.hmeau.com
patch subject: [PATCH 2/12] ubifs: Do not include crypto/algapi.h
config: x86_64-randconfig-075-20230823 (https://download.01.org/0day-ci/archive/20230826/202308261414.HKw1Mrip-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce: (https://download.01.org/0day-ci/archive/20230826/202308261414.HKw1Mrip-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308261414.HKw1Mrip-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from fs/ubifs/auth.c:12:
>> include/linux/verification.h:23:11: error: use of undeclared identifier 'EINVAL'
return -EINVAL;
^
In file included from fs/ubifs/auth.c:18:
In file included from fs/ubifs/ubifs.h:16:
In file included from include/linux/fs.h:33:
In file included from include/linux/percpu-rwsem.h:7:
In file included from include/linux/rcuwait.h:6:
In file included from include/linux/sched/signal.h:6:
include/linux/signal.h:97:11: warning: array index 3 is past the end of the array (that has type 'unsigned long[1]') [-Warray-bounds]
return (set->sig[3] | set->sig[2] |
^ ~
arch/x86/include/asm/signal.h:24:2: note: array 'sig' declared here
unsigned long sig[_NSIG_WORDS];
^
In file included from fs/ubifs/auth.c:18:
In file included from fs/ubifs/ubifs.h:16:
In file included from include/linux/fs.h:33:
In file included from include/linux/percpu-rwsem.h:7:
In file included from include/linux/rcuwait.h:6:
In file included from include/linux/sched/signal.h:6:
include/linux/signal.h:97:25: warning: array index 2 is past the end of the array (that has type 'unsigned long[1]') [-Warray-bounds]
return (set->sig[3] | set->sig[2] |
^ ~
arch/x86/include/asm/signal.h:24:2: note: array 'sig' declared here
unsigned long sig[_NSIG_WORDS];
^
In file included from fs/ubifs/auth.c:18:
In file included from fs/ubifs/ubifs.h:16:
In file included from include/linux/fs.h:33:
In file included from include/linux/percpu-rwsem.h:7:
In file included from include/linux/rcuwait.h:6:
In file included from include/linux/sched/signal.h:6:
include/linux/signal.h:98:4: warning: array index 1 is past the end of the array (that has type 'unsigned long[1]') [-Warray-bounds]
set->sig[1] | set->sig[0]) == 0;
^ ~
arch/x86/include/asm/signal.h:24:2: note: array 'sig' declared here
unsigned long sig[_NSIG_WORDS];
^
In file included from fs/ubifs/auth.c:18:
In file included from fs/ubifs/ubifs.h:16:
In file included from include/linux/fs.h:33:
In file included from include/linux/percpu-rwsem.h:7:
In file included from include/linux/rcuwait.h:6:
In file included from include/linux/sched/signal.h:6:
include/linux/signal.h:100:11: warning: array index 1 is past the end of the array (that has type 'unsigned long[1]') [-Warray-bounds]
return (set->sig[1] | set->sig[0]) == 0;
^ ~
arch/x86/include/asm/signal.h:24:2: note: array 'sig' declared here
unsigned long sig[_NSIG_WORDS];
^
In file included from fs/ubifs/auth.c:18:
In file included from fs/ubifs/ubifs.h:16:
In file included from include/linux/fs.h:33:
In file included from include/linux/percpu-rwsem.h:7:
In file included from include/linux/rcuwait.h:6:
In file included from include/linux/sched/signal.h:6:
include/linux/signal.h:113:11: warning: array index 3 is past the end of the array (that has type 'const unsigned long[1]') [-Warray-bounds]
return (set1->sig[3] == set2->sig[3]) &&
^ ~
arch/x86/include/asm/signal.h:24:2: note: array 'sig' declared here
unsigned long sig[_NSIG_WORDS];
^
In file included from fs/ubifs/auth.c:18:
In file included from fs/ubifs/ubifs.h:16:
In file included from include/linux/fs.h:33:
In file included from include/linux/percpu-rwsem.h:7:
In file included from include/linux/rcuwait.h:6:
In file included from include/linux/sched/signal.h:6:
include/linux/signal.h:113:27: warning: array index 3 is past the end of the array (that has type 'const unsigned long[1]') [-Warray-bounds]
return (set1->sig[3] == set2->sig[3]) &&
^ ~
arch/x86/include/asm/signal.h:24:2: note: array 'sig' declared here
unsigned long sig[_NSIG_WORDS];
^
In file included from fs/ubifs/auth.c:18:
In file included from fs/ubifs/ubifs.h:16:
In file included from include/linux/fs.h:33:
In file included from include/linux/percpu-rwsem.h:7:
In file included from include/linux/rcuwait.h:6:
In file included from include/linux/sched/signal.h:6:
include/linux/signal.h:114:5: warning: array index 2 is past the end of the array (that has type 'const unsigned long[1]') [-Warray-bounds]
(set1->sig[2] == set2->sig[2]) &&
^ ~
arch/x86/include/asm/signal.h:24:2: note: array 'sig' declared here
unsigned long sig[_NSIG_WORDS];
^
In file included from fs/ubifs/auth.c:18:
In file included from fs/ubifs/ubifs.h:16:
In file included from include/linux/fs.h:33:
In file included from include/linux/percpu-rwsem.h:7:
In file included from include/linux/rcuwait.h:6:
In file included from include/linux/sched/signal.h:6:
include/linux/signal.h:114:21: warning: array index 2 is past the end of the array (that has type 'const unsigned long[1]') [-Warray-bounds]
(set1->sig[2] == set2->sig[2]) &&
^ ~
arch/x86/include/asm/signal.h:24:2: note: array 'sig' declared here
unsigned long sig[_NSIG_WORDS];
^
In file included from fs/ubifs/auth.c:18:
In file included from fs/ubifs/ubifs.h:16:
vim +/EINVAL +23 include/linux/verification.h
817aef260037f3 Yannik Sembritzki 2018-08-16 19
f3cf4134c5c6c4 Roberto Sassu 2022-09-20 20 static inline int system_keyring_id_check(u64 id)
f3cf4134c5c6c4 Roberto Sassu 2022-09-20 21 {
f3cf4134c5c6c4 Roberto Sassu 2022-09-20 22 if (id > (unsigned long)VERIFY_USE_PLATFORM_KEYRING)
f3cf4134c5c6c4 Roberto Sassu 2022-09-20 @23 return -EINVAL;
f3cf4134c5c6c4 Roberto Sassu 2022-09-20 24
f3cf4134c5c6c4 Roberto Sassu 2022-09-20 25 return 0;
f3cf4134c5c6c4 Roberto Sassu 2022-09-20 26 }
f3cf4134c5c6c4 Roberto Sassu 2022-09-20 27
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] KEYS: Include linux/errno.h in linux/verification.h
2023-08-26 6:58 ` [PATCH 2/12] ubifs: Do not include crypto/algapi.h kernel test robot
@ 2023-08-26 8:36 ` Herbert Xu
2023-08-26 9:35 ` bluez.test.bot
2023-08-28 9:33 ` [PATCH] " Daniel Borkmann
0 siblings, 2 replies; 5+ messages in thread
From: Herbert Xu @ 2023-08-26 8:36 UTC (permalink / raw
To: kernel test robot
Cc: Linux Crypto Mailing List, Eric Biggers, Theodore Y.Ts'o,
Jaegeuk Kim, linux-fscrypt, Richard Weinberger, linux-mtd,
Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz,
linux-bluetooth, Ilya Dryomov, Xiubo Li, Jeff Layton, ceph-devel,
Steffen Klassert, David S. Miller, Johannes Berg, linux-wireless,
Matthieu Baerts, Mat Martineau, Chuck Lever, Neil Brown,
linux-nfs, Mimi Zohar, linux-inte, grity, Jason A.Donenfeld,
Ayush Sawal, llvm, oe-kbuild-all, netdev, David Howells, keyrings
On Sat, Aug 26, 2023 at 02:58:48PM +0800, kernel test robot wrote:
>
> All errors (new ones prefixed by >>):
>
> In file included from fs/ubifs/auth.c:12:
> >> include/linux/verification.h:23:11: error: use of undeclared identifier 'EINVAL'
---8<---
Add inclusion of linux/errno.h as otherwise the reference to EINVAL
may be invalid.
Fixes: f3cf4134c5c6 ("bpf: Add bpf_lookup_*_key() and bpf_key_put() kfuncs")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202308261414.HKw1Mrip-lkp@intel.com/
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/include/linux/verification.h b/include/linux/verification.h
index f34e50ebcf60..cb2d47f28091 100644
--- a/include/linux/verification.h
+++ b/include/linux/verification.h
@@ -8,6 +8,7 @@
#ifndef _LINUX_VERIFICATION_H
#define _LINUX_VERIFICATION_H
+#include <linux/errno.h>
#include <linux/types.h>
/*
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: KEYS: Include linux/errno.h in linux/verification.h
2023-08-26 8:36 ` [PATCH] KEYS: Include linux/errno.h in linux/verification.h Herbert Xu
@ 2023-08-26 9:35 ` bluez.test.bot
2023-08-28 9:33 ` [PATCH] " Daniel Borkmann
1 sibling, 0 replies; 5+ messages in thread
From: bluez.test.bot @ 2023-08-26 9:35 UTC (permalink / raw
To: linux-bluetooth, herbert
[-- Attachment #1: Type: text/plain, Size: 3150 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=779564
---Test result---
Test Summary:
CheckPatch FAIL 1.18 seconds
GitLint FAIL 0.64 seconds
SubjectPrefix FAIL 0.37 seconds
BuildKernel PASS 34.28 seconds
CheckAllWarning PASS 37.34 seconds
CheckSparse PASS 42.76 seconds
CheckSmatch PASS 115.58 seconds
BuildKernel32 PASS 32.92 seconds
TestRunnerSetup PASS 501.03 seconds
TestRunner_l2cap-tester PASS 28.86 seconds
TestRunner_iso-tester PASS 51.48 seconds
TestRunner_bnep-tester PASS 11.30 seconds
TestRunner_mgmt-tester PASS 225.81 seconds
TestRunner_rfcomm-tester PASS 16.97 seconds
TestRunner_sco-tester PASS 20.59 seconds
TestRunner_ioctl-tester PASS 19.16 seconds
TestRunner_mesh-tester PASS 14.39 seconds
TestRunner_smp-tester PASS 15.43 seconds
TestRunner_userchan-tester PASS 12.02 seconds
IncrementalBuild PASS 31.39 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
KEYS: Include linux/errno.h in linux/verification.h
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#77:
> >> include/linux/verification.h:23:11: error: use of undeclared identifier 'EINVAL'
total: 0 errors, 1 warnings, 7 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13366546.patch has style problems, please review.
NOTE: Ignored message types: UNKNOWN_COMMIT_ID
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
KEYS: Include linux/errno.h in linux/verification.h
WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
6: B2 Line has trailing whitespace: "> "
8: B1 Line exceeds max length (85>80): "> >> include/linux/verification.h:23:11: error: use of undeclared identifier 'EINVAL'"
15: B1 Line exceeds max length (82>80): "Closes: https://lore.kernel.org/oe-kbuild-all/202308261414.HKw1Mrip-lkp@intel.com/"
##############################
Test: SubjectPrefix - FAIL
Desc: Check subject contains "Bluetooth" prefix
Output:
"Bluetooth: " prefix is not specified in the subject
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/12] ubifs: Do not include crypto/algapi.h
[not found] <E1qYl9s-006vDm-IW@formenos.hmeau.com>
2023-08-26 6:58 ` [PATCH 2/12] ubifs: Do not include crypto/algapi.h kernel test robot
@ 2023-08-27 1:40 ` kernel test robot
1 sibling, 0 replies; 5+ messages in thread
From: kernel test robot @ 2023-08-27 1:40 UTC (permalink / raw
To: Herbert Xu, Linux Crypto Mailing List, Eric Biggers,
Theodore Y.Ts'o, Jaegeuk Kim, linux-fscrypt,
Richard Weinberger, linux-mtd, Marcel Holtmann, Johan Hedberg,
Luiz Augusto von Dentz, linux-bluetooth, Ilya Dryomov, Xiubo Li,
Jeff Layton, ceph-devel, Steffen Klassert, David S. Miller,
Johannes Berg, linux-wireless, Matthieu Baerts, Mat Martineau,
Chuck Lever, Neil Brown, linux-nfs, Mimi Zohar, linux-inte, grity,
Jason A.Donenfeld, Ayush Sawal
Cc: oe-kbuild-all, netdev
Hi Herbert,
kernel test robot noticed the following build errors:
[auto build test ERROR on wireless-next/main]
[also build test ERROR on wireless/main linus/master rw-ubifs/next rw-ubifs/fixes v6.5-rc7 next-20230825]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Herbert-Xu/fscrypt-Do-not-include-crypto-algapi-h/20230823-183716
base: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
patch link: https://lore.kernel.org/r/E1qYl9s-006vDm-IW%40formenos.hmeau.com
patch subject: [PATCH 2/12] ubifs: Do not include crypto/algapi.h
config: x86_64-randconfig-r016-20230823 (https://download.01.org/0day-ci/archive/20230827/202308270908.Go1QPOZ7-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce: (https://download.01.org/0day-ci/archive/20230827/202308270908.Go1QPOZ7-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308270908.Go1QPOZ7-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from fs/ubifs/auth.c:12:0:
include/linux/verification.h: In function 'system_keyring_id_check':
>> include/linux/verification.h:23:11: error: 'EINVAL' undeclared (first use in this function)
return -EINVAL;
^~~~~~
include/linux/verification.h:23:11: note: each undeclared identifier is reported only once for each function it appears in
vim +/EINVAL +23 include/linux/verification.h
817aef260037f3 Yannik Sembritzki 2018-08-16 19
f3cf4134c5c6c4 Roberto Sassu 2022-09-20 20 static inline int system_keyring_id_check(u64 id)
f3cf4134c5c6c4 Roberto Sassu 2022-09-20 21 {
f3cf4134c5c6c4 Roberto Sassu 2022-09-20 22 if (id > (unsigned long)VERIFY_USE_PLATFORM_KEYRING)
f3cf4134c5c6c4 Roberto Sassu 2022-09-20 @23 return -EINVAL;
f3cf4134c5c6c4 Roberto Sassu 2022-09-20 24
f3cf4134c5c6c4 Roberto Sassu 2022-09-20 25 return 0;
f3cf4134c5c6c4 Roberto Sassu 2022-09-20 26 }
f3cf4134c5c6c4 Roberto Sassu 2022-09-20 27
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] KEYS: Include linux/errno.h in linux/verification.h
2023-08-26 8:36 ` [PATCH] KEYS: Include linux/errno.h in linux/verification.h Herbert Xu
2023-08-26 9:35 ` bluez.test.bot
@ 2023-08-28 9:33 ` Daniel Borkmann
1 sibling, 0 replies; 5+ messages in thread
From: Daniel Borkmann @ 2023-08-28 9:33 UTC (permalink / raw
To: Herbert Xu, kernel test robot
Cc: Linux Crypto Mailing List, Eric Biggers, Theodore Y.Ts'o,
Jaegeuk Kim, linux-fscrypt, Richard Weinberger, linux-mtd,
Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz,
linux-bluetooth, Ilya Dryomov, Xiubo Li, Jeff Layton, ceph-devel,
Steffen Klassert, David S. Miller, Johannes Berg, linux-wireless,
Matthieu Baerts, Mat Martineau, Chuck Lever, Neil Brown,
linux-nfs, Mimi Zohar, linux-inte, grity, Jason A.Donenfeld,
Ayush Sawal, llvm, oe-kbuild-all, netdev, David Howells, keyrings
Hi Herbert,
On 8/26/23 10:36 AM, Herbert Xu wrote:
> On Sat, Aug 26, 2023 at 02:58:48PM +0800, kernel test robot wrote:
>>
>> All errors (new ones prefixed by >>):
>>
>> In file included from fs/ubifs/auth.c:12:
>>>> include/linux/verification.h:23:11: error: use of undeclared identifier 'EINVAL'
>
> ---8<---
> Add inclusion of linux/errno.h as otherwise the reference to EINVAL
> may be invalid.
>
> Fixes: f3cf4134c5c6 ("bpf: Add bpf_lookup_*_key() and bpf_key_put() kfuncs")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202308261414.HKw1Mrip-lkp@intel.com/
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> diff --git a/include/linux/verification.h b/include/linux/verification.h
> index f34e50ebcf60..cb2d47f28091 100644
> --- a/include/linux/verification.h
> +++ b/include/linux/verification.h
> @@ -8,6 +8,7 @@
> #ifndef _LINUX_VERIFICATION_H
> #define _LINUX_VERIFICATION_H
>
> +#include <linux/errno.h>
> #include <linux/types.h>
>
> /*
>
Looks good, do you plan to route this fix to Linus?
Thanks,
Daniel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-08-28 9:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1qYl9s-006vDm-IW@formenos.hmeau.com>
2023-08-26 6:58 ` [PATCH 2/12] ubifs: Do not include crypto/algapi.h kernel test robot
2023-08-26 8:36 ` [PATCH] KEYS: Include linux/errno.h in linux/verification.h Herbert Xu
2023-08-26 9:35 ` bluez.test.bot
2023-08-28 9:33 ` [PATCH] " Daniel Borkmann
2023-08-27 1:40 ` [PATCH 2/12] ubifs: Do not include crypto/algapi.h kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).