From: Wren Turkal <wt@penguintechs.org>
To: Zijun Hu <quic_zijuhu@quicinc.com>, linux-bluetooth@vger.kernel.org
Cc: luiz.dentz@gmail.com, luiz.von.dentz@intel.com,
marcel@holtmann.org, linux-bluetooth@vger.kernel.org,
bartosz.golaszewski@linaro.org, krzysztof.kozlowski@linaro.org,
regressions@lists.linux.dev, kernel@quicinc.com,
stable@vge.kernel.org, Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v7 2/2] Bluetooth: qca: Fix BT enable failure for QCA6390 after disable then warm reboot
Date: Fri, 26 Apr 2024 13:42:33 -0700 [thread overview]
Message-ID: <5600892.rdbgypaU67@braindead.localdomain> (raw)
In-Reply-To: <2024042330-boat-launch-aaec@gregkh>
On Tuesday, April 23, 2024 9:34:43 PM PDT Greg KH wrote:
> On Wed, Apr 24, 2024 at 12:26:47PM +0800, Zijun Hu wrote:
> > From: Zijun Hu <zijuhu@qti.qualcomm.com>
> >
> > Commit 272970be3dab ("Bluetooth: hci_qca: Fix driver shutdown on closed
> > serdev") will cause below regression issue:
> >
> > BT can't be enabled after below steps:
> > cold boot -> enable BT -> disable BT -> warm reboot -> BT enable failure
> > if property enable-gpios is not configured within DT|ACPI for QCA6390.
> >
> > The commit is to fix a use-after-free issue within qca_serdev_shutdown()
> > during reboot, but also introduces this regression issue regarding above
> > steps since the VSC is not sent to reset controller during warm reboot.
> >
> > Fixed by sending the VSC to reset controller within qca_serdev_shutdown()
> > once BT was ever enabled, and the use-after-free issue is also be fixed
> > by this change since serdev is still opened when send to serdev.
> >
> > Fixes: 272970be3dab ("Bluetooth: hci_qca: Fix driver shutdown on closed
> > serdev") Cc: stable@vge.kernel.org
>
> That is not a valid email address :(
@ziljun, can you please post this patch in a new patch series by itself? The
warm boot problem is fixed by this patch, and I think it would be better to
have a thread dedicated to this fix so that it doesn't get lost.
FWIW, I think that this may be the correct technical change. I would like to
try to help get this patch landed, and I think a clean thread for only this
change would help.
Just so everyone is aware, I am a concerned user of the hardware, and not a
kernel dev myself. I have tested this change. This patch on top of Linus'
mainline does allow qca6390 to work after warm reboot on my laptop.
wt
--
You're more amazing than you think!
prev parent reply other threads:[~2024-04-26 20:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 4:26 [PATCH v7 0/2] Fix two BT regression issues for QCA6390 Zijun Hu
2024-04-24 4:26 ` [PATCH v7 1/2] Bluetooth: qca: Fix BT enable failure " Zijun Hu
2024-04-24 4:30 ` Krzysztof Kozlowski
2024-04-24 5:02 ` quic_zijuhu
2024-04-24 5:05 ` quic_zijuhu
2024-04-24 5:37 ` Wren Turkal
2024-04-24 5:46 ` quic_zijuhu
2024-04-24 5:49 ` Wren Turkal
2024-04-24 6:01 ` quic_zijuhu
2024-04-24 9:39 ` quic_zijuhu
2024-04-24 9:48 ` Krzysztof Kozlowski
2024-04-24 9:54 ` quic_zijuhu
2024-04-24 10:34 ` Bartosz Golaszewski
2024-04-24 11:35 ` quic_zijuhu
2024-04-24 4:56 ` Fix two BT regression issues " bluez.test.bot
2024-04-24 4:26 ` [PATCH v7 2/2] Bluetooth: qca: Fix BT enable failure for QCA6390 after disable then warm reboot Zijun Hu
2024-04-24 4:34 ` Greg KH
2024-04-26 20:42 ` Wren Turkal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5600892.rdbgypaU67@braindead.localdomain \
--to=wt@penguintechs.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@quicinc.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=luiz.von.dentz@intel.com \
--cc=marcel@holtmann.org \
--cc=quic_zijuhu@quicinc.com \
--cc=regressions@lists.linux.dev \
--cc=stable@vge.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).