* [PATCH v2] Bluetooth: Populate hci_set_hw_info for Intel and Realtek
@ 2024-04-22 9:20 Archie Pusaka
2024-04-22 9:57 ` [v2] " bluez.test.bot
2024-04-24 14:20 ` [PATCH v2] " patchwork-bot+bluetooth
0 siblings, 2 replies; 3+ messages in thread
From: Archie Pusaka @ 2024-04-22 9:20 UTC (permalink / raw
To: linux-bluetooth, Luiz Augusto von Dentz, Johan Hedberg,
Marcel Holtmann
Cc: CrosBT Upstreaming, Archie Pusaka, Abhishek Pandit-Subedi,
linux-kernel
From: Archie Pusaka <apusaka@chromium.org>
The hardware information surfaced via debugfs might be usable by the
userspace to set some configuration knobs. This patch sets the hw_info
for Intel and Realtek chipsets.
Below are some possible output of the hardware_info debugfs file.
INTEL platform=55 variant=24
RTL lmp_subver=34898 hci_rev=10 hci_ver=11 hci_bus=1
Signed-off-by: Archie Pusaka <apusaka@chromium.org>
Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@google.com>
---
Changes in v2:
* Add some sample output to the commit message
drivers/bluetooth/btintel.c | 9 +++++++++
drivers/bluetooth/btrtl.c | 7 +++++++
2 files changed, 16 insertions(+)
diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
index a19ebe47bd951..dc48352166a52 100644
--- a/drivers/bluetooth/btintel.c
+++ b/drivers/bluetooth/btintel.c
@@ -2956,6 +2956,11 @@ static int btintel_setup_combined(struct hci_dev *hdev)
err = -EINVAL;
}
+ hci_set_hw_info(hdev,
+ "INTEL platform=%u variant=%u revision=%u",
+ ver.hw_platform, ver.hw_variant,
+ ver.hw_revision);
+
goto exit_error;
}
@@ -3060,6 +3065,10 @@ static int btintel_setup_combined(struct hci_dev *hdev)
break;
}
+ hci_set_hw_info(hdev, "INTEL platform=%u variant=%u",
+ INTEL_HW_PLATFORM(ver_tlv.cnvi_bt),
+ INTEL_HW_VARIANT(ver_tlv.cnvi_bt));
+
exit_error:
kfree_skb(skb);
diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
index cc50de69e8dc9..4f1e37b4f7802 100644
--- a/drivers/bluetooth/btrtl.c
+++ b/drivers/bluetooth/btrtl.c
@@ -1339,6 +1339,13 @@ int btrtl_setup_realtek(struct hci_dev *hdev)
btrtl_set_quirks(hdev, btrtl_dev);
+ hci_set_hw_info(hdev,
+ "RTL lmp_subver=%u hci_rev=%u hci_ver=%u hci_bus=%u",
+ btrtl_dev->ic_info->lmp_subver,
+ btrtl_dev->ic_info->hci_rev,
+ btrtl_dev->ic_info->hci_ver,
+ btrtl_dev->ic_info->hci_bus);
+
btrtl_free(btrtl_dev);
return ret;
}
--
2.44.0.769.g3c40516874-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [v2] Bluetooth: Populate hci_set_hw_info for Intel and Realtek
2024-04-22 9:20 [PATCH v2] Bluetooth: Populate hci_set_hw_info for Intel and Realtek Archie Pusaka
@ 2024-04-22 9:57 ` bluez.test.bot
2024-04-24 14:20 ` [PATCH v2] " patchwork-bot+bluetooth
1 sibling, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2024-04-22 9:57 UTC (permalink / raw
To: linux-bluetooth, apusaka
[-- Attachment #1: Type: text/plain, Size: 2578 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=846581
---Test result---
Test Summary:
CheckPatch PASS 0.64 seconds
GitLint PASS 0.18 seconds
SubjectPrefix PASS 0.05 seconds
BuildKernel PASS 29.68 seconds
CheckAllWarning PASS 31.98 seconds
CheckSparse PASS 37.79 seconds
CheckSmatch FAIL 34.43 seconds
BuildKernel32 PASS 28.31 seconds
TestRunnerSetup PASS 511.93 seconds
TestRunner_l2cap-tester PASS 18.17 seconds
TestRunner_iso-tester FAIL 30.49 seconds
TestRunner_bnep-tester PASS 4.58 seconds
TestRunner_mgmt-tester PASS 106.96 seconds
TestRunner_rfcomm-tester PASS 7.09 seconds
TestRunner_sco-tester PASS 14.83 seconds
TestRunner_ioctl-tester PASS 7.44 seconds
TestRunner_mesh-tester PASS 5.61 seconds
TestRunner_smp-tester PASS 6.52 seconds
TestRunner_userchan-tester PASS 4.77 seconds
IncrementalBuild PASS 27.26 seconds
Details
##############################
Test: CheckSmatch - FAIL
Desc: Run smatch tool with source
Output:
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: net/bluetooth/hci_core.o] Error 139
make[4]: *** Deleting file 'net/bluetooth/hci_core.o'
make[3]: *** [scripts/Makefile.build:485: net/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: net] Error 2
make[2]: *** Waiting for unfinished jobs....
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bcm203x.o] Error 139
make[4]: *** Deleting file 'drivers/bluetooth/bcm203x.o'
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [scripts/Makefile.build:485: drivers/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: drivers] Error 2
make[1]: *** [/github/workspace/src/src/Makefile:1919: .] Error 2
make: *** [Makefile:240: __sub-make] Error 2
##############################
Test: TestRunner_iso-tester - FAIL
Desc: Run iso-tester with test-runner
Output:
Total: 122, Passed: 121 (99.2%), Failed: 1, Not Run: 0
Failed Test Cases
ISO Connect2 Suspend - Success Failed 4.217 seconds
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] Bluetooth: Populate hci_set_hw_info for Intel and Realtek
2024-04-22 9:20 [PATCH v2] Bluetooth: Populate hci_set_hw_info for Intel and Realtek Archie Pusaka
2024-04-22 9:57 ` [v2] " bluez.test.bot
@ 2024-04-24 14:20 ` patchwork-bot+bluetooth
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+bluetooth @ 2024-04-24 14:20 UTC (permalink / raw
To: Archie Pusaka
Cc: linux-bluetooth, luiz.dentz, johan.hedberg, marcel,
chromeos-bluetooth-upstreaming, apusaka, abhishekpandit,
linux-kernel
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
On Mon, 22 Apr 2024 17:20:28 +0800 you wrote:
> From: Archie Pusaka <apusaka@chromium.org>
>
> The hardware information surfaced via debugfs might be usable by the
> userspace to set some configuration knobs. This patch sets the hw_info
> for Intel and Realtek chipsets.
>
> Below are some possible output of the hardware_info debugfs file.
> INTEL platform=55 variant=24
> RTL lmp_subver=34898 hci_rev=10 hci_ver=11 hci_bus=1
>
> [...]
Here is the summary with links:
- [v2] Bluetooth: Populate hci_set_hw_info for Intel and Realtek
https://git.kernel.org/bluetooth/bluetooth-next/c/46d8da86787b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-24 14:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-22 9:20 [PATCH v2] Bluetooth: Populate hci_set_hw_info for Intel and Realtek Archie Pusaka
2024-04-22 9:57 ` [v2] " bluez.test.bot
2024-04-24 14:20 ` [PATCH v2] " patchwork-bot+bluetooth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).