* [PATCH -next] Bluetooth: hci_bcm4377: Fix missing pci_disable_device() on error in bcm4377_probe()
@ 2022-11-12 9:04 Yang Yingliang
2022-11-12 9:47 ` [-next] " bluez.test.bot
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Yang Yingliang @ 2022-11-12 9:04 UTC (permalink / raw
To: linux-bluetooth; +Cc: sven, luiz.von.dentz, yangyingliang
pci_disable_device() need be called while module exiting, switch to use
pcim_enable(), pci_disable_device() will be called in pcim_release()
after probe() failure.
Fixes: ab80b2cec05f ("Bluetooth: hci_bcm4377: Add new driver for BCM4377 PCIe boards")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/bluetooth/hci_bcm4377.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bluetooth/hci_bcm4377.c b/drivers/bluetooth/hci_bcm4377.c
index 74f44562ac33..19ad0e788646 100644
--- a/drivers/bluetooth/hci_bcm4377.c
+++ b/drivers/bluetooth/hci_bcm4377.c
@@ -2306,7 +2306,7 @@ static int bcm4377_probe(struct pci_dev *pdev, const struct pci_device_id *id)
*/
msleep(100);
- ret = pci_enable_device(pdev);
+ ret = pcim_enable_device(pdev);
if (ret)
return ret;
pci_set_master(pdev);
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [-next] Bluetooth: hci_bcm4377: Fix missing pci_disable_device() on error in bcm4377_probe()
2022-11-12 9:04 [PATCH -next] Bluetooth: hci_bcm4377: Fix missing pci_disable_device() on error in bcm4377_probe() Yang Yingliang
@ 2022-11-12 9:47 ` bluez.test.bot
2022-11-12 10:28 ` [PATCH -next] " Sven Peter
2022-11-14 22:10 ` patchwork-bot+bluetooth
2 siblings, 0 replies; 4+ messages in thread
From: bluez.test.bot @ 2022-11-12 9:47 UTC (permalink / raw
To: linux-bluetooth, yangyingliang
[-- Attachment #1: Type: text/plain, Size: 510 bytes --]
This is an automated email and please do not reply to this email.
Dear Submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository.
----- Output -----
error: drivers/bluetooth/hci_bcm4377.c: does not exist in index
hint: Use 'git am --show-current-patch' to see the failed patch
Please resolve the issue and submit the patches again.
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] Bluetooth: hci_bcm4377: Fix missing pci_disable_device() on error in bcm4377_probe()
2022-11-12 9:04 [PATCH -next] Bluetooth: hci_bcm4377: Fix missing pci_disable_device() on error in bcm4377_probe() Yang Yingliang
2022-11-12 9:47 ` [-next] " bluez.test.bot
@ 2022-11-12 10:28 ` Sven Peter
2022-11-14 22:10 ` patchwork-bot+bluetooth
2 siblings, 0 replies; 4+ messages in thread
From: Sven Peter @ 2022-11-12 10:28 UTC (permalink / raw
To: Yang Yingliang, linux-bluetooth; +Cc: luiz.von.dentz
Hi,
On Sat, Nov 12, 2022, at 10:04, Yang Yingliang wrote:
> pci_disable_device() need be called while module exiting, switch to use
> pcim_enable(), pci_disable_device() will be called in pcim_release()
> after probe() failure.
>
> Fixes: ab80b2cec05f ("Bluetooth: hci_bcm4377: Add new driver for
> BCM4377 PCIe boards")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
Good catch, thanks!
Reviewed-by: Sven Peter <sven@svenpeter.dev>
Best,
Sven
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] Bluetooth: hci_bcm4377: Fix missing pci_disable_device() on error in bcm4377_probe()
2022-11-12 9:04 [PATCH -next] Bluetooth: hci_bcm4377: Fix missing pci_disable_device() on error in bcm4377_probe() Yang Yingliang
2022-11-12 9:47 ` [-next] " bluez.test.bot
2022-11-12 10:28 ` [PATCH -next] " Sven Peter
@ 2022-11-14 22:10 ` patchwork-bot+bluetooth
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+bluetooth @ 2022-11-14 22:10 UTC (permalink / raw
To: Yang Yingliang; +Cc: linux-bluetooth, sven, luiz.von.dentz
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
On Sat, 12 Nov 2022 17:04:37 +0800 you wrote:
> pci_disable_device() need be called while module exiting, switch to use
> pcim_enable(), pci_disable_device() will be called in pcim_release()
> after probe() failure.
>
> Fixes: ab80b2cec05f ("Bluetooth: hci_bcm4377: Add new driver for BCM4377 PCIe boards")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>
> [...]
Here is the summary with links:
- [-next] Bluetooth: hci_bcm4377: Fix missing pci_disable_device() on error in bcm4377_probe()
https://git.kernel.org/bluetooth/bluetooth-next/c/ba174481be42
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-14 22:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-12 9:04 [PATCH -next] Bluetooth: hci_bcm4377: Fix missing pci_disable_device() on error in bcm4377_probe() Yang Yingliang
2022-11-12 9:47 ` [-next] " bluez.test.bot
2022-11-12 10:28 ` [PATCH -next] " Sven Peter
2022-11-14 22:10 ` patchwork-bot+bluetooth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).