From: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Changhui Zhong <czhong@redhat.com>
Subject: Re: [PATCH] block/035: add test to cover blk-cgroup vs. disk rebind
Date: Thu, 18 Apr 2024 06:50:22 +0000 [thread overview]
Message-ID: <ybhcglijxfwwvd5bnz3zhbgmkgyqoepknvptatxg3l6bqeuaxx@at62eb5lmqmu> (raw)
In-Reply-To: <xskkrvbacbubmcbc2tamt5aa7hepvt37y6kl7mz2lqvgswumb5@6hqkngrepouo>
On Apr 09, 2024 / 00:56, Shinichiro Kawasaki wrote:
> On Apr 07, 2024 / 20:57, Ming Lei wrote:
> > Recently it is observed that list corruption is triggered when running
> > scsi disk rebind in case of blk-cgroup.
> >
> > Add one such test case for covering this unusual operation.
> >
> > Cc: Changhui Zhong <czhong@redhat.com>
> > Signed-off-by: Ming Lei <ming.lei@redhat.com>
>
> Thanks for the patch. Overall it looks good to me. I confirmed that this test
> case causes the system hang with v6.9-rc2 kernel and your fix patch [1] avoids
> it.
>
> [1] https://lore.kernel.org/linux-block/20240407125910.4053377-1-ming.lei@redhat.com/
>
> As I commented in line, I will do an edit when I apply this patch. No need to
> respin this patch unless someone makes other comments.
>
> Before I apply this patch, I will wait until the kernel side fix gets
> upstreamed and then downstreamed to the stable kernels, so that blktests users
> won't be upset with the hang. Until then, I expect other new test cases will get
> the test case number block/035. In that case, I will modify this test case
> number to block/036 or 037.
The kernel side fix landed on v6.9-rc4, v6.8.7 and v6.6.28. I have applied this
blktests patch along with the edits I mentioned. The test case number was
modified from block/035 to block/037. Thanks!
prev parent reply other threads:[~2024-04-18 6:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-07 12:57 [PATCH] block/035: add test to cover blk-cgroup vs. disk rebind Ming Lei
2024-04-09 0:56 ` Shinichiro Kawasaki
2024-04-18 6:50 ` Shinichiro Kawasaki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ybhcglijxfwwvd5bnz3zhbgmkgyqoepknvptatxg3l6bqeuaxx@at62eb5lmqmu \
--to=shinichiro.kawasaki@wdc.com \
--cc=czhong@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).