From: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: Daniel Wagner <dwagner@suse.de>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH blktests v2 00/18] refactoring and various cleanups/fixes
Date: Tue, 16 Apr 2024 04:56:00 +0000 [thread overview]
Message-ID: <tot7ywuqv2iwfu4wdkjoux55et4j7imu2yruq3qf54rb6fndyj@kfuqvhn2v3ab> (raw)
In-Reply-To: <c189008d-b07f-4930-86df-4059ef4750d6@nvidia.com>
On Apr 16, 2024 / 02:50, Chaitanya Kulkarni wrote:
> On 3/22/24 06:49, Daniel Wagner wrote:
> > Updated the series to include all the feedback from Shinichiro.
> >
> > changes:
> > v2:
> > - addressed 'make check' errors
> > - squashed 'nvme/rc: remove correct port from target'
> > into 'nvme/rc: add nqn/uuid args to target setup/cleanup helper'
> > - reordered patches
> > - added 'nvme: drop default trtype argument for _nvmet_passthru_target_connect'
> >
> > v1:
> > -https://lore.kernel.org/linux-nvme/20240321094727.6503-1-dwagner@suse.de/
>
> overall it looks good to me, I'll wait for V3 to provide review
> since Shinichiro has some comments on this one ...
It's good to know that this series is okay for you. Actually, the v3 was posted
on Mar/26, and I applied the series on Mar/29 [1]. So, it's done.
[1] https://lore.kernel.org/linux-block/6foqfrw4amrpqoaiov6tyr7dhlnlm5tpeb6unfxpbrvsc6zals@lcbxl7pljbso/
prev parent reply other threads:[~2024-04-16 4:57 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 13:49 [PATCH blktests v2 00/18] refactoring and various cleanups/fixes Daniel Wagner
2024-03-22 13:49 ` [PATCH blktests v2 01/18] nvme/rc: silence error on module unload for fc Daniel Wagner
2024-03-22 13:49 ` [PATCH blktests v2 02/18] nvme/rc: silence fcloop cleanup failures Daniel Wagner
2024-03-25 18:27 ` Daniel Wagner
2024-03-26 8:39 ` Shinichiro Kawasaki
2024-03-26 9:23 ` Daniel Wagner
2024-03-22 13:50 ` [PATCH blktests v2 03/18] nvme/rc: log error if stale configuration is found Daniel Wagner
2024-03-22 13:50 ` [PATCH blktests v2 04/18] common/xfs: propagate errors from _xfs_run_fio_verify_io Daniel Wagner
2024-03-22 13:50 ` [PATCH blktests v2 05/18] nvme/{012,013,035}: check return value of _xfs_run_fio_verify_io Daniel Wagner
2024-03-22 13:50 ` [PATCH blktests v2 06/18] nvme/rc: use long command line option for nvme Daniel Wagner
2024-03-22 13:50 ` [PATCH blktests v2 07/18] nvme/{014,015,018,019,020,023,024,026,045,046}: " Daniel Wagner
2024-03-22 13:50 ` [PATCH blktests v2 08/18] nvme/rc: connect subsys only support long options Daniel Wagner
2024-03-22 13:50 ` [PATCH blktests v2 09/18] nvme/rc: add nqn/uuid args to target setup/cleanup helper Daniel Wagner
2024-03-22 13:50 ` [PATCH blktests v2 10/18] nvme/rc: remove unused connect options Daniel Wagner
2024-03-22 13:50 ` [PATCH blktests v2 11/18] nvme/rc: do not cleanup external managed loop device Daniel Wagner
2024-03-22 13:50 ` [PATCH blktests v2 12/18] nvme/031: do not open code target setup/cleanup Daniel Wagner
2024-03-22 13:50 ` [PATCH blktests v2 13/18] nvme: drop default trtype argument for _nvmet_connect_subsys Daniel Wagner
2024-03-22 13:50 ` [PATCH blktests v2 14/18] nvme: drop default trtype argument for _nvmet_passthru_target_connect Daniel Wagner
2024-03-22 13:50 ` [PATCH blktests v2 15/18] nvme: drop default subsysnqn argument from _nvme_{connect|disconnect}_subsys Daniel Wagner
2024-03-26 8:47 ` Shinichiro Kawasaki
2024-03-22 13:50 ` [PATCH blktests v2 16/18] nvme/{041,042,043,044,045,048}: do not pass default host{nqn|id} to _nvme_connect_subsys Daniel Wagner
2024-03-22 13:50 ` [PATCH blktests v2 17/18] nvme: don't assume namespace id Daniel Wagner
2024-03-22 13:50 ` [PATCH blktests v2 18/18] nvme/028: drop unused nvmedev Daniel Wagner
2024-04-16 2:50 ` [PATCH blktests v2 00/18] refactoring and various cleanups/fixes Chaitanya Kulkarni
2024-04-16 4:56 ` Shinichiro Kawasaki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tot7ywuqv2iwfu4wdkjoux55et4j7imu2yruq3qf54rb6fndyj@kfuqvhn2v3ab \
--to=shinichiro.kawasaki@wdc.com \
--cc=chaitanyak@nvidia.com \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).