Linux-Block Archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Uday Shankar <ushankar@purestorage.com>
Cc: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org,
	Riley Thomasson <riley@purestorage.com>
Subject: Re: [PATCH] ublk: remove segment count and size limits
Date: Tue, 30 Apr 2024 05:59:29 -0700	[thread overview]
Message-ID: <ZjDrMWRV1m34x_pa@infradead.org> (raw)
In-Reply-To: <20240430005330.2786014-1-ushankar@purestorage.com>

On Mon, Apr 29, 2024 at 06:53:31PM -0600, Uday Shankar wrote:
> +	lim.max_segments = USHRT_MAX;
> +	lim.max_segment_size = UINT_MAX;

Please initialize thes at the top of the function as part of the
declaration for lim, like all the other unconditional limits.


      parent reply	other threads:[~2024-04-30 12:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-30  0:53 [PATCH] ublk: remove segment count and size limits Uday Shankar
2024-04-30  9:15 ` Ming Lei
2024-04-30 12:59 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZjDrMWRV1m34x_pa@infradead.org \
    --to=hch@infradead.org \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=riley@purestorage.com \
    --cc=ushankar@purestorage.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).