From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>, io-uring@vger.kernel.org
Cc: linux-block@vger.kernel.org,
Pavel Begunkov <asml.silence@gmail.com>,
Kevin Wolf <kwolf@redhat.com>
Subject: Re: [RFC PATCH V2 0/9] io_uring: support sqe group and provide group kbuf
Date: Fri, 10 May 2024 22:02:12 +0800 [thread overview]
Message-ID: <Zj4o5LjuLo6fGeDd@fedora> (raw)
In-Reply-To: <20240506162251.3853781-1-ming.lei@redhat.com>
On Tue, May 07, 2024 at 12:22:36AM +0800, Ming Lei wrote:
> Hello,
>
> The 1st 4 patches are cleanup, and prepare for adding sqe group.
>
> The 5th patch supports generic sqe group which is like link chain, but
> allows each sqe in group to be issued in parallel, so N:M dependency can be
> supported with sqe group & io link together.
>
> The 6th patch supports one variant of sqe group: allow members to depend
> on group leader, so that kernel resource lifetime can be aligned with
> group leader or group, then any kernel resource can be shared in this
> sqe group, and can be used in generic device zero copy.
>
> The 7th & 8th patches supports providing sqe group buffer via the sqe
> group variant.
>
> The 9th patch supports ublk zero copy based on io_uring providing sqe
> group buffer.
>
> Tests:
>
> 1) pass liburing test
> - make runtests
>
> 2) write/pass two sqe group test cases:
>
> https://github.com/axboe/liburing/compare/master...ming1:liburing:sqe_group_v2
>
> covers related sqe flags combination and linking groups, both nop and
> one multi-destination file copy.
>
> 3) ublksrv zero copy:
>
> ublksrv userspace implements zero copy by sqe group & provide group
> kbuf:
>
> git clone https://github.com/ublk-org/ublksrv.git -b group-provide-buf_v2
> make test T=loop/009:nbd/061:nbd/062 #ublk zc tests
>
> When running 64KB block size test on ublk-loop('ublk add -t loop --buffered_io -f $backing'),
> it is observed that perf can be doubled.
>
> Any comments are welcome!
>
> V2:
> - add generic sqe group, suggested by Kevin Wolf
> - add REQ_F_SQE_GROUP_DEP which is based on IOSQE_SQE_GROUP, for sharing
> kernel resource in group wide, suggested by Kevin Wolf
> - remove sqe ext flag, and use the last bit for IOSQE_SQE_GROUP(Pavel),
> in future we still can extend sqe flags with one uring context flag
> - initialize group requests via submit state pattern, suggested by Pavel
> - all kinds of cleanup & bug fixes
Please ignore V2, and will send V3 with simplification & cleanup, and
many fixes on error handling code path.
Thanks,
Ming
prev parent reply other threads:[~2024-05-10 14:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 16:22 [RFC PATCH V2 0/9] io_uring: support sqe group and provide group kbuf Ming Lei
2024-05-06 16:22 ` [RFC PATCH V2 1/9] io_uring: add io_link_req() helper Ming Lei
2024-05-06 16:22 ` [RFC PATCH V2 2/9] io_uring: add io_submit_fail_link() helper Ming Lei
2024-05-06 16:22 ` [RFC PATCH V2 3/9] io_uring: add helper of io_req_commit_cqe() Ming Lei
2024-05-06 16:22 ` [RFC PATCH V2 4/9] io_uring: move marking REQ_F_CQE_SKIP out of io_free_req() Ming Lei
2024-05-06 16:22 ` [RFC PATCH V2 5/9] io_uring: support SQE group Ming Lei
2024-05-06 16:22 ` [RFC PATCH V2 6/9] io_uring: support sqe group with members depending on leader Ming Lei
2024-05-06 16:22 ` [RFC PATCH V2 7/9] io_uring: support providing sqe group buffer Ming Lei
2024-05-06 16:22 ` [RFC PATCH V2 8/9] io_uring/uring_cmd: support provide group kernel buffer Ming Lei
2024-05-06 16:22 ` [RFC PATCH V2 9/9] ublk: support provide io buffer Ming Lei
2024-05-10 14:02 ` Ming Lei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zj4o5LjuLo6fGeDd@fedora \
--to=ming.lei@redhat.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).