From: Tejun Heo <tj@kernel.org>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: axboe@kernel.dk, chenhuacai@kernel.org, josef@toxicpanda.com,
jhs@mojatatu.com, svenjoac@gmx.de, raven@themaw.net,
pctammela@mojatatu.com, qde@naccy.de, zhaotianrui@loongson.cn,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
loongarch@lists.linux.dev, cgroups@vger.kernel.org,
yi.zhang@huawei.com, yangerkun@huawei.com,
"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH RFC v2 5/6] blk-throttle: support to destroy throtl_data when blk-throttle is disabled
Date: Wed, 17 Apr 2024 16:05:14 -1000 [thread overview]
Message-ID: <ZiB_2ryBOxq2_IyG@slm.duckdns.org> (raw)
In-Reply-To: <1ed63126-d2e6-f0b6-42ef-127ecb464955@huaweicloud.com>
Hello,
On Wed, Apr 17, 2024 at 09:39:43AM +0800, Yu Kuai wrote:
...
> I guess I'll do lazy init first, and then modularization for rq_qos,
> and leave blk-throtl there for now. Perhaps add a new throtl model in
> iocost can replace blk-throtl in the future.
That sounds like a plan.
> BTW, currently during test of iocost, I found that iocost can already
> achieve that, for example, by following configure:
>
> echo "$dev enable=1 min=100 max=100" > qos
> echo "$dev wbps=4096 wseqiops=1 wrandiops=1" > model
>
> In the test, I found that wbps and iops is actually limited to the
> set value.
Yeah, it shouldn't be too difficult to add .max support to iocost so that
you can say something like "this cgroup subtree can't use more than 60% of
available capacity". That'd be really cool to have.
Thanks.
--
tejun
next prev parent reply other threads:[~2024-04-18 2:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-06 8:00 [PATCH RFC v2 0/6] blk-throttle: support enable and disable during runtime Yu Kuai
2024-04-06 8:00 ` [PATCH RFC v2 1/6] blk-throttle: remove CONFIG_BLK_DEV_THROTTLING_LOW Yu Kuai
2024-04-12 17:30 ` Tejun Heo
2024-04-13 1:57 ` Yu Kuai
2024-04-16 15:47 ` Michal Koutný
2024-04-06 8:00 ` [PATCH RFC v2 2/6] blk-throttle: delay initialization until configuration Yu Kuai
2024-04-12 17:59 ` Tejun Heo
2024-04-13 1:59 ` Yu Kuai
2024-04-16 2:11 ` Yu Kuai
2024-04-16 3:05 ` Chaitanya Kulkarni
2024-04-06 8:00 ` [PATCH RFC v2 3/6] blk-throttle: expand tg_conf_updated() to return if any tg has rules Yu Kuai
2024-04-06 8:00 ` [PATCH RFC v2 4/6] blk-cgroup: add a new helper blkg_conf_exit_blkg() Yu Kuai
2024-04-06 8:00 ` [PATCH RFC v2 5/6] blk-throttle: support to destroy throtl_data when blk-throttle is disabled Yu Kuai
2024-04-12 18:05 ` Tejun Heo
2024-04-13 2:06 ` Yu Kuai
2024-04-16 17:09 ` Tejun Heo
2024-04-17 1:13 ` Yu Kuai
2024-04-17 1:22 ` Tejun Heo
2024-04-17 1:39 ` Yu Kuai
2024-04-18 2:05 ` Tejun Heo [this message]
2024-04-06 8:00 ` [PATCH RFC v2 6/6] blk-throtl: switch to use rq_qos Yu Kuai
2024-04-12 18:11 ` Tejun Heo
2024-04-13 2:17 ` Yu Kuai
2024-04-16 14:17 ` Yu Kuai
2024-04-16 17:14 ` Tejun Heo
2024-04-16 15:56 ` [PATCH RFC v2 0/6] blk-throttle: support enable and disable during runtime Michal Koutný
2024-04-17 1:09 ` Yu Kuai
2024-04-17 10:25 ` Michal Koutný
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZiB_2ryBOxq2_IyG@slm.duckdns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=chenhuacai@kernel.org \
--cc=jhs@mojatatu.com \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=pctammela@mojatatu.com \
--cc=qde@naccy.de \
--cc=raven@themaw.net \
--cc=svenjoac@gmx.de \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
--cc=zhaotianrui@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).