From: Saranya Muruganandam <saranyamohan@google.com>
To: linux-block@vger.kernel.org, hch@lst.de,
Jens Axboe <axboe@kernel.dk>,
sashal@kernel.org, Ming Lei <ming.lei@redhat.com>
Subject: regression on BLKRRPART ioctl for EIO
Date: Tue, 6 Feb 2024 20:28:01 -0800 [thread overview]
Message-ID: <CAP9s-SrvNZROseNkpSL-p-qsO0RT6H+81xX4gg-TV71gQ_UbYA@mail.gmail.com> (raw)
Hi,
I am noticing a regression on the BLKRRPART ioctl after we changed the
blkdev_reread_part() logic to reopen the device with commit
68e6582e8f2dc32fd2458b9926564faa1fb4560e["reopen the device in
blkdev_reread_part"]
We now ignore the errors that used to be returned for
bdev_disk_changed(). I see that this was explicitly fixed for -EBUSY
(commit 68e6582e8f2dc32fd2458b9926564faa1fb4560e: block: return -EBUSY
when there are open partitions in blkdev_reread_part)
The regression I am particularly interested in is when we get an -EIO
error from the disk and BLKRRPART incorrectly reports success when it
actually failed to reread partitions.
Looking for advice.
Thanks,
Saranya
next reply other threads:[~2024-02-07 4:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 4:28 Saranya Muruganandam [this message]
2024-02-12 15:44 ` regression on BLKRRPART ioctl for EIO Christoph Hellwig
[not found] ` <CAP9s-Sr3_GVYBv-XObPRC9L27jJoQqX40d8g3gysEmy6VdQS1Q@mail.gmail.com>
2024-02-13 4:01 ` Saranya Muruganandam
2024-02-27 2:38 ` Saranya Muruganandam
2024-02-27 3:13 ` Yu Kuai
2024-03-07 18:14 ` Saranya Muruganandam
2024-03-08 16:32 ` Christoph Hellwig
2024-03-20 0:20 ` Saranya Muruganandam
2024-03-20 1:51 ` Christoph Hellwig
2024-04-05 2:04 ` Saranya Muruganandam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP9s-SrvNZROseNkpSL-p-qsO0RT6H+81xX4gg-TV71gQ_UbYA@mail.gmail.com \
--to=saranyamohan@google.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).