From: joeyli <jlee@suse.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-block@vger.kernel.org, kernel-janitors@vger.kernel.org,
Justin Sanders <justin@coraid.com>,
LKML <linux-kernel@vger.kernel.org>,
Chun-Yi Lee <joeyli.kernel@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jens Axboe <axboe@kernel.dk>, Kirill Korotaev <dev@openvz.org>,
Nicolai Stange <nstange@suse.com>,
Pavel Emelianov <xemul@openvz.org>
Subject: Re: [PATCH] aoe: fix the potential use-after-free problem in more places
Date: Mon, 13 May 2024 19:56:05 +0800 [thread overview]
Message-ID: <20240513115605.GE4433@linux-l9pv.suse> (raw)
In-Reply-To: <11361de9-b145-41c0-8d5e-5312cd710124@web.de>
Hi Markus,
Thanks for your review! I will send v2 patch.
Joey Lee
On Tue, Apr 30, 2024 at 06:16:00PM +0200, Markus Elfring wrote:
> > For fixing CVE-2023-6270, f98364e92662 patch moved dev_put() from
> …
>
> Please add a subject for the mentioned commit hash.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc6#n99
>
>
> > This patch adds dev_hold() to those functions and also uses dev_put()
> > when the skb_clone() returns NULL.
>
> Please improve this change description with a corresponding imperative wording.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc6#n94
>
>
> …
> > Fixes: f98364e92662 ("aoe: fix the potential use-after-free problem in
> > aoecmd_cfg_pkts")
>
> I suggest to omit a line break for this tag.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc6#n145
>
>
> …
> > +++ b/drivers/block/aoe/aoecmd.c
> …
> > @@ -401,7 +402,8 @@ aoecmd_ata_rw(struct aoedev *d)
> > __skb_queue_head_init(&queue);
> > __skb_queue_tail(&queue, skb);
> > aoenet_xmit(&queue);
> > - }
> > + } else
> > + dev_put(f->t->ifp->nd);
> > return 1;
> > }
> >
> …
> > @@ -617,7 +622,8 @@ probe(struct aoetgt *t)
> > __skb_queue_head_init(&queue);
> > __skb_queue_tail(&queue, skb);
> > aoenet_xmit(&queue);
> > - }
> > + } else
> > + dev_put(f->t->ifp->nd);
> > }
> >
> > static long
> …
>
> Should curly brackets be used for both if branches in these function implementations?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.9-rc6#n213
>
> Regards,
> Markus
next prev parent reply other threads:[~2024-05-13 11:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 13:48 [PATCH] aoe: fix the potential use-after-free problem in more places Lee, Chun-Yi
2024-04-30 15:14 ` joeyli
2024-04-30 16:16 ` Markus Elfring
2024-05-13 11:56 ` joeyli [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-05-14 5:42 Lee, Chun-Yi
2024-05-14 7:42 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240513115605.GE4433@linux-l9pv.suse \
--to=jlee@suse.com \
--cc=Markus.Elfring@web.de \
--cc=axboe@kernel.dk \
--cc=davem@davemloft.net \
--cc=dev@openvz.org \
--cc=joeyli.kernel@gmail.com \
--cc=justin@coraid.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nstange@suse.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).