From: "zhaoyang.huang" <zhaoyang.huang@unisoc.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>,
Jens Axboe <axboe@kernel.dk>, Tejun Heo <tj@kernel.org>,
Josef Bacik <josef@toxicpanda.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>, <linux-mm@kvack.org>,
<linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<cgroups@vger.kernel.org>,
Zhaoyang Huang <huangzhaoyang@gmail.com>, <steve.kang@unisoc.com>
Subject: [RFC PATCH 1/2] block: introduce helper function to calculate bps budgt
Date: Thu, 9 May 2024 10:39:36 +0800 [thread overview]
Message-ID: <20240509023937.1090421-2-zhaoyang.huang@unisoc.com> (raw)
In-Reply-To: <20240509023937.1090421-1-zhaoyang.huang@unisoc.com>
From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
The 'over-sized' bio under blk throttle control will be delayed to
launch which breaks original IO timing and have the immediate BW be
not within the bps limit. Introduce a helper function to calculate block
device's budgt which provide the allowed bytes for current bio.
Signed-off-by: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
---
block/blk-throttle.c | 44 ++++++++++++++++++++++++++++++++++++++
include/linux/blk-cgroup.h | 10 +++++++++
2 files changed, 54 insertions(+)
diff --git a/block/blk-throttle.c b/block/blk-throttle.c
index f4850a6f860b..41c75258183d 100644
--- a/block/blk-throttle.c
+++ b/block/blk-throttle.c
@@ -10,6 +10,7 @@
#include <linux/blkdev.h>
#include <linux/bio.h>
#include <linux/blktrace_api.h>
+#include <linux/cgroup.h>
#include "blk.h"
#include "blk-cgroup-rwstat.h"
#include "blk-stat.h"
@@ -2365,6 +2366,49 @@ void blk_throtl_bio_endio(struct bio *bio)
}
#endif
+unsigned long blk_throttle_budgt(struct block_device *bdev)
+{
+ struct request_queue *q = bdev_get_queue(bdev);
+ struct blkcg *blkcg;
+ struct blkcg_gq *blkg;
+ struct throtl_grp *tg;
+ long long bytes_allowed = 0;
+ unsigned long jiffy_elapsed, jiffy_elapsed_rnd;
+ u64 bps_limit;
+
+ if (!q)
+ return U64_MAX;
+
+ rcu_read_lock();
+ spin_lock_irq(&q->queue_lock);
+ blkcg = css_to_blkcg(task_css(current, io_cgrp_id));
+ if (!blkcg)
+ goto out;
+
+ blkg = blkg_lookup(blkcg, q);
+ if (!blkg || !blkg_tryget(blkg))
+ goto out;
+
+ tg = blkg_to_tg(blkg);
+ bps_limit = tg_bps_limit(tg, READ);
+ if (bps_limit == U64_MAX)
+ goto out;
+
+ jiffy_elapsed = jiffy_elapsed_rnd = jiffies - tg->slice_start[READ];
+ if (!jiffy_elapsed)
+ jiffy_elapsed_rnd = tg->td->throtl_slice;
+
+ jiffy_elapsed_rnd = roundup(jiffy_elapsed_rnd, tg->td->throtl_slice);
+ bytes_allowed = calculate_bytes_allowed(bps_limit, jiffy_elapsed_rnd) +
+ tg->carryover_bytes[READ];
+ blkg_put(blkg);
+out:
+ spin_unlock_irq(&q->queue_lock);
+ rcu_read_unlock();
+ return bytes_allowed;
+}
+
+
int blk_throtl_init(struct gendisk *disk)
{
struct request_queue *q = disk->queue;
diff --git a/include/linux/blk-cgroup.h b/include/linux/blk-cgroup.h
index dd5841a42c33..ba79fa464e0a 100644
--- a/include/linux/blk-cgroup.h
+++ b/include/linux/blk-cgroup.h
@@ -15,10 +15,12 @@
*/
#include <linux/types.h>
+#include <linux/limits.h>
struct bio;
struct cgroup_subsys_state;
struct gendisk;
+struct block_device;
#define FC_APPID_LEN 129
@@ -45,6 +47,14 @@ static inline struct cgroup_subsys_state *bio_blkcg_css(struct bio *bio)
}
#endif /* CONFIG_BLK_CGROUP */
+#ifdef CONFIG_BLK_DEV_THROTTLING
+unsigned long blk_throttle_budgt(struct block_device *bdev);
+#else
+static inline unsigned long blk_throttle_budgt(struct block_device *bdev)
+{
+ return U64_MAX;
+}
+#endif
int blkcg_set_fc_appid(char *app_id, u64 cgrp_id, size_t app_id_len);
char *blkcg_get_fc_appid(struct bio *bio);
--
2.25.1
next prev parent reply other threads:[~2024-05-09 2:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 2:39 [RFC PATCH 0/2] introduce budgt control in readahead zhaoyang.huang
2024-05-09 2:39 ` zhaoyang.huang [this message]
2024-05-09 2:39 ` [RFC PATCH 2/2] mm: " zhaoyang.huang
2024-05-09 3:15 ` Matthew Wilcox
2024-05-10 2:43 ` Zhaoyang Huang
2024-05-10 3:18 ` Matthew Wilcox
2024-05-11 7:35 ` Zhaoyang Huang
2024-05-14 2:37 ` Zhaoyang Huang
2024-05-09 12:39 ` Christoph Hellwig
2024-05-10 3:06 ` Zhaoyang Huang
2024-05-10 4:14 ` Matthew Wilcox
2024-05-10 7:08 ` Zhaoyang Huang
-- strict thread matches above, loose matches on Subject: below --
2024-05-15 1:23 [RFC PATCH 0/2] introduce precised blk-throttle control zhaoyang.huang
2024-05-15 1:23 ` [RFC PATCH 1/2] block: introduce helper function to calculate bps budgt zhaoyang.huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240509023937.1090421-2-zhaoyang.huang@unisoc.com \
--to=zhaoyang.huang@unisoc.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=baolin.wang@linux.alibaba.com \
--cc=cgroups@vger.kernel.org \
--cc=huangzhaoyang@gmail.com \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=steve.kang@unisoc.com \
--cc=tj@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).