From: Saranya Muruganandam <saranyamohan@google.com>
To: Christoph Hellwig <hch@lst.de>, linux-block@vger.kernel.org
Cc: Saranya Muruganandam <saranyamohan@google.com>
Subject: [PATCH blktests] block/035: test return EIO from BLKRRPART
Date: Thu, 4 Apr 2024 18:56:57 -0700 [thread overview]
Message-ID: <20240405015657.751659-1-saranyamohan@google.com> (raw)
When we fail to reread the partition superblock from the disk, due to
bad sector or bad disk etc, BLKRRPART should fail with EIO.
Simulate failure for the entire block device and run
"blockdev --rereadpt" and expect it to fail and return EIO instead of
pass.
Link: https://lore.kernel.org/all/20240405014253.748627-1-saranyamohan@google.com/
Signed-off-by: Saranya Muruganandam <saranyamohan@google.com>
---
tests/block/035 | 80 +++++++++++++++++++++++++++++++++++++++++++++
tests/block/035.out | 7 ++++
2 files changed, 87 insertions(+)
create mode 100755 tests/block/035
create mode 100644 tests/block/035.out
diff --git a/tests/block/035 b/tests/block/035
new file mode 100755
index 0000000..3b307f1
--- /dev/null
+++ b/tests/block/035
@@ -0,0 +1,80 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-3.0+
+# Copyright (C) 2024 Saranya Muruganandam
+#
+# Regression test for BLKRRPART.
+#
+# If we fail to read the partition table due to bad sector or other IO
+# failures, running "blockdev --rereadpt" should fail and return
+# -EIO. On a buggy kernel, it passes unexpectedly.
+
+. tests/block/rc
+
+DESCRIPTION="test return EIO from BLKRRPART for whole-dev"
+QUICK=1
+DEBUGFS_MNT="/sys/kernel/debug"
+
+
+_have_debugfs() {
+
+ if [[ ! -d /sys/kernel/debug ]]; then
+ SKIP_REASONS+=("debugfs does not exist")
+ return 1
+ fi
+ return 0
+}
+
+requires() {
+ _have_debugfs
+}
+
+
+allow_fail_make_request()
+{
+ [ -f "$DEBUGFS_MNT/fail_make_request/probability" ] \
+ || _notrun "$DEBUGFS_MNT/fail_make_request \
+ not found. Seems that CONFIG_FAIL_MAKE_REQUEST kernel config option not enabled"
+
+ echo "Allow global fail_make_request feature"
+ echo 100 > $DEBUGFS_MNT/fail_make_request/probability
+ echo 9999999 > $DEBUGFS_MNT/fail_make_request/times
+ echo 0 > /sys/kernel/debug/fail_make_request/verbose
+
+ echo "Force TEST_DEV device failure"
+ echo 1 > /sys/block/$(basename ${TEST_DEV})/make-it-fail
+
+}
+
+disallow_fail_make_request()
+{
+ echo "Make TEST_DEV device operatable again"
+ echo 0 > /sys/block/$(basename ${TEST_DEV})/make-it-fail
+
+ echo "Disallow global fail_make_request feature"
+ echo 0 > $DEBUGFS_MNT/fail_make_request/probability
+ echo 0 > $DEBUGFS_MNT/fail_make_request/times
+}
+
+
+test_device() {
+ echo "Running ${TEST_NAME}"
+
+ allow_fail_make_request
+
+ # Check rereading partitions on bad disk cannot open /dev/sdc: Input/output error
+ local out=$(blockdev --rereadpt ${TEST_DEV} 2>&1)
+ echo $out | grep -q "Input/output error"
+ if [ $? -eq 0 ]; then
+ echo "Return EIO for BLKRRPART on bad disk"
+ else
+ echo "Did not return EIO for BLKRRPART on bad disk"
+ fi
+
+ echo $out >> "$FULL"
+ status=$?
+
+ disallow_fail_make_request
+
+ echo "Test complete"
+}
+
diff --git a/tests/block/035.out b/tests/block/035.out
new file mode 100644
index 0000000..3fbfd77
--- /dev/null
+++ b/tests/block/035.out
@@ -0,0 +1,7 @@
+Running block/035
+Allow global fail_make_request feature
+Force TEST_DEV device failure
+Return EIO for BLKRRPART on bad disk
+Make TEST_DEV device operatable again
+Disallow global fail_make_request feature
+Test complete
--
2.44.0.478.gd926399ef9-goog
next reply other threads:[~2024-04-05 1:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 1:56 Saranya Muruganandam [this message]
2024-04-05 6:52 ` [PATCH blktests] block/035: test return EIO from BLKRRPART Christoph Hellwig
2024-04-05 7:52 ` Chaitanya Kulkarni
2024-04-05 8:05 ` Chaitanya Kulkarni
2024-04-06 4:46 ` Saranya Muruganandam
2024-04-08 6:45 ` Shinichiro Kawasaki
2024-04-10 0:15 ` Saranya Muruganandam
2024-04-10 5:13 ` Shinichiro Kawasaki
2024-04-10 17:02 ` Saranya Muruganandam
2024-04-11 5:29 ` Shinichiro Kawasaki
2024-04-11 23:47 ` [PATCH v2] " Saranya Muruganandam
2024-04-12 7:13 ` Shinichiro Kawasaki
2024-04-05 17:48 ` [PATCH blktests] " Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240405015657.751659-1-saranyamohan@google.com \
--to=saranyamohan@google.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).