* Re: [PATCH] block: add check that partition length needs to be aligned with block size
2023-06-26 17:10 ` [PATCH] block: add check that partition length needs to be aligned with block size Min Li
@ 2023-06-26 9:38 ` Damien Le Moal
2023-06-26 14:42 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Damien Le Moal @ 2023-06-26 9:38 UTC (permalink / raw
To: Min Li, axboe, willy, hch, gregkh; +Cc: linux-block, linux-kernel
On 6/27/23 02:10, Min Li wrote:
> Before calling add partition or resize partition, there is no check
> on whether the length is aligned with the logical block size.
> If the logical block size of the disk is larger than 512 bytes,
> then the partition size maybe not the multiple of the logical block size,
> and when the last sector is read, bio_truncate() will adjust the bio size,
> resulting in an IO error if the size of the read command is smaller than
> the logical block size.If integrity data is supported, this will also
> result in a null pointer dereference when calling bio_integrity_free.
>
> Signed-off-by: Min Li <min15.li@samsung.com>
> ---
> block/ioctl.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/block/ioctl.c b/block/ioctl.c
> index 9c5f637ff153..aa95b5561169 100644
> --- a/block/ioctl.c
> +++ b/block/ioctl.c
> @@ -35,6 +35,9 @@ static int blkpg_do_ioctl(struct block_device *bdev,
>
> start = p.start >> SECTOR_SHIFT;
> length = p.length >> SECTOR_SHIFT;
> + /*check if length is aligned to blocksize*/
Please add a space after /* and before */.
> + if (p.length & (bdev_logical_block_size(bdev) - 1))
> + return -EINVAL;
I would move this check before the "start = ...;" And while at it, I would also
move the check for p.start being aligned out of the "case BLKPG_ADD_PARTITION:"
together with this length alignment check. The p.start check is not needed for
BLKPG_RESIZE_PARTITION, but it will not hurt either.
>
> switch (op) {
> case BLKPG_ADD_PARTITION:
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] block: add check that partition length needs to be aligned with block size
2023-06-26 17:10 ` [PATCH] block: add check that partition length needs to be aligned with block size Min Li
2023-06-26 9:38 ` Damien Le Moal
@ 2023-06-26 14:42 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2023-06-26 14:42 UTC (permalink / raw
To: Min Li; +Cc: axboe, willy, hch, dlemoal, linux-block, linux-kernel
On Mon, Jun 26, 2023 at 05:10:21PM +0000, Min Li wrote:
> Before calling add partition or resize partition, there is no check
> on whether the length is aligned with the logical block size.
> If the logical block size of the disk is larger than 512 bytes,
> then the partition size maybe not the multiple of the logical block size,
> and when the last sector is read, bio_truncate() will adjust the bio size,
> resulting in an IO error if the size of the read command is smaller than
> the logical block size.If integrity data is supported, this will also
> result in a null pointer dereference when calling bio_integrity_free.
>
> Signed-off-by: Min Li <min15.li@samsung.com>
What commit id does this fix?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] block: add check that partition length needs to be aligned with block size
[not found] <CGME20230626091207epcas5p2a2957dfe97c4d82e39defa557d7ffd0e@epcas5p2.samsung.com>
@ 2023-06-26 17:10 ` Min Li
2023-06-26 9:38 ` Damien Le Moal
2023-06-26 14:42 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Min Li @ 2023-06-26 17:10 UTC (permalink / raw
To: axboe, willy, hch, dlemoal, gregkh; +Cc: linux-block, linux-kernel, Min Li
Before calling add partition or resize partition, there is no check
on whether the length is aligned with the logical block size.
If the logical block size of the disk is larger than 512 bytes,
then the partition size maybe not the multiple of the logical block size,
and when the last sector is read, bio_truncate() will adjust the bio size,
resulting in an IO error if the size of the read command is smaller than
the logical block size.If integrity data is supported, this will also
result in a null pointer dereference when calling bio_integrity_free.
Signed-off-by: Min Li <min15.li@samsung.com>
---
block/ioctl.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/block/ioctl.c b/block/ioctl.c
index 9c5f637ff153..aa95b5561169 100644
--- a/block/ioctl.c
+++ b/block/ioctl.c
@@ -35,6 +35,9 @@ static int blkpg_do_ioctl(struct block_device *bdev,
start = p.start >> SECTOR_SHIFT;
length = p.length >> SECTOR_SHIFT;
+ /*check if length is aligned to blocksize*/
+ if (p.length & (bdev_logical_block_size(bdev) - 1))
+ return -EINVAL;
switch (op) {
case BLKPG_ADD_PARTITION:
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-26 14:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20230626091207epcas5p2a2957dfe97c4d82e39defa557d7ffd0e@epcas5p2.samsung.com>
2023-06-26 17:10 ` [PATCH] block: add check that partition length needs to be aligned with block size Min Li
2023-06-26 9:38 ` Damien Le Moal
2023-06-26 14:42 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).