From: Kent Overstreet <kent.overstreet@linux.dev>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Johannes Berg <johannes.berg@intel.com>,
linux-bcachefs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: debugfs revoke broken?
Date: Mon, 15 Apr 2024 14:02:33 -0400 [thread overview]
Message-ID: <ra3ig25pwua6wm6v7vqexjvwybfpk23i5qqfeihth4f3zygjb6@7ykqlkyu25tb> (raw)
In-Reply-To: <2024041557-stereo-wafer-1551@gregkh>
On Mon, Apr 15, 2024 at 10:47:56AM +0200, Greg Kroah-Hartman wrote:
> So this file was open when debugfs_remove() was called?
Seems likely.
> Any chance you can bisect? We just fixed some issues here in
> 952c3fce297f ("debugfs: fix wait/cancellation handling during remove")
> that I thought should have handled this. If you revert that commit,
> does things work again? And/or what about commit 8c88a474357e
> ("debugfs: add API to allow debugfs operations cancellation")? Maybe we
> need to go back to not having completions at all in the debugfs remove
> path and just live with waiting for the files to be removed before
> continuing (which should at the least, resolve the issue you see here,
> while slowing things down a bit.)
No, this doesn't occur often enough to bisect, unfortunately. All my
tests bang on sysfs/debugfs in the background to torture test those
codepaths, and I've seen 2 occurrences out of thousands of test runs -
it's rare.
prev parent reply other threads:[~2024-04-15 18:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 22:32 debugfs revoke broken? Kent Overstreet
2024-04-15 8:47 ` Greg Kroah-Hartman
2024-04-15 18:02 ` Kent Overstreet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ra3ig25pwua6wm6v7vqexjvwybfpk23i5qqfeihth4f3zygjb6@7ykqlkyu25tb \
--to=kent.overstreet@linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=johannes.berg@intel.com \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).