From: Kent Overstreet <kent.overstreet@linux.dev>
To: Hongbo Li <lihongbo22@huawei.com>
Cc: bfoster@redhat.com, linux-bcachefs@vger.kernel.org,
ruanjinjie@huawei.com
Subject: Re: [PATCH] bcachefs: fix the error code when mounting with incorrect options.
Date: Mon, 19 Feb 2024 05:04:49 -0500 [thread overview]
Message-ID: <b3edruyblko7tbpbbpftov75tmnmwir4mx7m2mwpdzzaylt3av@ttwlfwzzoc6s> (raw)
In-Reply-To: <20240219095433.2566106-1-lihongbo22@huawei.com>
On Mon, Feb 19, 2024 at 05:54:33PM +0800, Hongbo Li wrote:
> When mount with incorrect options such as:
> "mount -t bcachefs -o errors=back /dev/loop1 /mnt/bcachefs/".
> It rebacks the error "mount: /mnt/bcachefs: permission denied."
> cause bch2_parse_mount_opts returns -1 and bch2_mount throws
> it up. This is unreasonable.
>
> The real error message should be like this:
> "mount: /mnt/bcachefs: wrong fs type, bad option, bad
> superblock on /dev/loop1, missing codepage or helper program,
> or other error."
Thanks for the patch.
As a general policy though, we're not adding new direct references to
the standard error codes (except - the -ENOMEM is fine here).
Instead of returning -EINVAL, you'll want to define new errcodes in
errcode.h; the left field is the errcode it derives from, by specifying
EINVAL there it'll be translated to -EINVAL at the module boundary.
Also, our private error codes should generally only be thrown at one
source code location, not reused for multiple things.
This makes for _much_ better error messages and easier debugging -
nothing is worse than chasing down a -EINVAL with inadequate loging.
Cheers,
Kent
>
> Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
> ---
> fs/bcachefs/opts.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/bcachefs/opts.c b/fs/bcachefs/opts.c
> index b1ed0b9a20d3..a9ee9eaab670 100644
> --- a/fs/bcachefs/opts.c
> +++ b/fs/bcachefs/opts.c
> @@ -456,7 +456,7 @@ int bch2_parse_mount_opts(struct bch_fs *c, struct bch_opts *opts,
>
> copied_opts = kstrdup(options, GFP_KERNEL);
> if (!copied_opts)
> - return -1;
> + return -ENOMEM;
> copied_opts_start = copied_opts;
>
> while ((opt = strsep(&copied_opts, ",")) != NULL) {
> @@ -501,11 +501,11 @@ int bch2_parse_mount_opts(struct bch_fs *c, struct bch_opts *opts,
>
> bad_opt:
> pr_err("Bad mount option %s", name);
> - ret = -1;
> + ret = -EINVAL;
> goto out;
> bad_val:
> pr_err("Invalid mount option %s", err.buf);
> - ret = -1;
> + ret = -EINVAL;
> goto out;
> out:
> kfree(copied_opts_start);
> --
> 2.34.1
>
prev parent reply other threads:[~2024-02-19 10:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 9:54 [PATCH] bcachefs: fix the error code when mounting with incorrect options Hongbo Li
2024-02-19 10:04 ` Kent Overstreet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3edruyblko7tbpbbpftov75tmnmwir4mx7m2mwpdzzaylt3av@ttwlfwzzoc6s \
--to=kent.overstreet@linux.dev \
--cc=bfoster@redhat.com \
--cc=lihongbo22@huawei.com \
--cc=linux-bcachefs@vger.kernel.org \
--cc=ruanjinjie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).