From: Hongbo Li <lihongbo22@huawei.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
<kent.overstreet@linux.dev>
Cc: <bfoster@redhat.com>, <linux-bcachefs@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] bcachefs: remove unneeded semicolon
Date: Mon, 15 Apr 2024 10:55:23 +0800 [thread overview]
Message-ID: <66546f2a-1fab-4115-8ff5-27e8aec276f1@huawei.com> (raw)
In-Reply-To: <20240415023557.5851-1-jiapeng.chong@linux.alibaba.com>
I remember other people also submit this likely patch:
https://lore.kernel.org/linux-bcachefs/20240103010720.39784-1-yang.lee@linux.alibaba.com/
https://lore.kernel.org/linux-bcachefs/20240103095942.3982021-1-lihongbo22@huawei.com/
On 2024/4/15 10:35, Jiapeng Chong wrote:
> No functional modification involved.
>
> ./fs/bcachefs/super.c:1128:59-60: Unneeded semicolon.
> ./fs/bcachefs/super.c:1133:59-60: Unneeded semicolon.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8755
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> fs/bcachefs/super.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/bcachefs/super.c b/fs/bcachefs/super.c
> index 8daf80a38d60..234f19ea8f30 100644
> --- a/fs/bcachefs/super.c
> +++ b/fs/bcachefs/super.c
> @@ -1125,12 +1125,12 @@ static int bch2_dev_in_fs(struct bch_sb_handle *fs,
>
> prt_bdevname(&buf, fs->bdev);
> prt_char(&buf, ' ');
> - bch2_prt_datetime(&buf, le64_to_cpu(fs->sb->write_time));;
> + bch2_prt_datetime(&buf, le64_to_cpu(fs->sb->write_time));
> prt_newline(&buf);
>
> prt_bdevname(&buf, sb->bdev);
> prt_char(&buf, ' ');
> - bch2_prt_datetime(&buf, le64_to_cpu(sb->sb->write_time));;
> + bch2_prt_datetime(&buf, le64_to_cpu(sb->sb->write_time));
> prt_newline(&buf);
>
> if (!opts->no_splitbrain_check)
prev parent reply other threads:[~2024-04-15 2:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 2:35 [PATCH] bcachefs: remove unneeded semicolon Jiapeng Chong
2024-04-15 2:48 ` Hongbo Li
2024-04-15 2:55 ` Hongbo Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66546f2a-1fab-4115-8ff5-27e8aec276f1@huawei.com \
--to=lihongbo22@huawei.com \
--cc=abaci@linux.alibaba.com \
--cc=bfoster@redhat.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).