From: Coly Li <colyli@suse.de>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: Kent Overstreet <kent.overstreet@gmail.com>,
Bcache Linux <linux-bcache@vger.kernel.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] bcache: remove redundant assignment to variable cur_idx
Date: Tue, 25 Jul 2023 20:49:19 +0800 [thread overview]
Message-ID: <DFEED6F9-45FE-48BA-BE50-51B780846DE3@suse.de> (raw)
In-Reply-To: <20230725114637.37073-1-colin.i.king@gmail.com>
> 2023年7月25日 19:46，Colin Ian King <colin.i.king@gmail.com> 写道：
>
> Variable cur_idx is being initialized with a value that is never read,
> it is being re-assigned later in a while-loop. Remove the redundant
> assignment. Cleans up clang scan build warning:
>
> drivers/md/bcache/writeback.c:916:2: warning: Value stored to 'cur_idx'
> is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Looks good to me. Thanks.
Reviewed-by: Coly Li <colyli@suse.de>
Coly Li
> ---
> drivers/md/bcache/writeback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/bcache/writeback.c b/drivers/md/bcache/writeback.c
> index 24c049067f61..c3e872e0a6f2 100644
> --- a/drivers/md/bcache/writeback.c
> +++ b/drivers/md/bcache/writeback.c
> @@ -913,7 +913,7 @@ static int bch_dirty_init_thread(void *arg)
> int cur_idx, prev_idx, skip_nr;
>
> k = p = NULL;
> - cur_idx = prev_idx = 0;
> + prev_idx = 0;
>
> bch_btree_iter_init(&c->root->keys, &iter, NULL);
> k = bch_btree_iter_next_filter(&iter, &c->root->keys, bch_ptr_bad);
> --
> 2.39.2
>
prev parent reply other threads:[~2023-07-25 12:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 11:46 [PATCH][next] bcache: remove redundant assignment to variable cur_idx Colin Ian King
2023-07-25 12:49 ` Coly Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFEED6F9-45FE-48BA-BE50-51B780846DE3@suse.de \
--to=colyli@suse.de \
--cc=colin.i.king@gmail.com \
--cc=kent.overstreet@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).