From: Zheng Hacker <hackerzheng666@gmail.com>
To: Eric Wheeler <bcache@lists.ewheeler.net>
Cc: Zheng Wang <zyytlz.wz@163.com>,
colyli@suse.de, kent.overstreet@gmail.com,
linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org,
alex000young@gmail.com
Subject: Re: [PATCH] bcache: Fix __bch_btree_node_alloc to make the failure behavior consistent
Date: Fri, 3 Feb 2023 10:08:13 +0800 [thread overview]
Message-ID: <CAJedcCxpj+MgiMTLXOgUFuK1aW9H7BXdB3nQnu8KH2LCKpPA_Q@mail.gmail.com> (raw)
In-Reply-To: <85540cd-91fd-9aa7-23c4-2fb529d43fc2@ewheeler.net>
Eric Wheeler <bcache@lists.ewheeler.net> 于2023年2月3日周五 04:37写道：
>
> On Thu, 2 Feb 2023, Zheng Wang wrote:
>
> > In some specific situation, the return value of __bch_btree_node_alloc may
> > be NULL. This may lead to poential NULL pointer dereference in caller
> > function like a calling chaion :
> > btree_split->bch_btree_node_alloc->__bch_btree_node_alloc.
> >
> > Fix it by initialize return value in __bch_btree_node_alloc before return.
> >
> > Fixes: cafe56359144 ("bcache: A block layer cache")
> > Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
>
> Be sure to add `Cc: stable@vger.kernel.org`
>
> -Eric
>
Thanks for your kind reminding. Will do in the next patch.
Best regards,
Zheng Wang
prev parent reply other threads:[~2023-02-03 2:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 15:15 [PATCH] bcache: Fix __bch_btree_node_alloc to make the failure behavior consistent Zheng Wang
2023-02-02 16:23 ` Coly Li
2023-02-02 17:19 ` Zheng Hacker
2023-02-02 20:37 ` Eric Wheeler
2023-02-03 2:08 ` Zheng Hacker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJedcCxpj+MgiMTLXOgUFuK1aW9H7BXdB3nQnu8KH2LCKpPA_Q@mail.gmail.com \
--to=hackerzheng666@gmail.com \
--cc=alex000young@gmail.com \
--cc=bcache@lists.ewheeler.net \
--cc=colyli@suse.de \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zyytlz.wz@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).