From: Zheng Hacker <hackerzheng666@gmail.com>
To: Eric Wheeler <bcache@lists.ewheeler.net>
Cc: Zheng Wang <zyytlz.wz@163.com>,
colyli@suse.de, kent.overstreet@gmail.com,
linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org,
alex000young@gmail.com, stable@vger.kernel.org
Subject: Re: [RESEBD PATCH v3] bcache: Remove some unnecessary NULL point check for the return value of __bch_btree_node_alloc-related pointer
Date: Sat, 18 Feb 2023 15:06:32 +0800 [thread overview]
Message-ID: <CAJedcCwhtqNTmQ1_P3EDZ+11WiNLOpBdv-k9oP=u4m3-FY-5fQ@mail.gmail.com> (raw)
In-Reply-To: <62507028-c27d-82b8-2db2-5642e2388e3e@ewheeler.net>
Eric Wheeler <bcache@lists.ewheeler.net> 于2023年2月18日周六 05:57写道：
>
> On Fri, 17 Feb 2023, Zheng Wang wrote:
>
> > Due to the previously fix of __bch_btree_node_alloc, the return value will
> > never be a NULL pointer. So IS_ERR is enough to handle the failure
> > situation. Fix it by replacing IS_ERR_OR_NULL check to IS_ERR check.
> >
> > Fixes: cafe56359144 ("bcache: A block layer cache")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
> > ---
> > v3:
> > - Add Cc: stable@vger.kernel.org suggested by Eric
>
> Make sure that the commit
> bcache: Fix __bch_btree_node_alloc to make the failure behavior consistent
> is committed _before_ this "Remove some unnecessary NULL point check..."
> patch.
Oh, sorry for my mistake. I forgot to commit the first patch. I'll try
to commit it first.
>
> It would be a good idea to add "this patch depends on `bcache: Fix
> __bch_btree_node_alloc to make the failure behavior consistent`" to the
> commit message so the stable maintainers know.
Yes, I will append that msg in the next version.
Best regargds,
Zheng
prev parent reply other threads:[~2023-02-18 7:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 10:09 [RESEBD PATCH v3] bcache: Remove some unnecessary NULL point check for the return value of __bch_btree_node_alloc-related pointer Zheng Wang
2023-02-17 21:57 ` Eric Wheeler
2023-02-18 7:06 ` Zheng Hacker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJedcCwhtqNTmQ1_P3EDZ+11WiNLOpBdv-k9oP=u4m3-FY-5fQ@mail.gmail.com' \
--to=hackerzheng666@gmail.com \
--cc=alex000young@gmail.com \
--cc=bcache@lists.ewheeler.net \
--cc=colyli@suse.de \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=zyytlz.wz@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).