From: Coly Li <colyli@suse.de>
To: Andrea Tomassetti <andrea.tomassetti-opensource@devo.com>
Cc: Kent Overstreet <kent.overstreet@gmail.com>,
linux-bcache@vger.kernel.org
Subject: Re: [PATCH] bcache: Remove dead references to cache_readaheads
Date: Mon, 27 Feb 2023 19:07:08 +0800 [thread overview]
Message-ID: <417B9691-D667-4F70-9DEF-19E84C70A2CC@suse.de> (raw)
In-Reply-To: <20230225153355.2779474-1-andrea.tomassetti-opensource@devo.com>
> 2023年2月25日 23:33，Andrea Tomassetti <andrea.tomassetti-opensource@devo.com> 写道：
>
> The cache_readaheads stat counter is not used anymore and should be
> removed.
>
> Signed-off-by: Andrea Tomassetti <andrea.tomassetti-opensource@devo.com>
Nice cache, added to my for-next.
Thanks.
Coly Li
> ---
> Documentation/admin-guide/bcache.rst | 3 ---
> drivers/md/bcache/stats.h | 1 -
> 2 files changed, 4 deletions(-)
>
> diff --git a/Documentation/admin-guide/bcache.rst b/Documentation/admin-guide/bcache.rst
> index bb5032a99234..6fdb495ac466 100644
> --- a/Documentation/admin-guide/bcache.rst
> +++ b/Documentation/admin-guide/bcache.rst
> @@ -508,9 +508,6 @@ cache_miss_collisions
> cache miss, but raced with a write and data was already present (usually 0
> since the synchronization for cache misses was rewritten)
>
> -cache_readaheads
> - Count of times readahead occurred.
> -
> Sysfs - cache set
> ~~~~~~~~~~~~~~~~~
>
> diff --git a/drivers/md/bcache/stats.h b/drivers/md/bcache/stats.h
> index bd3afc856d53..21b445f8af15 100644
> --- a/drivers/md/bcache/stats.h
> +++ b/drivers/md/bcache/stats.h
> @@ -18,7 +18,6 @@ struct cache_stats {
> unsigned long cache_misses;
> unsigned long cache_bypass_hits;
> unsigned long cache_bypass_misses;
> - unsigned long cache_readaheads;
> unsigned long cache_miss_collisions;
> unsigned long sectors_bypassed;
>
> --
> 2.39.2
>
prev parent reply other threads:[~2023-02-27 11:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-25 15:33 [PATCH] bcache: Remove dead references to cache_readaheads Andrea Tomassetti
2023-02-27 11:07 ` Coly Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=417B9691-D667-4F70-9DEF-19E84C70A2CC@suse.de \
--to=colyli@suse.de \
--cc=andrea.tomassetti-opensource@devo.com \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).